From: gautam.vivek@samsung.com (Vivek Gautam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/6] usb: host: ohci-exynos: Use devm_ioremap_resource instead of devm_ioremap
Date: Sat, 10 May 2014 17:30:10 +0530 [thread overview]
Message-ID: <1399723210-21569-7-git-send-email-gautam.vivek@samsung.com> (raw)
In-Reply-To: <1399723210-21569-1-git-send-email-gautam.vivek@samsung.com>
Using devm_ioremap_resource() API should actually be preferred over
devm_ioremap(), since the former request the mem region first and then
gives back the ioremap'ed memory pointer.
devm_ioremap_resource() calls request_mem_region(), therby preventing
other drivers to make any overlapping call to the same region.
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
drivers/usb/host/ohci-exynos.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c
index 9cf80cb..dec691d 100644
--- a/drivers/usb/host/ohci-exynos.c
+++ b/drivers/usb/host/ohci-exynos.c
@@ -120,10 +120,9 @@ skip_phy:
hcd->rsrc_start = res->start;
hcd->rsrc_len = resource_size(res);
- hcd->regs = devm_ioremap(&pdev->dev, res->start, hcd->rsrc_len);
- if (!hcd->regs) {
- dev_err(&pdev->dev, "Failed to remap I/O memory\n");
- err = -ENOMEM;
+ hcd->regs = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(hcd->regs)) {
+ err = PTR_ERR(hcd->regs);
goto fail_io;
}
--
1.7.10.4
next prev parent reply other threads:[~2014-05-10 12:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-10 12:00 [PATCH v2 0/6] usb: host: Cleanup for ioremap'ing hcd memory Vivek Gautam
2014-05-10 12:00 ` [PATCH v2 1/6] usb: host: ehci-exynos: Use devm_ioremap_resource instead of devm_ioremap Vivek Gautam
2014-05-10 12:00 ` [PATCH v2 2/6] usb: host: ehci-msm: " Vivek Gautam
2014-05-10 12:00 ` [PATCH v2 3/6] usb: host: ehci-mv: " Vivek Gautam
2014-05-10 12:00 ` [PATCH v2 4/6] usb: host: ehci-spear: " Vivek Gautam
2014-05-10 12:00 ` [PATCH v2 5/6] usb: host: ehci-tegra: " Vivek Gautam
2014-05-12 16:58 ` Stephen Warren
2014-05-10 12:00 ` Vivek Gautam [this message]
2014-06-04 10:11 ` [PATCH v2 6/6] usb: host: ohci-exynos: " Vivek Gautam
2014-06-04 13:13 ` Thierry Reding
2014-06-06 13:02 ` Vivek Gautam
2014-06-06 22:52 ` Thierry Reding
2014-06-24 5:49 ` Vivek Gautam
2014-05-10 14:25 ` [PATCH v2 0/6] usb: host: Cleanup for ioremap'ing hcd memory Alexander Shiyan
2014-05-11 14:45 ` Vivek Gautam
2014-05-12 14:08 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399723210-21569-7-git-send-email-gautam.vivek@samsung.com \
--to=gautam.vivek@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).