From: Dmitry Osipenko <digetx@gmail.com>
To: Kejia Hu <kejia.hu@codethink.co.uk>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Peter De Schrijver <pdeschrijver@nvidia.com>,
Thomas Preston <thomas.preston@codethink.co.uk>
Subject: Re: [PATCH 5/5] clk: tegra: add tegra20 automotive init
Date: Fri, 8 Feb 2019 22:54:09 +0300 [thread overview]
Message-ID: <13a80190-bf33-ebf4-3076-843ca1e8ecdb@gmail.com> (raw)
In-Reply-To: <1549620609.19850.1.camel@codethink.co.uk>
08.02.2019 13:10, Kejia Hu пишет:
> On Thu, 2019-02-07 at 16:23 +0300, Dmitry Osipenko wrote:
>> this all looks very generic and much more board-specific than automotive
>
> Hi,
>
> Thanks for your reply.
>
> We got the clock data from nvidia pdk for the automotive which didn't
> set the clocks up in the same way as commercial parts, and we were told
> that there are certain clock restrictions for the automotive parts that
> the commercial ones do not have.
>
> Applying different clock configs for each nodes doesn't seems to be a
> good way, as they will be too scattered in the device tree. We proposed
> to add a new root node for the clock originally[1], and further
> discussion suggested us to distinguish the variation by reading the SKU
> info, thus came this patch. We can discuss further though.
>
> Regards
>
> [1] https://www.spinics.net/lists/arm-kernel/msg665344.html
>
I don't see any problems with specifying clock configs for each node in the device tree. It also looks to me that the clock configs you're suggesting in this series are only relevant for a one specific board (or maybe family). You could move out the assigned-clock configs into a separate DTSI file that will be shared by all of "automotive" boards.
Maybe it will make sense to have a custom init-table to avoid some of the fatal clock configurations during of early boot of the kernel. But maybe in this case we could just limit those vital clocks to a saner-common value?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-02-08 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190207125408.8776-1-kejia.hu@codethink.co.uk>
[not found] ` <20190207125408.8776-6-kejia.hu@codethink.co.uk>
2019-02-07 13:23 ` [PATCH 5/5] clk: tegra: add tegra20 automotive init Dmitry Osipenko
2019-02-08 10:10 ` Kejia Hu
2019-02-08 19:54 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13a80190-bf33-ebf4-3076-843ca1e8ecdb@gmail.com \
--to=digetx@gmail.com \
--cc=kejia.hu@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pdeschrijver@nvidia.com \
--cc=thomas.preston@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).