From: Thomas Zimmermann <tzimmermann@suse.de>
To: "Icenowy Zheng" <icenowy@aosc.io>,
"Sandy Huang" <hjc@rock-chips.com>,
"Heiko Stübner" <heiko@sntech.de>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>
Cc: linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/rockchip: kick firmware-based framebuffer when initializing
Date: Wed, 26 May 2021 14:00:23 +0200 [thread overview]
Message-ID: <13c50c42-4f2a-eed3-fc79-cbe6d1e7cae9@suse.de> (raw)
In-Reply-To: <20210526085527.155840-1-icenowy@aosc.io>
[-- Attachment #1.1.1: Type: text/plain, Size: 1831 bytes --]
Hi
I think we already fixed this at [1]. Apparently no on epicked it up. If
you awant to test, I'll add your Tested-by before merging the patch.
Best regards
Thomas
[1]
https://lore.kernel.org/dri-devel/20210516074833.451643-1-javierm@redhat.com/
Am 26.05.21 um 10:55 schrieb Icenowy Zheng:
> Since U-Boot now supports EFI and FB passing via EFI GOP, when booting
> rockchip SoCs via EFI, a EFI FB is available. However, currently when
> re-initializing display pipeline, the EFI FB is not removed, lead to
> fbcon not working (because the EFI FB is no longer bound to the display
> pipeline although it's still /dev/fb0 and fbcon is bound to it).
>
> Add some code for removing firmware-based FB when initializing KMS of
> rockchipdrm.
>
> Tested on Pinebook Pro (RK3399) with U-Boot patchset for initializing
> eDP display applied.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> index 212bd87c0c4a..3905fce6ce0b 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c
> @@ -158,6 +158,9 @@ static int rockchip_drm_bind(struct device *dev)
> */
> drm_dev->irq_enabled = true;
>
> + /* Remove early framebuffers (ie. efifb) */
> + drm_fb_helper_remove_conflicting_framebuffers(NULL, "rockchipdrmfb", false);
> +
> ret = rockchip_drm_fbdev_init(drm_dev);
> if (ret)
> goto err_unbind_all;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-05-26 13:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 8:55 [PATCH] drm/rockchip: kick firmware-based framebuffer when initializing Icenowy Zheng
2021-05-26 12:00 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13c50c42-4f2a-eed3-fc79-cbe6d1e7cae9@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).