linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: gautam.vivek@samsung.com (Vivek Gautam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] usb: host: xhci-plat: Caibrate PHY post host reset
Date: Wed,  9 Jul 2014 15:31:35 +0530	[thread overview]
Message-ID: <1404900096-1721-4-git-send-email-gautam.vivek@samsung.com> (raw)
In-Reply-To: <1404900096-1721-1-git-send-email-gautam.vivek@samsung.com>

Some quirky PHYs may require to be calibrated post the host
controller initialization.
The USB 3.0 DRD PHY on Exynos5420/5800 systems, coming along with
Synopsys's DWC3 controller, is one such PHY which needs to be
calibrated post xhci's reset at initialization time and at
resume time, to get the controller work at SuperSpeed.

Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
---
 drivers/usb/host/xhci-plat.c |   39 +++++++++++++++++++++++++++++++++++++--
 1 file changed, 37 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index e50bd7d..decf349 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -35,7 +35,27 @@ static void xhci_plat_quirks(struct device *dev, struct xhci_hcd *xhci)
 /* called during probe() after chip reset completes */
 static int xhci_plat_setup(struct usb_hcd *hcd)
 {
-	return xhci_gen_setup(hcd, xhci_plat_quirks);
+	struct device *parent;
+	int ret;
+
+	ret = xhci_gen_setup(hcd, xhci_plat_quirks);
+	if (ret) {
+		dev_err(hcd->self.controller, "xhci setup failed\n");
+		return ret;
+	}
+
+	parent = hcd->self.controller->parent;
+	if (of_device_is_compatible(parent->of_node, "synopsys,dwc3") ||
+	    of_device_is_compatible(parent->of_node, "snps,dwc3")) {
+		if (!IS_ERR(hcd->gen_phy)) {
+			ret = phy_calibrate(hcd->gen_phy);
+			if (ret < 0 && ret != -ENOTSUPP)
+				dev_err(hcd->self.controller,
+					"failed to calibrate USB PHY\n");
+		}
+	}
+
+	return ret;
 }
 
 static int xhci_plat_start(struct usb_hcd *hcd)
@@ -288,8 +308,23 @@ static int xhci_plat_resume(struct device *dev)
 {
 	struct usb_hcd	*hcd = dev_get_drvdata(dev);
 	struct xhci_hcd	*xhci = hcd_to_xhci(hcd);
+	int ret;
+
+	ret = xhci_resume(xhci, 0);
+	if (ret)
+		return ret;
 
-	return xhci_resume(xhci, 0);
+	if (of_device_is_compatible(dev->parent->of_node, "synopsys,dwc3") ||
+	    of_device_is_compatible(dev->parent->of_node, "snps,dwc3")) {
+		if (!IS_ERR(hcd->gen_phy)) {
+			ret = phy_calibrate(hcd->gen_phy);
+			if (ret < 0 && ret != -ENOTSUPP)
+				dev_err(hcd->self.controller,
+					"failed to calibrate USB PHY\n");
+		}
+	}
+
+	return ret;
 }
 
 static const struct dev_pm_ops xhci_plat_pm_ops = {
-- 
1.7.10.4

  parent reply	other threads:[~2014-07-09 10:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-09 10:01 [PATCH v2 0/4] Fine tune USB 3.0 PHY on exynos5420 Vivek Gautam
2014-07-09 10:01 ` [PATCH v2 1/4] phy: Add provision for calibrating phy Vivek Gautam
2014-07-09 10:01 ` [PATCH v2 2/4] usb: host: xhci-plat: Get PHYs for xhci's hcds Vivek Gautam
2014-07-09 17:56   ` Julius Werner
2014-07-11  3:40     ` Vivek Gautam
2014-07-09 10:01 ` Vivek Gautam [this message]
2014-07-09 17:58   ` [PATCH v2 3/4] usb: host: xhci-plat: Caibrate PHY post host reset Julius Werner
2014-07-11  3:48     ` Vivek Gautam
2014-07-09 10:01 ` [PATCH v2 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800 Vivek Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404900096-1721-4-git-send-email-gautam.vivek@samsung.com \
    --to=gautam.vivek@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).