linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ard.biesheuvel@linaro.org (Ard Biesheuvel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o
Date: Thu, 24 Jul 2014 18:03:26 +0200	[thread overview]
Message-ID: <1406217806-15538-1-git-send-email-ard.biesheuvel@linaro.org> (raw)

From: Andreas Schwab <schwab@suse.de>

This fixes the following build failure when building with CONFIG_MODVERSIONS
enabled:

  CC [M]  arch/arm64/crypto/aes-glue-ce.o
ld: cannot find arch/arm64/crypto/aes-glue-ce.o: No such file or directory
make[1]: *** [arch/arm64/crypto/aes-ce-blk.o] Error 1
make: *** [arch/arm64/crypto] Error 2

The $(obj)/aes-glue-%.o rule only creates $(obj)/.tmp_aes-glue-ce.o, it
should use if_changed_rule instead of if_changed_dep.

Signed-off-by: Andreas Schwab <schwab@suse.de>
[ardb: mention CONFIG_MODVERSIONS in commit log]
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---

Catalin,

Could you take this for 3.17 please? It fixes a build error when building
aes-ce-blk and/or aes-neon-blk as modules with CONFIG_MODVERSIONS enabled.

Cheers,
Ard.


 arch/arm64/crypto/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/crypto/Makefile b/arch/arm64/crypto/Makefile
index 2070a56ecc46..a3f935fde975 100644
--- a/arch/arm64/crypto/Makefile
+++ b/arch/arm64/crypto/Makefile
@@ -35,4 +35,4 @@ AFLAGS_aes-neon.o	:= -DINTERLEAVE=4
 CFLAGS_aes-glue-ce.o	:= -DUSE_V8_CRYPTO_EXTENSIONS
 
 $(obj)/aes-glue-%.o: $(src)/aes-glue.c FORCE
-	$(call if_changed_dep,cc_o_c)
+	$(call if_changed_rule,cc_o_c)
-- 
1.8.3.2

             reply	other threads:[~2014-07-24 16:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24 16:03 Ard Biesheuvel [this message]
2014-07-24 16:47 ` [PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o Catalin Marinas
  -- strict thread matches above, loose matches on Subject: below --
2014-06-30 13:14 Andreas Schwab
2014-06-30 13:38 ` Ard Biesheuvel
2014-06-30 13:56   ` Andreas Schwab
2014-06-30 14:08     ` Ard Biesheuvel
2014-07-24 12:29       ` Andreas Schwab
2014-07-24 12:35         ` Ard Biesheuvel
2014-07-24 12:53           ` Ard Biesheuvel
2014-07-24 13:26             ` Andreas Schwab
2014-07-24 13:29               ` Ard Biesheuvel
2014-07-24 13:40                 ` Andreas Schwab
2014-07-24 14:18                   ` Ard Biesheuvel
2014-07-24 14:24                     ` Ard Biesheuvel
2014-07-24 16:12                       ` Sam Ravnborg
2014-07-24 19:25                         ` Ard Biesheuvel
2014-07-24 20:45                           ` Sam Ravnborg
2014-07-25  6:28                             ` Ard Biesheuvel
2014-07-27 18:40                               ` Sam Ravnborg
2014-07-28 17:00                                 ` Ard Biesheuvel
2014-07-28 19:06                                   ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406217806-15538-1-git-send-email-ard.biesheuvel@linaro.org \
    --to=ard.biesheuvel@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).