From: l.stach@pengutronix.de (Lucas Stach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 06/21] PCI/MSI: Refactor struct msi_chip to make it become more common
Date: Mon, 15 Sep 2014 16:44:21 +0200 [thread overview]
Message-ID: <1410792261.3314.9.camel@pengutronix.de> (raw)
In-Reply-To: <1409911806-10519-7-git-send-email-wangyijing@huawei.com>
Am Freitag, den 05.09.2014, 18:09 +0800 schrieb Yijing Wang:
> Now there are a lot of __weak arch functions in MSI code.
> These functions make MSI driver complex. Thierry Reding Introduced
> a new MSI chip framework to configure MSI/MSI-X irq in ARM. Use
> the new MSI chip framework to refactor all other platform MSI
> arch code to eliminate weak arch MSI functions. This patch add
> .restore_irq() and .setup_irqs() to make it become more common.
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
This change looks good to me:
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/pci/msi.c | 15 +++++++++++++++
> include/linux/msi.h | 3 +++
> 2 files changed, 18 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
> index 539c11d..d78d637 100644
> --- a/drivers/pci/msi.c
> +++ b/drivers/pci/msi.c
> @@ -63,6 +63,11 @@ int __weak arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
> {
> struct msi_desc *entry;
> int ret;
> + struct msi_chip *chip;
> +
> + chip = arch_find_msi_chip(dev);
> + if (chip && chip->setup_irqs)
> + return chip->setup_irqs(dev, nvec, type);
>
> /*
> * If an architecture wants to support multiple MSI, it needs to
> @@ -105,6 +110,11 @@ void default_teardown_msi_irqs(struct pci_dev *dev)
>
> void __weak arch_teardown_msi_irqs(struct pci_dev *dev)
> {
> + struct msi_chip *chip = arch_find_msi_chip(dev);
> +
> + if (chip && chip->teardown_irqs)
> + return chip->teardown_irqs(dev);
> +
> return default_teardown_msi_irqs(dev);
> }
>
> @@ -128,6 +138,11 @@ static void default_restore_msi_irq(struct pci_dev *dev, int irq)
>
> void __weak arch_restore_msi_irqs(struct pci_dev *dev)
> {
> + struct msi_chip *chip = arch_find_msi_chip(dev);
> +
> + if (chip && chip->restore_irqs)
> + return chip->restore_irqs(dev);
> +
> return default_restore_msi_irqs(dev);
> }
>
> diff --git a/include/linux/msi.h b/include/linux/msi.h
> index 5650848..92a51e7 100644
> --- a/include/linux/msi.h
> +++ b/include/linux/msi.h
> @@ -72,7 +72,10 @@ struct msi_chip {
> struct list_head list;
>
> int (*setup_irq)(struct pci_dev *dev, struct msi_desc *desc);
> + int (*setup_irqs)(struct pci_dev *dev, int nvec, int type);
> void (*teardown_irq)(unsigned int irq);
> + void (*teardown_irqs)(struct pci_dev *dev);
> + void (*restore_irqs)(struct pci_dev *dev);
> };
>
> #endif /* LINUX_MSI_H */
--
Pengutronix e.K. | Lucas Stach |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2014-09-15 14:44 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 10:09 [PATCH v1 00/21] Use MSI chip to configure MSI/MSI-X in all platforms Yijing Wang
2014-09-05 10:09 ` [PATCH v1 01/21] PCI/MSI: Clean up struct msi_chip argument Yijing Wang
2014-09-05 10:09 ` [PATCH v1 02/21] PCI/MSI: Remove useless bus->msi assignment Yijing Wang
2014-09-05 10:09 ` [PATCH v1 03/21] MSI: Remove the redundant irq_set_chip_data() Yijing Wang
2014-09-15 14:00 ` Lucas Stach
2014-09-16 1:30 ` Yijing Wang
2014-09-16 10:29 ` Lucas Stach
2014-09-16 10:37 ` Yijing Wang
2014-09-05 10:09 ` [PATCH v1 04/21] x86/xen/MSI: Eliminate arch_msix_mask_irq() and arch_msi_mask_irq() Yijing Wang
2014-09-10 12:36 ` [Xen-devel] " David Vrabel
2014-09-11 1:22 ` Yijing Wang
2014-09-11 13:08 ` David Vrabel
2014-09-05 10:09 ` [PATCH v1 05/21] PCI/MSI: Introduce weak arch_find_msi_chip() to find MSI chip Yijing Wang
2014-09-15 14:42 ` Lucas Stach
2014-09-16 2:08 ` Yijing Wang
2014-09-05 10:09 ` [PATCH v1 06/21] PCI/MSI: Refactor struct msi_chip to make it become more common Yijing Wang
2014-09-15 14:44 ` Lucas Stach [this message]
2014-09-16 2:09 ` Yijing Wang
2014-09-05 10:09 ` [PATCH v1 07/21] x86/MSI: Use MSI chip framework to configure MSI/MSI-X irq Yijing Wang
2014-09-05 10:09 ` [PATCH v1 08/21] x86/xen/MSI: " Yijing Wang
2014-09-05 14:29 ` [Xen-devel] " David Vrabel
2014-09-09 2:06 ` Yijing Wang
2014-09-10 12:38 ` David Vrabel
2014-09-10 14:59 ` Konrad Rzeszutek Wilk
2014-09-11 1:28 ` Yijing Wang
2014-09-11 1:27 ` Yijing Wang
2014-09-05 10:09 ` [PATCH v1 09/21] Irq_remapping/MSI: " Yijing Wang
2014-09-05 10:42 ` Sergei Shtylyov
2014-09-05 11:30 ` wangyijing
2014-09-05 10:09 ` [PATCH v1 10/21] x86/MSI: Remove unused MSI weak arch functions Yijing Wang
2014-09-05 10:09 ` [PATCH v1 11/21] MIPS/Octeon/MSI: Use MSI chip framework to configure MSI/MSI-X irq Yijing Wang
2014-09-05 10:09 ` [PATCH v1 12/21] MIPS/Xlp: Remove the dead function destroy_irq() to fix build error Yijing Wang
2014-09-05 10:09 ` [PATCH v1 13/21] MIPS/Xlp/MSI: Use MSI chip framework to configure MSI/MSI-X irq Yijing Wang
2014-09-05 10:09 ` [PATCH v1 14/21] MIPS/Xlr/MSI: " Yijing Wang
2014-09-05 10:10 ` [PATCH v1 15/21] Powerpc/MSI: " Yijing Wang
2014-09-05 10:47 ` Sergei Shtylyov
2014-09-05 11:33 ` wangyijing
2014-09-05 11:41 ` Sergei Shtylyov
2014-09-16 5:28 ` Michael Ellerman
2014-09-16 5:40 ` Yijing Wang
2014-09-05 10:10 ` [PATCH v1 16/21] s390/MSI: " Yijing Wang
2014-09-16 11:35 ` Sebastian Ott
2014-09-17 1:24 ` Yijing Wang
2014-09-05 10:10 ` [PATCH v1 17/21] arm/iop13xx/MSI: " Yijing Wang
2014-09-05 10:10 ` [PATCH v1 18/21] IA64/MSI: " Yijing Wang
2014-09-05 10:10 ` [PATCH v1 19/21] Sparc/MSI: " Yijing Wang
2014-09-05 10:10 ` [PATCH v1 20/21] tile/MSI: " Yijing Wang
2014-09-05 10:10 ` [PATCH v1 21/21] PCI/MSI: Clean up unused MSI arch functions Yijing Wang
2014-09-15 14:47 ` Lucas Stach
2014-09-16 2:09 ` Yijing Wang
2014-09-23 21:09 ` [PATCH v1 00/21] Use MSI chip to configure MSI/MSI-X in all platforms Bjorn Helgaas
2014-09-24 3:52 ` Yijing Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410792261.3314.9.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).