[PATCH 00/28] remove .owner for most platform_drivers: the missing bits

[PATCH 00/28] remove .owner for most platform_drivers: the missing bits

[Wolfram Sang]

Generated with coccinelle. The big cleanup was pulled in this merge window.
This series catches the bits fallen through. The patches shall go in via the
subsystem trees. If possible for 3.19 to increase consistency I'd say, but you
decide, of course.

cocci-file used:

@match1@
declarer name module_platform_driver;
declarer name module_platform_driver_probe;
declarer name for_each_node_by_type;
identifier __driver;
@@
(
	module_platform_driver(__driver);
|
	module_platform_driver_probe(__driver, ...);
)

@fix1 depends on match1@
identifier match1.__driver;
@@
	static struct platform_driver __driver = {
		.driver = {
-			.owner = THIS_MODULE,
		}
	};

@match2@
identifier __driver;
@@
(
	platform_driver_register(&__driver)
|
	platform_driver_probe(&__driver, ...)
|
	platform_create_bundle(&__driver, ...)
)

@fix2 depends on match2@
identifier match2.__driver;
@@
	static struct platform_driver __driver = {
		.driver = {
-			.owner = THIS_MODULE,
		}
	};

Thanks again to Julia Lawall for support. And hey, we fixed a coccinelle bug on
the way :)


Wolfram Sang (28):
  ARM: mach-exynos: drop owner assignment from platform_drivers
  mips: lantiq: xway: drop owner assignment from platform_drivers
  mips: pci: drop owner assignment from platform_drivers
  char: ipmi: drop owner assignment from platform_drivers
  cpufreq: drop owner assignment from platform_drivers
  dma: drop owner assignment from platform_drivers
  gpio: drop owner assignment from platform_drivers
  gpu: drm: rockchip: drop owner assignment from platform_drivers
  iommu: drop owner assignment from platform_drivers
  net: ethernet: stmicro: stmmac: drop owner assignment from
    platform_drivers
  net: wireless: ath: ath5k: drop owner assignment from platform_drivers
  of: drop owner assignment from platform_drivers
  pci: host: drop owner assignment from platform_drivers
  phy: drop owner assignment from platform_drivers
  pinctrl: intel: drop owner assignment from platform_drivers
  rtc: drop owner assignment from platform_drivers
  scsi: drop owner assignment from platform_drivers
  thermal: drop owner assignment from platform_drivers
  thermal: int340x_thermal: drop owner assignment from platform_drivers
  tty: serial: 8250: drop owner assignment from platform_drivers
  usb: gadget: udc: bdc: drop owner assignment from platform_drivers
  watchdog: drop owner assignment from platform_drivers
  ASoC: intel: drop owner assignment from platform_drivers
  ASoC: intel: sst: drop owner assignment from platform_drivers
  ASoC: omap: drop owner assignment from platform_drivers
  ASoC: pxa: drop owner assignment from platform_drivers
  ASoC: samsung: drop owner assignment from platform_drivers
  macintosh: drop owner assignment from platform_drivers

 arch/arm/mach-exynos/pmu.c                            | 1 -
 arch/mips/lantiq/xway/vmmc.c                          | 1 -
 arch/mips/pci/pci-ar2315.c                            | 1 -
 arch/mips/pci/pci-rt2880.c                            | 1 -
 drivers/char/ipmi/ipmi_powernv.c                      | 1 -
 drivers/cpufreq/ls1x-cpufreq.c                        | 1 -
 drivers/dma/at_xdmac.c                                | 1 -
 drivers/gpio/gpio-vf610.c                             | 1 -
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c           | 1 -
 drivers/iommu/rockchip-iommu.c                        | 1 -
 drivers/macintosh/windfarm_pm112.c                    | 1 -
 drivers/macintosh/windfarm_pm72.c                     | 1 -
 drivers/macintosh/windfarm_rm31.c                     | 1 -
 drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 1 -
 drivers/net/wireless/ath/ath5k/ahb.c                  | 1 -
 drivers/of/unittest.c                                 | 1 -
 drivers/pci/host/pci-layerscape.c                     | 1 -
 drivers/phy/phy-armada375-usb2.c                      | 1 -
 drivers/phy/phy-berlin-usb.c                          | 1 -
 drivers/phy/phy-miphy28lp.c                           | 1 -
 drivers/pinctrl/intel/pinctrl-cherryview.c            | 1 -
 drivers/rtc/rtc-opal.c                                | 1 -
 drivers/scsi/atari_scsi.c                             | 1 -
 drivers/scsi/mac_scsi.c                               | 1 -
 drivers/scsi/sun3_scsi.c                              | 1 -
 drivers/thermal/int340x_thermal/int3400_thermal.c     | 1 -
 drivers/thermal/int340x_thermal/int3402_thermal.c     | 1 -
 drivers/thermal/rockchip_thermal.c                    | 1 -
 drivers/tty/serial/8250/8250_omap.c                   | 1 -
 drivers/usb/gadget/udc/bdc/bdc_core.c                 | 1 -
 drivers/watchdog/cadence_wdt.c                        | 1 -
 drivers/watchdog/meson_wdt.c                          | 1 -
 sound/soc/intel/bytcr_dpcm_rt5640.c                   | 1 -
 sound/soc/intel/cht_bsw_rt5672.c                      | 1 -
 sound/soc/intel/sst/sst_acpi.c                        | 1 -
 sound/soc/omap/omap-hdmi-audio.c                      | 1 -
 sound/soc/pxa/spitz.c                                 | 1 -
 sound/soc/samsung/arndale_rt5631.c                    | 1 -
 38 files changed, 38 deletions(-)

-- 
2.1.3

[PATCH 01/28] ARM: mach-exynos: drop owner assignment from platform_drivers

[Wolfram Sang]

This platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Generated with coccinelle. SmPL file is in the introductory msg. The big
cleanup was pulled in this merge window. This series catches the bits fallen
through. The patches shall go in via the subsystem trees.

 arch/arm/mach-exynos/pmu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos/pmu.c
index c15761ca2f18..f629d2df66b0 100644
--- a/arch/arm/mach-exynos/pmu.c
+++ b/arch/arm/mach-exynos/pmu.c
@@ -991,7 +991,6 @@ static int exynos_pmu_probe(struct platform_device *pdev)
 static struct platform_driver exynos_pmu_driver = {
 	.driver  = {
 		.name   = "exynos-pmu",
-		.owner	= THIS_MODULE,
 		.of_match_table = exynos_pmu_of_device_ids,
 	},
 	.probe = exynos_pmu_probe,
-- 
2.1.3

[PATCH 06/28] dma: drop owner assignment from platform_drivers

[Wolfram Sang]

This platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Generated with coccinelle. SmPL file is in the introductory msg. The big
cleanup was pulled in this merge window. This series catches the bits fallen
through. The patches shall go in via the subsystem trees.

 drivers/dma/at_xdmac.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index b60d77a22df6..1c4c96b7e2bf 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -1507,7 +1507,6 @@ static struct platform_driver at_xdmac_driver = {
 	.remove		= at_xdmac_remove,
 	.driver = {
 		.name		= "at_xdmac",
-		.owner		= THIS_MODULE,
 		.of_match_table	= of_match_ptr(atmel_xdmac_dt_ids),
 		.pm		= &atmel_xdmac_dev_pm_ops,
 	}
-- 
2.1.3

[PATCH 09/28] iommu: drop owner assignment from platform_drivers

[Wolfram Sang]

This platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Generated with coccinelle. SmPL file is in the introductory msg. The big
cleanup was pulled in this merge window. This series catches the bits fallen
through. The patches shall go in via the subsystem trees.

 drivers/iommu/rockchip-iommu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c
index b2023af384b9..6a8b1ec4a48a 100644
--- a/drivers/iommu/rockchip-iommu.c
+++ b/drivers/iommu/rockchip-iommu.c
@@ -1009,7 +1009,6 @@ static struct platform_driver rk_iommu_driver = {
 	.remove = rk_iommu_remove,
 	.driver = {
 		   .name = "rk_iommu",
-		   .owner = THIS_MODULE,
 		   .of_match_table = of_match_ptr(rk_iommu_dt_ids),
 	},
 };
-- 
2.1.3

[PATCH 13/28] pci: host: drop owner assignment from platform_drivers

[Wolfram Sang]

This platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Generated with coccinelle. SmPL file is in the introductory msg. The big
cleanup was pulled in this merge window. This series catches the bits fallen
through. The patches shall go in via the subsystem trees.

 drivers/pci/host/pci-layerscape.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c
index 6697b1a4d4fa..68c9e5e9b0a8 100644
--- a/drivers/pci/host/pci-layerscape.c
+++ b/drivers/pci/host/pci-layerscape.c
@@ -167,7 +167,6 @@ MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
 static struct platform_driver ls_pcie_driver = {
 	.driver = {
 		.name = "layerscape-pcie",
-		.owner = THIS_MODULE,
 		.of_match_table = ls_pcie_of_match,
 	},
 };
-- 
2.1.3

[PATCH 18/28] thermal: drop owner assignment from platform_drivers

[Wolfram Sang]

This platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Generated with coccinelle. SmPL file is in the introductory msg. The big
cleanup was pulled in this merge window. This series catches the bits fallen
through. The patches shall go in via the subsystem trees.

 drivers/thermal/rockchip_thermal.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
index 1bcddfc60e91..9c6ce548e363 100644
--- a/drivers/thermal/rockchip_thermal.c
+++ b/drivers/thermal/rockchip_thermal.c
@@ -677,7 +677,6 @@ static SIMPLE_DEV_PM_OPS(rockchip_thermal_pm_ops,
 static struct platform_driver rockchip_thermal_driver = {
 	.driver = {
 		.name = "rockchip-thermal",
-		.owner = THIS_MODULE,
 		.pm = &rockchip_thermal_pm_ops,
 		.of_match_table = of_rockchip_thermal_match,
 	},
-- 
2.1.3

[PATCH 26/28] ASoC: pxa: drop owner assignment from platform_drivers

[Wolfram Sang]

This platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Generated with coccinelle. SmPL file is in the introductory msg. The big
cleanup was pulled in this merge window. This series catches the bits fallen
through. The patches shall go in via the subsystem trees.

 sound/soc/pxa/spitz.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/pxa/spitz.c b/sound/soc/pxa/spitz.c
index d7d5fb20ea6f..a6d680acd907 100644
--- a/sound/soc/pxa/spitz.c
+++ b/sound/soc/pxa/spitz.c
@@ -352,7 +352,6 @@ static int spitz_remove(struct platform_device *pdev)
 static struct platform_driver spitz_driver = {
 	.driver		= {
 		.name	= "spitz-audio",
-		.owner	= THIS_MODULE,
 		.pm     = &snd_soc_pm_ops,
 	},
 	.probe		= spitz_probe,
-- 
2.1.3

[PATCH 27/28] ASoC: samsung: drop owner assignment from platform_drivers

[Wolfram Sang]

This platform_driver does not need to set an owner, it will be populated by the
driver core.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
Generated with coccinelle. SmPL file is in the introductory msg. The big
cleanup was pulled in this merge window. This series catches the bits fallen
through. The patches shall go in via the subsystem trees.

 sound/soc/samsung/arndale_rt5631.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/samsung/arndale_rt5631.c b/sound/soc/samsung/arndale_rt5631.c
index 1e2b61ca8db2..8bf2e2c4bafb 100644
--- a/sound/soc/samsung/arndale_rt5631.c
+++ b/sound/soc/samsung/arndale_rt5631.c
@@ -135,7 +135,6 @@ MODULE_DEVICE_TABLE(of, samsung_arndale_rt5631_of_match);
 static struct platform_driver arndale_audio_driver = {
 	.driver = {
 		.name   = "arndale-audio",
-		.owner  = THIS_MODULE,
 		.pm = &snd_soc_pm_ops,
 		.of_match_table = of_match_ptr(samsung_arndale_rt5631_of_match),
 	},
-- 
2.1.3

[PATCH 18/28] thermal: drop owner assignment from platform_drivers

[Zhang Rui]

On Sun, 2014-12-21 at 22:14 +0100, Wolfram Sang wrote:
> This platform_driver does not need to set an owner, it will be populated by the
> driver core.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

both PATCH 18/28 and 19/28 look good to me. applied.

thanks,
rui
> ---
> Generated with coccinelle. SmPL file is in the introductory msg. The big
> cleanup was pulled in this merge window. This series catches the bits fallen
> through. The patches shall go in via the subsystem trees.
> 
>  drivers/thermal/rockchip_thermal.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
> index 1bcddfc60e91..9c6ce548e363 100644
> --- a/drivers/thermal/rockchip_thermal.c
> +++ b/drivers/thermal/rockchip_thermal.c
> @@ -677,7 +677,6 @@ static SIMPLE_DEV_PM_OPS(rockchip_thermal_pm_ops,
>  static struct platform_driver rockchip_thermal_driver = {
>  	.driver = {
>  		.name = "rockchip-thermal",
> -		.owner = THIS_MODULE,
>  		.pm = &rockchip_thermal_pm_ops,
>  		.of_match_table = of_rockchip_thermal_match,
>  	},

[PATCH 26/28] ASoC: pxa: drop owner assignment from platform_drivers

[Mark Brown]

On Sun, Dec 21, 2014 at 10:14:47PM +0100, Wolfram Sang wrote:
> This platform_driver does not need to set an owner, it will be populated by the
> driver core.

Applied, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141222/e2a3ff7d/attachment.sig>

[PATCH 27/28] ASoC: samsung: drop owner assignment from platform_drivers

[Mark Brown]

On Sun, Dec 21, 2014 at 10:14:48PM +0100, Wolfram Sang wrote:
> This platform_driver does not need to set an owner, it will be populated by the
> driver core.

Applied, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141222/82645b22/attachment-0001.sig>

[PATCH 06/28] dma: drop owner assignment from platform_drivers

[Vinod Koul]

On Sun, Dec 21, 2014 at 10:14:27PM +0100, Wolfram Sang wrote:
> This platform_driver does not need to set an owner, it will be populated by the
> driver core.
> 
After susbstem name if fixed

Acked-by: Vinod Koul <vinod.koul@intel.com>

-- 
~Vinod

> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> Generated with coccinelle. SmPL file is in the introductory msg. The big
> cleanup was pulled in this merge window. This series catches the bits fallen
> through. The patches shall go in via the subsystem trees.
> 
>  drivers/dma/at_xdmac.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index b60d77a22df6..1c4c96b7e2bf 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -1507,7 +1507,6 @@ static struct platform_driver at_xdmac_driver = {
>  	.remove		= at_xdmac_remove,
>  	.driver = {
>  		.name		= "at_xdmac",
> -		.owner		= THIS_MODULE,
>  		.of_match_table	= of_match_ptr(atmel_xdmac_dt_ids),
>  		.pm		= &atmel_xdmac_dev_pm_ops,
>  	}
> -- 
> 2.1.3
> 

-- 

[PATCH 06/28] dma: drop owner assignment from platform_drivers

[Wolfram Sang]

On Mon, Dec 22, 2014 at 09:08:22PM +0530, Vinod Koul wrote:
> On Sun, Dec 21, 2014 at 10:14:27PM +0100, Wolfram Sang wrote:
> > This platform_driver does not need to set an owner, it will be populated by the
> > driver core.
> > 
> After susbstem name if fixed
> 
> Acked-by: Vinod Koul <vinod.koul@intel.com>

Since I'd prefer this to go via your tree, can you fix it or shall I
resend?

[PATCH 09/28] iommu: drop owner assignment from platform_drivers

[Joerg Roedel]

On Sun, Dec 21, 2014 at 10:14:30PM +0100, Wolfram Sang wrote:
> This platform_driver does not need to set an owner, it will be populated by the
> driver core.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> Generated with coccinelle. SmPL file is in the introductory msg. The big
> cleanup was pulled in this merge window. This series catches the bits fallen
> through. The patches shall go in via the subsystem trees.
> 
>  drivers/iommu/rockchip-iommu.c | 1 -
>  1 file changed, 1 deletion(-)

Applied to iommu/fixes, thanks Wolfram.

[PATCH 06/28] dma: drop owner assignment from platform_drivers

[Vinod Koul]

On Wed, Dec 31, 2014 at 11:23:50AM +0100, Wolfram Sang wrote:
> On Mon, Dec 22, 2014 at 09:08:22PM +0530, Vinod Koul wrote:
> > On Sun, Dec 21, 2014 at 10:14:27PM +0100, Wolfram Sang wrote:
> > > This platform_driver does not need to set an owner, it will be populated by the
> > > driver core.
> > > 
> > After susbstem name if fixed
> > 
> > Acked-by: Vinod Koul <vinod.koul@intel.com>
> 
> Since I'd prefer this to go via your tree, can you fix it or shall I
> resend?
Sorry I don't have this patch, would you mind resending

-- 
~Vinod

[PATCH 13/28] pci: host: drop owner assignment from platform_drivers

[Bjorn Helgaas]

[+cc Julia]

On Sun, Dec 21, 2014 at 10:14:34PM +0100, Wolfram Sang wrote:
> This platform_driver does not need to set an owner, it will be populated by the
> driver core.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

I already applied the equivalent patch from Julia for v3.20, thanks!
(I know this is my fault because it took me so long to apply Julia's
patch.)

> ---
> Generated with coccinelle. SmPL file is in the introductory msg. The big
> cleanup was pulled in this merge window. This series catches the bits fallen
> through. The patches shall go in via the subsystem trees.
> 
>  drivers/pci/host/pci-layerscape.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pci-layerscape.c b/drivers/pci/host/pci-layerscape.c
> index 6697b1a4d4fa..68c9e5e9b0a8 100644
> --- a/drivers/pci/host/pci-layerscape.c
> +++ b/drivers/pci/host/pci-layerscape.c
> @@ -167,7 +167,6 @@ MODULE_DEVICE_TABLE(of, ls_pcie_of_match);
>  static struct platform_driver ls_pcie_driver = {
>  	.driver = {
>  		.name = "layerscape-pcie",
> -		.owner = THIS_MODULE,
>  		.of_match_table = ls_pcie_of_match,
>  	},
>  };
> -- 
> 2.1.3
>