linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: Update video-phy node with syscon phandle for Exynos3250
@ 2015-03-19 10:56 Beata Michalska
  2015-05-21  1:57 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 6+ messages in thread
From: Beata Michalska @ 2015-03-19 10:56 UTC (permalink / raw)
  To: linux-arm-kernel

As a follow-up to recent changes to Exynos mipi video phy
driver, introducing support for PMU regmap in commit
e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression
by adding support for PMU regmap") add a syscon phandle to
video-phy node to bring back to life both MIPI DSI displays
and MIPI CSIS-2 camera sensors on Exynos3250.

Signed-off-by: Beata Michalska <b.michalska@samsung.com>
---
 arch/arm/boot/dts/exynos3250.dtsi |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
index ac6b0ae..6c89670 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -137,6 +137,7 @@
 			compatible = "samsung,s5pv210-mipi-video-phy";
 			reg = <0x10020710 8>;
 			#phy-cells = <1>;
+			syscon = <&pmu_system_controller>;
 		};
 
 		pd_cam: cam-power-domain at 10023C00 {
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] ARM: dts: Update video-phy node with syscon phandle for Exynos3250
  2015-03-19 10:56 [PATCH] ARM: dts: Update video-phy node with syscon phandle for Exynos3250 Beata Michalska
@ 2015-05-21  1:57 ` Krzysztof Kozlowski
  2015-05-21  2:04   ` Krzysztof Kozlowski
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-05-21  1:57 UTC (permalink / raw)
  To: linux-arm-kernel

2015-03-19 19:56 GMT+09:00 Beata Michalska <b.michalska@samsung.com>:
> As a follow-up to recent changes to Exynos mipi video phy
> driver, introducing support for PMU regmap in commit
> e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression
> by adding support for PMU regmap") add a syscon phandle to
> video-phy node to bring back to life both MIPI DSI displays
> and MIPI CSIS-2 camera sensors on Exynos3250.
>
> Signed-off-by: Beata Michalska <b.michalska@samsung.com>

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Tested on Gear 2 (Exynos3250) board.

I'll queue it and send later to Kukjin.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: dts: Update video-phy node with syscon phandle for Exynos3250
  2015-05-21  1:57 ` Krzysztof Kozlowski
@ 2015-05-21  2:04   ` Krzysztof Kozlowski
  2015-05-21  7:25     ` Javier Martinez Canillas
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2015-05-21  2:04 UTC (permalink / raw)
  To: linux-arm-kernel

2015-05-21 10:57 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
> 2015-03-19 19:56 GMT+09:00 Beata Michalska <b.michalska@samsung.com>:
>> As a follow-up to recent changes to Exynos mipi video phy
>> driver, introducing support for PMU regmap in commit
>> e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression
>> by adding support for PMU regmap") add a syscon phandle to
>> video-phy node to bring back to life both MIPI DSI displays
>> and MIPI CSIS-2 camera sensors on Exynos3250.
>>
>> Signed-off-by: Beata Michalska <b.michalska@samsung.com>
>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Tested on Gear 2 (Exynos3250) board.

Oh, I was too fast. It seems that "reg" property is not needed
anymore. Can you remove it?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: dts: Update video-phy node with syscon phandle for Exynos3250
  2015-05-21  2:04   ` Krzysztof Kozlowski
@ 2015-05-21  7:25     ` Javier Martinez Canillas
  2015-05-23  3:53       ` Kukjin Kim
  0 siblings, 1 reply; 6+ messages in thread
From: Javier Martinez Canillas @ 2015-05-21  7:25 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, May 21, 2015 at 4:04 AM, Krzysztof Kozlowski
<k.kozlowski@samsung.com> wrote:
> 2015-05-21 10:57 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
>> 2015-03-19 19:56 GMT+09:00 Beata Michalska <b.michalska@samsung.com>:
>>> As a follow-up to recent changes to Exynos mipi video phy
>>> driver, introducing support for PMU regmap in commit
>>> e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression
>>> by adding support for PMU regmap") add a syscon phandle to
>>> video-phy node to bring back to life both MIPI DSI displays
>>> and MIPI CSIS-2 camera sensors on Exynos3250.
>>>
>>> Signed-off-by: Beata Michalska <b.michalska@samsung.com>
>>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>> Tested on Gear 2 (Exynos3250) board.
>
> Oh, I was too fast. It seems that "reg" property is not needed
> anymore. Can you remove it?
>

After removing the reg property as Krzysztof suggested.

Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

Best regards,
Javier

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: dts: Update video-phy node with syscon phandle for Exynos3250
  2015-05-21  7:25     ` Javier Martinez Canillas
@ 2015-05-23  3:53       ` Kukjin Kim
  2015-05-26  8:50         ` Beata Michalska
  0 siblings, 1 reply; 6+ messages in thread
From: Kukjin Kim @ 2015-05-23  3:53 UTC (permalink / raw)
  To: linux-arm-kernel

On 05/21/15 16:25, Javier Martinez Canillas wrote:
> On Thu, May 21, 2015 at 4:04 AM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> 2015-05-21 10:57 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
>>> 2015-03-19 19:56 GMT+09:00 Beata Michalska <b.michalska@samsung.com>:
>>>> As a follow-up to recent changes to Exynos mipi video phy
>>>> driver, introducing support for PMU regmap in commit
>>>> e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression
>>>> by adding support for PMU regmap") add a syscon phandle to
>>>> video-phy node to bring back to life both MIPI DSI displays
>>>> and MIPI CSIS-2 camera sensors on Exynos3250.
>>>>
>>>> Signed-off-by: Beata Michalska <b.michalska@samsung.com>
>>>
>>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>>
>>> Tested on Gear 2 (Exynos3250) board.
>>
>> Oh, I was too fast. It seems that "reg" property is not needed
>> anymore. Can you remove it?
>>
> 
> After removing the reg property as Krzysztof suggested.
> 
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> 
will apply with changing as per you guys' review comment ;-)

Thanks,
Kukjin

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: dts: Update video-phy node with syscon phandle for Exynos3250
  2015-05-23  3:53       ` Kukjin Kim
@ 2015-05-26  8:50         ` Beata Michalska
  0 siblings, 0 replies; 6+ messages in thread
From: Beata Michalska @ 2015-05-26  8:50 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On 05/23/2015 05:53 AM, Kukjin Kim wrote:
> On 05/21/15 16:25, Javier Martinez Canillas wrote:
>> On Thu, May 21, 2015 at 4:04 AM, Krzysztof Kozlowski
>> <k.kozlowski@samsung.com> wrote:
>>> 2015-05-21 10:57 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
>>>> 2015-03-19 19:56 GMT+09:00 Beata Michalska <b.michalska@samsung.com>:
>>>>> As a follow-up to recent changes to Exynos mipi video phy
>>>>> driver, introducing support for PMU regmap in commit
>>>>> e4b3d38088df6f3acd40 ("phy: exynos-video-mipi: Fix regression
>>>>> by adding support for PMU regmap") add a syscon phandle to
>>>>> video-phy node to bring back to life both MIPI DSI displays
>>>>> and MIPI CSIS-2 camera sensors on Exynos3250.
>>>>>
>>>>> Signed-off-by: Beata Michalska <b.michalska@samsung.com>
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>>> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>>>
>>>> Tested on Gear 2 (Exynos3250) board.
>>>
>>> Oh, I was too fast. It seems that "reg" property is not needed
>>> anymore. Can you remove it?
>>>
>>
>> After removing the reg property as Krzysztof suggested.
>>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>>
> will apply with changing as per you guys' review comment ;-)
> 
> Thanks,
> Kukjin
> 

Apologies for not jumping in earlier, but  I've been away for a while,
with basically no e-mail access. Would You like me to resend the patch 
with the 'reg' property removed or will You handle it while applying
the change ?

Best Regards
Beata

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-05-26  8:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-19 10:56 [PATCH] ARM: dts: Update video-phy node with syscon phandle for Exynos3250 Beata Michalska
2015-05-21  1:57 ` Krzysztof Kozlowski
2015-05-21  2:04   ` Krzysztof Kozlowski
2015-05-21  7:25     ` Javier Martinez Canillas
2015-05-23  3:53       ` Kukjin Kim
2015-05-26  8:50         ` Beata Michalska

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).