From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] dmaengine: st_fdma: Add xbar support
Date: Thu, 09 Jul 2015 10:27:48 +0200 [thread overview]
Message-ID: <1436430468.20619.86.camel@tiscali.nl> (raw)
In-Reply-To: <1436371888-27863-5-git-send-email-peter.griffin@linaro.org>
On wo, 2015-07-08 at 17:11 +0100, Peter Griffin wrote:
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> +config ST_FDMA_XBAR
> + bool "ST FDMA crossbar"
> + depends on ST_FDMA
> + default y
> + help
> + Enable support for ST FDMA crossbar.
> + xbar add flexibility and increase the number of peripheral request
> + can be used by fdma xbar can multiplex until 96 peripheral requests
> + to one of 3 fdma controller
> diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile
> index f68e6d8..19f18b1 100644
> --- a/drivers/dma/Makefile
> +++ b/drivers/dma/Makefile
> +obj-$(CONFIG_ST_FDMA_XBAR) += st_fdma_xbar.o
ST_FDMA_XBAR is a bool symbol, so st_fdma_xbar.o can only be built-in.
> --- /dev/null
> +++ b/drivers/dma/st_fdma_xbar.c
> +#include <linux/module.h>
Needed?
> +void st_fdma_xbar_free(struct st_fdma_xbar_dev *device)
> +{
> + platform_device_put(device->pdev);
> + kfree(device);
> +}
Unused.
> +static const struct of_device_id st_fdma_xbar_match[] = {
> + { .compatible = "st,fdma-xbar-1.0", .data = (void *)XBAR_1_0_MAX_REQ },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, st_fdma_xbar_match);
See my remark on 3/7: MODULE_DEVICE_TABLE() will be preprocessed away.
> +static struct platform_driver st_fdma_xbar_driver = {
> + .driver = {
> + .name = "st-fdma-xbar",
> + .of_match_table = st_fdma_xbar_match,
> + },
> + .probe = st_fdma_xbar_probe,
> + .remove = st_fdma_xbar_remove,
> +};
> +module_platform_driver(st_fdma_xbar_driver);
See my remark on 3/7: builtin_platform_driver().
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("STMicroelectronics FDMA cross bar");
> +MODULE_AUTHOR("Ludovic.barre <Ludovic.barre@st.com>");
See my remark on 3/7: will be preprocessed away.
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-07-09 8:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 16:11 [PATCH 0/7] Add support for FDMA DMA controller found on STi chipsets Peter Griffin
2015-07-08 16:11 ` [PATCH 1/7] dmaengine: st_fdma: Add STMicroelectronics FDMA DT binding documentation Peter Griffin
2015-08-19 15:06 ` Vinod Koul
2015-08-25 17:08 ` Peter Griffin
2015-08-26 7:12 ` Lee Jones
2015-09-03 9:18 ` Peter Griffin
2015-07-08 16:11 ` [PATCH 2/7] dmaengine: st_fdma: Add STMicroelectronics FDMA xbar " Peter Griffin
2015-07-08 16:11 ` [PATCH 3/7] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support Peter Griffin
2015-07-09 8:17 ` Paul Bolle
2015-08-28 17:59 ` Peter Griffin
2015-08-31 7:49 ` Maxime Coquelin
2015-08-31 8:08 ` Paul Bolle
2015-08-31 8:44 ` Maxime Coquelin
2015-08-19 15:40 ` Vinod Koul
2015-09-02 17:42 ` Peter Griffin
2015-07-08 16:11 ` [PATCH 4/7] dmaengine: st_fdma: Add xbar support Peter Griffin
2015-07-09 8:27 ` Paul Bolle [this message]
2015-07-08 16:11 ` [PATCH 5/7] ARM: STi: DT: STiH407: Add FDMA driver and xbar driver dt nodes Peter Griffin
2015-08-26 7:46 ` Lee Jones
2015-09-03 14:12 ` Peter Griffin
2015-07-08 16:11 ` [PATCH 6/7] MAINTAINERS: Add FDMA driver files to STi section Peter Griffin
2015-08-26 7:33 ` Lee Jones
2015-09-02 15:14 ` Peter Griffin
2015-07-08 16:11 ` [PATCH 7/7] ARM: multi_v7_defconfig: Enable STi FDMA driver Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436430468.20619.86.camel@tiscali.nl \
--to=pebolle@tiscali.nl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).