linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: amstan@chromium.org (Alexandru M Stan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] ARM: dts: rockchip: Remove specific cts pullup from veyron
Date: Wed,  2 Sep 2015 16:27:59 -0700	[thread overview]
Message-ID: <1441236479-4941-3-git-send-email-amstan@chromium.org> (raw)
In-Reply-To: <1441236479-4941-1-git-send-email-amstan@chromium.org>

With the previous patch ("rk3288: pull up cts lines") this is redundant,
I sent that patch for the same reason this existed here, so the lines don't
wiggle randomly when disconnected.

Signed-off-by: Alexandru M Stan <amstan@chromium.org>
---
Changes in v2:
- Restrict changes only to cts pin, leave rts alone
- CC people with the firefly board
- New patch removing redundant pullup code from veyron
- cover letter

 arch/arm/boot/dts/rk3288-veyron.dtsi | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
index 2fa7a0d..2b5d2e2 100644
--- a/arch/arm/boot/dts/rk3288-veyron.dtsi
+++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
@@ -543,18 +543,6 @@
 		};
 	};
 
-	/*
-	 * On Marvell-based hardware this is a no-connect.  Make sure we enable
-	 * the pullup so that the line doesn't float.  The pullup shouldn't
-	 * hurt on Broadcom-based hardware since the other side is actively
-	 * driving this signal.  As proof: we've already got a pullup on RX.
-	 */
-	uart0 {
-		uart0_cts: uart0-cts {
-			rockchip,pins = <4 18 RK_FUNC_1 &pcfg_pull_up>;
-		};
-	};
-
 	write-protect {
 		fw_wp_ap: fw-wp-ap {
 			rockchip,pins = <7 6 RK_FUNC_GPIO &pcfg_pull_none>;
-- 
2.5.0.457.gab17608

  parent reply	other threads:[~2015-09-02 23:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-02 23:27 [PATCH v2 0/2] ARM: dts: rockchip: pull up cts lines Alexandru M Stan
2015-09-02 23:27 ` [PATCH v2 1/2] ARM: dts: rockchip: pull up cts lines on rk3288 Alexandru M Stan
2015-09-02 23:34   ` Doug Anderson
2015-09-02 23:27 ` Alexandru M Stan [this message]
2015-09-02 23:35   ` [PATCH v2 2/2] ARM: dts: rockchip: Remove specific cts pullup from veyron Doug Anderson
2015-09-03 19:03 ` [PATCH v2 0/2] ARM: dts: rockchip: pull up cts lines Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441236479-4941-3-git-send-email-amstan@chromium.org \
    --to=amstan@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).