From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/4] ARM: dts: Add emmc and sdmmc to the rk3288 device tree
Date: Wed, 13 Aug 2014 00:07:38 +0200 [thread overview]
Message-ID: <1445128.HbmmWnRJOL@phil> (raw)
In-Reply-To: <CAD=FV=Wsc-Pkvg9jumdg9i1oO+T1=jtZTfbc+qE5RDrCXaaezA@mail.gmail.com>
Am Dienstag, 12. August 2014, 14:06:11 schrieb Doug Anderson:
> Heiko,
>
> On Wed, Aug 6, 2014 at 10:09 AM, Doug Anderson <dianders@chromium.org>
wrote:
> > This adds support for the sdmmc and emmc ports on the rk3288 using the
> >
> > currently posted driver from Addy at:
> > https://patchwork.kernel.org/patch/4653631/
> >
> > Note:
> > * This is not baesd on Jaehoon's patch series removing the slot node,
> >
> > but it does use new syntax like putting the bus width at the top
> > level and using the new cap-mmc-highspeed / cap-sd-highspeed. A
> > future patch will modify this one to remove the slot node.
> >
> > Signed-off-by: Doug Anderson <dianders@chromium.org>
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > Changes in v3: None
> > Changes in v2:
> > - New patchwork link for Addy's patch
> >
> > arch/arm/boot/dts/rk3288.dtsi | 22 ++++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> > index e7cb008..dc98a5b 100644
> > --- a/arch/arm/boot/dts/rk3288.dtsi
> > +++ b/arch/arm/boot/dts/rk3288.dtsi
> > @@ -78,6 +78,28 @@
> >
> > clock-frequency = <24000000>;
> >
> > };
> >
> > + sdmmc: dwmmc at ff0c0000 {
> > + compatible = "rockchip,rk3288-dw-mshc";
> > + clocks = <&cru HCLK_SDMMC>, <&cru SCLK_SDMMC>;
> > + clock-names = "biu", "ciu";
> > + fifo-depth = <0x100>;
> > + interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> > + reg = <0xff0c0000 0x4000>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> When doing other testing I realized that I missed a:
> status = "disabled";
>
> ...from both of these two nodes. I'm happy to repost with this fix or
> I'm happy if you want to add to the patch when applying.
>
> Let me know. Thanks!
I don't really have a preference :-) . Btw. I also did plan on merging patches
1 +4 and 2+3 now that the slot-removal series has landed.
Would this be ok with you?
So if you want to repost, you could do this as two patches already :-).
Heiko
>
> > + };
> > +
> > + emmc: dwmmc at ff0f0000 {
> > + compatible = "rockchip,rk3288-dw-mshc";
> > + clocks = <&cru HCLK_EMMC>, <&cru SCLK_EMMC>;
> > + clock-names = "biu", "ciu";
> > + fifo-depth = <0x100>;
> > + interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
> > + reg = <0xff0f0000 0x4000>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + };
> > +
> >
> > i2c1: i2c at ff140000 {
> >
> > compatible = "rockchip,rk3288-i2c";
> > reg = <0xff140000 0x1000>;
> >
> > --
> > 2.0.0.526.g5318336
next prev parent reply other threads:[~2014-08-12 22:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 17:09 [PATCH v3 0/4] Add eMMC and SD card support for rk3288-evb Doug Anderson
2014-08-06 17:09 ` [PATCH v3 1/4] ARM: dts: Add emmc and sdmmc to the rk3288 device tree Doug Anderson
2014-08-12 21:06 ` Doug Anderson
2014-08-12 22:07 ` Heiko Stübner [this message]
2014-08-12 22:11 ` Sonny Rao
2014-08-12 23:24 ` Doug Anderson
2014-08-06 17:09 ` [PATCH v3 2/4] ARM: dts: Enable emmc and sdmmc on the rk3288-evb boards Doug Anderson
2014-08-06 17:09 ` [PATCH v3 3/4] ARM: dts: Take the mmc slot node out of rk3288-evb Doug Anderson
2014-08-06 17:09 ` [PATCH v3 4/4] ARM: dts: mmc slot node gone on rk3288 => no more address / size cells Doug Anderson
2014-08-07 8:24 ` [PATCH v3 0/4] Add eMMC and SD card support for rk3288-evb Jaehoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445128.HbmmWnRJOL@phil \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).