From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DB29C43387 for ; Sat, 12 Jan 2019 00:14:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E265F20851 for ; Sat, 12 Jan 2019 00:14:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DHnRfFSO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E265F20851 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=i2se.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Subject:References: In-Reply-To:Message-ID:To:From:Date:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=J5xAs/hADRDH5GCv7+BsrA5DTFCWdN4ztH/ZU9/Xohs=; b=DHnRfFSOFxloj7jYuagfPbSPbe WuWaPuOnSvfhYRTIqi9fKI4c1ufqi5FTTLoBOQIVXX7UTVWkKiTQCFoi5wKmYXneeAdsGokkhGdwz KuEAFw6ucD0hXFCprAVDqOY8xATSWw7h4Hc653o4e+fyBkQIYNpJl3ZVLPUR6k+mZL51jXiJrG9Sz rs7gs0Smc1LlQzHB0cJXsrQTZ7OEG/ixWnANqGCWXgSuu9O8zObuaxluBF6Xdkaun1acrHsuskXUY ylgQnVHaWQBC8o+veyPJ8RtSmQtk6ZXeYrpZvrD7+BAsKpXL6tvRWNYKlfj+7Aoh5dP5D0OexDXhA Q4JoP4Ow==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gi6we-0003wH-Uv; Sat, 12 Jan 2019 00:14:36 +0000 Received: from mout.kundenserver.de ([212.227.126.133]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gi6wb-0003vm-IB; Sat, 12 Jan 2019 00:14:35 +0000 Received: from oxbsltgw58.schlund.de ([212.227.220.196]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MjSHa-1h6yRY0RDO-00kzJT; Sat, 12 Jan 2019 01:14:14 +0100 Date: Sat, 12 Jan 2019 01:14:11 +0100 (CET) From: Stefan Wahren To: Phil Elwell , Eric Anholt , Greg Kroah-Hartman , Dominic Braun , Nicolas Saenz Julienne , Arnd Bergmann , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Message-ID: <1446663988.387644.1547252051945@email.ionos.de> In-Reply-To: <1547206493-105303-1-git-send-email-phil@raspberrypi.org> References: <1547206493-105303-1-git-send-email-phil@raspberrypi.org> Subject: Re: [PATCH] staging: vchiq: Fix local event signalling MIME-Version: 1.0 X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.4-Rev47 X-Originating-Client: open-xchange-appsuite X-Provags-ID: V03:K1:rcZjS4Eorbl+bMlqUoCbNR3+99SToxrAR/V03n9zD1P11ZAj2+u jQyPqzHR3lspWHD6bgPkge17I0Wr0Znd6vgMv/cAgyAcsyPzY+C8BvYetFKCVeZn2E/cOOI wLjJqjI7toM4bP47Q2LbHxY2GAP56+E4sod8q6jy3exGUqYYHemSMlLqX7wFe4MYXGlkDpy xOiQozCLUikLiyIP1XK2Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:yDzikWdrk/o=:a3J6pRNUrsprvOukEPGxhV V8BqUt2iTCfF2T1ugY7yH4OimkPbGJ4JdbD2TCp2i6ANQvRSD6v75n7A0Z995GnL38dOAOLV+ UO14ed6JaSIq/oKlEyAf4fGtvyEOvf18SR0YlCdHhCla/LgjwlkcF5bTLeNho4hPIqaaCujY0 H4I15I1zeGgof2kCKXpoK/4OC4oHjCIT5CbdeUM+7t7+6RcFSxLFAkg0glIcJ3qmrYSTdN+vc QtPzD9ucVijv4th56fGBgM/KA752mrdyVOta1NQIyYTp0t45ev/XWHr+smn1HeDGf+IjA8ht8 dMBdMpPeWxoELFhOT5xCKFQOjj0GsEP7raQNoZU37LsY2ipDPvZ5Qg7ybXneun8i0uvDpcVy4 Ke7ueQ1flrGJnwWWgD0K/s1lyyQ8d/MsXHZOdf0svcVRDBpDRJbznolr719A/2R9nsq2mLSbJ w+nu25BNcrHEEeiMhgA7Z6CJIPpWPoKDGfTiwCuDYXzOOUE/A7Nha9IOJnLyyo180n185kpvS I4JFGKug5MR4FxEvogCoIQAorjdkhwXwPU5KsqqDVKpxFZB72Gd/nxisYDYzvecclDYKHTDT5 SbFa/jVTvAKwjXRKJi/CCEbY/sRPbeNqrzdy7q72HZyEmOLFKREWR+sl31P0QMhbVWRNSyWJw FQgwD3cDNbqQuKCvJEJoYcZmhjxdnae00rFTv6+yEBztQVIRn30ZsnzN0p2xqt3IavSz+hiC5 p2eRn8x0hRFc16U50sRNzfGskJgMtpT6+t9FG/Bd6PhanIXQ9agesAKocNQ= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190111_161433_907509_C2DDD471 X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Phil Elwell hat am 11. Januar 2019 um 12:34 geschrieben: > > > Prior to the recent event reworking (see Fixes), thread synchronisation > was implemented using completions, the worker thread being woken with > a call to complete(). The replacement uses waitqueues, which are more > like condition variables in that the waiting thread is only woken if > the condition is true. > > When the VPU signals the ARM, it first sets the event's fired flag to > indicate which event is being signalled, but the places in the > ARM-side code where the worker thread is being woken - > remote_event_signal_local via request_poll - did not do so as it > wasn't previously necessary, and since the armed flag was being > cleared this lead to a deadlock. > > Fixes: 852b2876a8a8 ("staging: vchiq: rework remove_event handling") > Signed-off-by: Phil Elwell Tested-by: Stefan Wahren Thanks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel