From: fu.wei@linaro.org (fu.wei at linaro.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 03/10] clocksource/drivers/arm_arch_timer: Improve printk relevant code
Date: Thu, 30 Jun 2016 02:15:46 +0800 [thread overview]
Message-ID: <1467224153-22873-4-git-send-email-fu.wei@linaro.org> (raw)
In-Reply-To: <1467224153-22873-1-git-send-email-fu.wei@linaro.org>
From: Fu Wei <fu.wei@linaro.org>
This patch defines pr_fmt(fmt) for all pr_* functions,
then the pr_* don't need to add "arch_timer:" everytime.
Also delete some Blank Spaces in arch_timer_banner,
according to the suggestion from checkpatch.pl.
No functional change.
Signed-off-by: Fu Wei <fu.wei@linaro.org>
---
drivers/clocksource/arm_arch_timer.c | 52 +++++++++++++++++++-----------------
1 file changed, 27 insertions(+), 25 deletions(-)
diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index 966c574..9540e9d 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -29,6 +29,9 @@
#include <clocksource/arm_arch_timer.h>
+#undef pr_fmt
+#define pr_fmt(fmt) "arch_timer: " fmt
+
#define CNTTIDR 0x08
#define CNTTIDR_VIRT(n) (BIT(1) << ((n) * 4))
@@ -388,24 +391,24 @@ arch_timer_detect_rate(void __iomem *cntbase, struct device_node *np)
/* Check the timer frequency. */
if (arch_timer_rate == 0)
- pr_warn("Architected timer frequency not available\n");
+ pr_warn("frequency not available\n");
}
static void arch_timer_banner(unsigned type)
{
- pr_info("Architected %s%s%s timer(s) running at %lu.%02luMHz (%s%s%s).\n",
- type & ARCH_CP15_TIMER ? "cp15" : "",
- type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? " and " : "",
- type & ARCH_MEM_TIMER ? "mmio" : "",
- (unsigned long)arch_timer_rate / 1000000,
- (unsigned long)(arch_timer_rate / 10000) % 100,
- type & ARCH_CP15_TIMER ?
- (arch_timer_uses_ppi == VIRT_PPI) ? "virt" : "phys" :
- "",
- type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? "/" : "",
- type & ARCH_MEM_TIMER ?
- arch_timer_mem_use_virtual ? "virt" : "phys" :
- "");
+ pr_info("%s%s%s timer(s) running@%lu.%02luMHz (%s%s%s).\n",
+ type & ARCH_CP15_TIMER ? "cp15" : "",
+ type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? " and " : "",
+ type & ARCH_MEM_TIMER ? "mmio" : "",
+ (unsigned long)arch_timer_rate / 1000000,
+ (unsigned long)(arch_timer_rate / 10000) % 100,
+ type & ARCH_CP15_TIMER ?
+ (arch_timer_uses_ppi == VIRT_PPI) ? "virt" : "phys" :
+ "",
+ type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? "/" : "",
+ type & ARCH_MEM_TIMER ?
+ arch_timer_mem_use_virtual ? "virt" : "phys" :
+ "");
}
u32 arch_timer_get_rate(void)
@@ -498,7 +501,7 @@ static void __init arch_counter_register(unsigned type)
static void arch_timer_stop(struct clock_event_device *clk)
{
- pr_debug("arch_timer_teardown disable IRQ%d cpu #%d\n",
+ pr_debug("teardown, disable IRQ%d cpu #%d\n",
clk->irq, smp_processor_id());
disable_percpu_irq(arch_timer_ppi[arch_timer_uses_ppi]);
@@ -597,8 +600,7 @@ static int __init arch_timer_register(void)
}
if (err) {
- pr_err("arch_timer: can't register interrupt %d (%d)\n",
- ppi, err);
+ pr_err("can't register interrupt %d (%d)\n", ppi, err);
goto out_free;
}
@@ -650,7 +652,7 @@ static int __init arch_timer_mem_register(void __iomem *base, unsigned int irq)
ret = request_irq(irq, func, IRQF_TIMER, "arch_mem_timer", &t->evt);
if (ret) {
- pr_err("arch_timer: Failed to request mem timer irq\n");
+ pr_err("Failed to request mem timer irq\n");
kfree(t);
}
@@ -727,7 +729,7 @@ static void __init arch_timer_init(void)
}
if (!has_ppi) {
- pr_warn("arch_timer: No interrupt available, giving up\n");
+ pr_warn("No interrupt available, giving up\n");
return;
}
}
@@ -743,7 +745,7 @@ static void __init arch_timer_of_init(struct device_node *np)
int i;
if (arch_timers_present & ARCH_CP15_TIMER) {
- pr_warn("arch_timer: multiple nodes in dt, skipping\n");
+ pr_warn("multiple nodes in dt, skipping\n");
return;
}
@@ -778,7 +780,7 @@ static void __init arch_timer_mem_init(struct device_node *np)
arch_timers_present |= ARCH_MEM_TIMER;
cntctlbase = of_iomap(np, 0);
if (!cntctlbase) {
- pr_err("arch_timer: Can't find CNTCTLBase\n");
+ pr_err("Can't find CNTCTLBase\n");
return;
}
@@ -793,7 +795,7 @@ static void __init arch_timer_mem_init(struct device_node *np)
u32 cntacr;
if (of_property_read_u32(frame, "frame-number", &n)) {
- pr_err("arch_timer: Missing frame-number\n");
+ pr_err("Missing frame-number\n");
of_node_put(frame);
goto out;
}
@@ -821,7 +823,7 @@ static void __init arch_timer_mem_init(struct device_node *np)
base = arch_counter_base = of_iomap(best_frame, 0);
if (!base) {
- pr_err("arch_timer: Can't map frame's registers\n");
+ pr_err("Can't map frame's registers\n");
goto out;
}
@@ -831,7 +833,7 @@ static void __init arch_timer_mem_init(struct device_node *np)
irq = irq_of_parse_and_map(best_frame, PHYS_SPI);
if (!irq) {
- pr_err("arch_timer: Frame missing %s irq",
+ pr_err("Frame missing %s irq",
arch_timer_mem_use_virtual ? "virt" : "phys");
goto out;
}
@@ -869,7 +871,7 @@ static int __init arch_timer_acpi_init(struct acpi_table_header *table)
struct acpi_table_gtdt *gtdt;
if (arch_timers_present & ARCH_CP15_TIMER) {
- pr_warn("arch_timer: already initialized, skipping\n");
+ pr_warn("already initialized, skipping\n");
return -EINVAL;
}
--
2.5.5
next prev parent reply other threads:[~2016-06-29 18:15 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 18:15 [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer fu.wei at linaro.org
2016-06-29 18:15 ` [PATCH v6 01/10] clocksource/drivers/arm_arch_timer: Move enums and defines to header file fu.wei at linaro.org
2016-06-29 18:15 ` [PATCH v6 02/10] clocksource/drivers/arm_arch_timer: Add a new enum for spi type fu.wei at linaro.org
2016-06-29 18:15 ` fu.wei at linaro.org [this message]
2016-06-30 2:54 ` [PATCH v6 03/10] clocksource/drivers/arm_arch_timer: Improve printk relevant code Hanjun Guo
2016-07-07 16:12 ` Fu Wei
2016-06-29 18:15 ` [PATCH v6 04/10] acpi: Add some basic struct and functions in GTDT driver fu.wei at linaro.org
2016-06-29 21:24 ` Rafael J. Wysocki
2016-06-30 1:17 ` Fu Wei
2016-06-30 1:26 ` Rafael J. Wysocki
2016-06-30 1:32 ` Fu Wei
2016-06-30 4:13 ` Timur Tabi
2016-06-29 18:15 ` [PATCH v6 05/10] acpi: Add arch_timer support in GTDT table parse driver fu.wei at linaro.org
2016-06-29 18:15 ` [PATCH v6 06/10] acpi: Add GTDT driver to kernel build system fu.wei at linaro.org
2016-06-29 18:15 ` [PATCH v6 07/10] clocksource/drivers/arm_arch_timer: Simplify ACPI support code fu.wei at linaro.org
2016-06-29 18:15 ` [PATCH v6 08/10] acpi: Add memory-mapped timer support in GTDT driver fu.wei at linaro.org
2016-06-29 18:15 ` [PATCH v6 09/10] clocksource/drivers/arm_arch_timer: Add GTDT support for memory-mapped timer fu.wei at linaro.org
2016-06-29 18:15 ` [PATCH v6 10/10] acpi: Add SBSA Generic Watchdog support in GTDT driver fu.wei at linaro.org
2016-06-29 21:32 ` [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Rafael J. Wysocki
2016-06-30 1:29 ` Fu Wei
2016-06-30 1:37 ` Rafael J. Wysocki
2016-06-30 2:10 ` Hanjun Guo
2016-06-30 13:27 ` Rafael J. Wysocki
2016-06-30 13:48 ` Hanjun Guo
2016-07-01 15:23 ` Will Deacon
2016-07-01 21:04 ` Rafael J. Wysocki
2016-07-04 12:53 ` Rafael J. Wysocki
2016-07-05 14:18 ` Graeme Gregory
2016-07-06 0:00 ` Rafael J. Wysocki
2016-07-07 11:12 ` Hanjun Guo
2016-07-07 12:03 ` Rafael J. Wysocki
2016-07-07 13:40 ` Lorenzo Pieralisi
2016-07-07 13:58 ` Rafael J. Wysocki
2016-07-07 15:21 ` Fu Wei
2016-07-08 13:22 ` Lorenzo Pieralisi
2016-07-08 13:50 ` Sudeep Holla
2016-07-09 3:44 ` Hanjun Guo
2016-07-10 1:26 ` Rafael J. Wysocki
2016-07-09 3:00 ` Hanjun Guo
2016-07-01 14:00 ` Daniel Lezcano
2016-07-01 21:01 ` Rafael J. Wysocki
2016-07-04 13:43 ` Daniel Lezcano
2016-07-04 14:19 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467224153-22873-4-git-send-email-fu.wei@linaro.org \
--to=fu.wei@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).