From: tiffany.lin@mediatek.com (Tiffany Lin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver
Date: Mon, 24 Oct 2016 18:49:12 +0800 [thread overview]
Message-ID: <1477306152.2916.1.camel@mtksdaap41> (raw)
In-Reply-To: <20161024070542.65e11e37@vento.lan>
Hi Mauro,
On Mon, 2016-10-24 at 07:05 -0200, Mauro Carvalho Chehab wrote:
> Em Mon, 24 Oct 2016 11:22:08 +0800
> Tiffany Lin <tiffany.lin@mediatek.com> escreveu:
>
> > Hi Mauro,
> >
> > On Fri, 2016-10-21 at 11:01 -0200, Mauro Carvalho Chehab wrote:
> > > Em Fri, 2 Sep 2016 20:19:54 +0800
> > > Tiffany Lin <tiffany.lin@mediatek.com> escreveu:
> > >
> > > > Add v4l2 layer decoder driver for MT8173
> > > >
> > > > Signed-off-by: Tiffany Lin <tiffany.lin@mediatek.com>
> > >
> > > > +int vdec_if_init(struct mtk_vcodec_ctx *ctx, unsigned int fourcc)
> > > > +{
> > > > + int ret = 0;
> > > > +
> > > > + switch (fourcc) {
> > > > + case V4L2_PIX_FMT_H264:
> > > > + case V4L2_PIX_FMT_VP8:
> > > > + default:
> > > > + return -EINVAL;
> > > > + }
> > >
> > > Did you ever test this driver? The above code will *always* return
> > > -EINVAL, with will cause vidioc_vdec_s_fmt() to always fail!
> > >
> > > I suspect that what you wanted to do, instead, is:
> > >
> > > switch (fourcc) {
> > > case V4L2_PIX_FMT_H264:
> > > case V4L2_PIX_FMT_VP8:
> > > break;
> > > default:
> > > return -EINVAL;
> > >
> >
> > The original idea here is that vp8 and h264 are added in later patches.
> > If get this patch without later patches, it should return -EINVAL.
>
> I noticed your idea, but next time, don't add dead code like that.
> Reviewers check patch by patch at the order they're present at the
> patch series.
>
> So, don't add something broken by purpose, assuming that it would
> be fixed later.
>
Got it.
> >
> >
> > > Btw, this patch series has also several issues that were pointed by
> > > checkpatch. Please *always* run checkpatch when submitting your work.
> > >
> > > You should take a look at the Kernel documentation about how to
> > > submit patches, at:
> > > https://mchehab.fedorapeople.org/kernel_docs/process/index.html
> > >
> > > PS.: this time, I fixed the checkpatch issues for you. So, let me know
> > > if the patch below is OK, and I'll merge it at media upstream,
> > > assuming that the other patches in this series are ok.
> > >
> >
> > I did run checkpatch, but I don't know why these issues missed.
> > probably I run checkpatch for all files not for patches.
> > I will take a look at the documentation and keep this in mind for future
> > upstream.
> > Appreciated for your help.
>
> Checkpatch should be run patch by patch, as we expect that all patches
> will follow the coding style and will compile fine, without introducing
> warnings.
>
> I do compile the Kernel for every single patch I merge.
>
Got it. I will follow this.
best regards,
Tiffany
> Regards,
> Mauro
next prev parent reply other threads:[~2016-10-24 10:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 12:19 [PATCH v5 0/9] Add MT8173 Video Decoder Driver Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 1/9] VPU: mediatek: Add decode support Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 2/9] dt-bindings: Add a binding for Mediatek Video Decoder Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 Video Decoder Driver Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 4/9] vcodec: mediatek: Add Mediatek H264 Video Decoder Drive Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 5/9] vcodec: mediatek: Add Mediatek VP8 Video Decoder Driver Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 6/9] videodev2.h: add V4L2_PIX_FMT_VP9 format Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 7/9] v4l2-ioctl: add VP9 format description Tiffany Lin
2016-09-02 12:19 ` [PATCH v5 8/9] Add documentation for V4L2_PIX_FMT_VP9 Tiffany Lin
2016-09-02 12:20 ` [PATCH v5 9/9] vcodec: mediatek: Add Mediatek VP9 Video Decoder Driver Tiffany Lin
2016-10-21 13:01 ` [PATCH v5 3/9] vcodec: mediatek: Add Mediatek V4L2 " Mauro Carvalho Chehab
2016-10-21 13:08 ` Mauro Carvalho Chehab
2016-10-24 3:22 ` Tiffany Lin
2016-10-24 9:05 ` Mauro Carvalho Chehab
2016-10-24 10:49 ` Tiffany Lin [this message]
2016-09-05 9:33 ` [PATCH v5 0/9] Add MT8173 " Hans Verkuil
2016-09-05 9:50 ` Tiffany Lin
2016-09-05 9:53 ` Hans Verkuil
2016-09-05 10:09 ` Hans Verkuil
2016-09-05 10:52 ` Tiffany Lin
2016-09-05 11:26 ` Hans Verkuil
2016-09-05 11:30 ` Tiffany Lin
2016-09-05 11:32 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477306152.2916.1.camel@mtksdaap41 \
--to=tiffany.lin@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).