From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EACEC433FE for ; Mon, 10 Oct 2022 13:15:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sm12/Zu/zKoKeJMbhqlppTMmJb8rOZB2qThSaxriW5Y=; b=QJ0erzkrheS2kH nZiojh9DTHQoIF8KhbpqG+rjK4U+YuP0xEEXn26Vl7xUhiTTEkx4TSb5tNFuJbs/gVCFc8ujVAh6v jCDOwKd5ZFcdaF81fJGu1R/FdLNB6EVTXjtXqadCrMPIuME3YGO0uK+vb3gPFqZUCjyUJIudoeKZV E0UaMU8qBGovzZixAW3v3dd984p9fP73EMRFdqJntjxcFCE5rpFb9wjRnl+3uIRJ0KdKzBVu6mVqC AWp15sDGYdjonBvFZ27LA6xD3SmRbq8aXtHUgJGkZMz/nz9809hQgaLgmfQ4VAcj27Rp6enJ30yoF miTM03aye0Q0z8KeX1ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohsbr-000yrh-Sz; Mon, 10 Oct 2022 13:14:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohsbo-000yqq-Gn for linux-arm-kernel@lists.infradead.org; Mon, 10 Oct 2022 13:14:18 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 439E811FB; Mon, 10 Oct 2022 06:14:21 -0700 (PDT) Received: from [10.57.5.39] (unknown [10.57.5.39]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 210953F766; Mon, 10 Oct 2022 06:14:11 -0700 (PDT) Message-ID: <14be9c37-55af-54cf-fb08-406a2a6b8952@arm.com> Date: Mon, 10 Oct 2022 14:14:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/3] powercap: arm_scmi: Add SCMI Powercap based driver Content-Language: en-US To: Cristian Marussi Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, daniel.lezcano@linaro.org, tarek.el-sherbiny@arm.com, adrian.slatineanu@arm.com, souvik.chakravarty@arm.com, wleavitt@marvell.com, wbartczak@marvell.com, dan.carpenter@oracle.com, "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org References: <20220906142337.1697569-1-cristian.marussi@arm.com> <20220906142337.1697569-2-cristian.marussi@arm.com> From: Lukasz Luba In-Reply-To: <20220906142337.1697569-2-cristian.marussi@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221010_061416_631665_794C8971 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Cristian, On 9/6/22 15:23, Cristian Marussi wrote: > Add a powercap driver that, using the ARM SCMI Protocol to query the SCMI > platform firmware for the list of existing Powercap domains, registers all > of such discovered domains under the new 'arm-scmi' powercap control type. > > A new simple powercap zone and constraint is registered for all the SCMI > powercap zones that are found. > > Cc: Rafael J. Wysocki > Cc: linux-pm@vger.kernel.org > Signed-off-by: Cristian Marussi > --- > v1 --> v2 > - using clamp_t() to simplify normalizations > - cleanup style in block of var declarations > - refactor scale conversions code > - add MAINTAINER entry > - refactored normalizations and added dev_dbg > vOLD --> v1 > - fix _init cleaning up powerctrl zone on failure > - removed uneeded casting > - simplified normalization helpers > --- > MAINTAINERS | 1 + > drivers/powercap/Kconfig | 13 + > drivers/powercap/Makefile | 1 + > drivers/powercap/arm_scmi_powercap.c | 508 +++++++++++++++++++++++++++ > 4 files changed, 523 insertions(+) > create mode 100644 drivers/powercap/arm_scmi_powercap.c > Thanks for addressing my comments. The code LGTM Reviewed-by: Lukasz Luba Regards, Lukasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel