From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22080C19F2A for ; Thu, 11 Aug 2022 10:19:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Sq1/Kb0IHzQvt23vXQ5Gvjybqlm8kzgKxrXtHxyLeqI=; b=4zYNqYKR1/oo+4 q3h6RjgeuOE+AHPSJb/WG88p9rYngR53b2jmHhkYIO5cazmkj7r3UL3LKCgF6dYYzFeCt5gEduLGu L5uzQsuvqSPXtFapikKTtDLsHEayTYucqDa5xciSjY1qfrMIhwnPhZ6Vfz7QvAFykOyspH/I9sJrx ZSkKF290oj3cUZIetRAPBeKC369LAU8B2GeB5UYD7MaeCALyxT5ck0E8lAHH22nIFGyTFjHrd56vq mhwCbWCq3gE5kTn3/21iPAEKKOwUle5hjTI0MEIfwtTMahlOXfwbAZI0+PjcvIrsuEJrobna5IGDW G5E9pBDMurSkHAZpG2qA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oM5GM-00B8N8-CJ; Thu, 11 Aug 2022 10:18:02 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oM5Fa-00B8HZ-RV; Thu, 11 Aug 2022 10:17:16 +0000 X-UUID: df268fde98aa4e39982a81f0ce5bdfe3-20220811 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.9,REQID:e2e41046-54de-44d5-8115-465cae1025f8,OB:0,LO B:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_H am,ACTION:release,TS:0 X-CID-META: VersionHash:3d8acc9,CLOUDID:95e806fd-9e71-4a0f-ba6b-417998daea35,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: df268fde98aa4e39982a81f0ce5bdfe3-20220811 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 590580240; Thu, 11 Aug 2022 03:17:11 -0700 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Thu, 11 Aug 2022 17:56:35 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 11 Aug 2022 17:56:35 +0800 Message-ID: <14d0e1be2fbd7bbacb7553a2e2e5b9d941403c4f.camel@mediatek.com> Subject: Re: [PATCH v4 1/4] dt-bindings: mediatek: watchdog: Fix compatible fallbacks and example From: Allen-KH Cheng To: Krzysztof Kozlowski , "=?ISO-8859-1?Q?N=EDcolas?= F. R. A. Prado" CC: Matthias Brugger , Chen-Yu Tsai , Wim Van Sebroeck , "Guenter Roeck" , Rob Herring , "Krzysztof Kozlowski" , , , , , , Date: Thu, 11 Aug 2022 17:56:35 +0800 In-Reply-To: <815b03aa-ab39-ec8b-294b-68dff36e2d54@kernel.org> References: <20220721014845.19044-1-allen-kh.cheng@mediatek.com> <20220721014845.19044-2-allen-kh.cheng@mediatek.com> <5dac39d1-3b42-40e9-5693-0c127e8c689a@gmail.com> <0fadcd9f50d49ecbb329e76a9ceb6ee689648955.camel@mediatek.com> <20220808170355.c2ih3xwqxlddsal7@notapiano> <6271732eb27824c5b841760243738ceb062f4c4a.camel@mediatek.com> <815b03aa-ab39-ec8b-294b-68dff36e2d54@kernel.org> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220811_031714_927535_5A240B37 X-CRM114-Status: GOOD ( 24.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org he SoC-specific compatibles Hi Krzysztof, On Wed, 2022-08-10 at 19:50 +0300, Krzysztof Kozlowski wrote: > On 10/08/2022 15:58, Allen-KH Cheng wrote: > > I agree the advantage of patch is aesthetic. Since I also want to > > send > > another "watchdog: Convert binding to YAML" PATCH, it's better let > > all > > wdt compatibles in the binding match the contents of mtk_wdt_dt_ids > > in > > drivers/watchdog/mtk_wdt.c > > > > static const struct of_device_id mtk_wdt_dt_ids[] = { > > { .compatible = "mediatek,mt2712-wdt", .data = &mt2712_data }, > > { .compatible = "mediatek,mt6589-wdt" }, > > { .compatible = "mediatek,mt7986-wdt", .data = &mt7986_data }, > > { .compatible = "mediatek,mt8183-wdt", .data = &mt8183_data }, > > { .compatible = "mediatek,mt8186-wdt", .data = &mt8186_data }, > > { .compatible = "mediatek,mt8192-wdt", .data = &mt8192_data }, > > { .compatible = "mediatek,mt8195-wdt", .data = &mt8195_data }, > > { /* sentinel */ } > > }; > > > > We have "mediatek,mt8186-wdt" "mediatek,mt8195-wdt" and > > "mediatek,mt7986-wdt" now and they have their DT data for the reset > > control. > > > > It's weird and unuseful to add "mediatek,mt6589-wdt" as fallback. > > > > > > Please kindly let me know if I missed anything > > How the driver arranges it should not be a reason to use or not to > use > specific fallback. Although Rob acked it, but I still think you did > not > provide valid reason for the change. > > Valid reason is usually the actual hardware (so they are actually not > compatible with mt6589), not exactly how once someone did it in the > driver. > > Best regards, > Krzysztof Thank you for your detailed and clear explanation. "mediatek,mt6589-wdt" provides the mtk watchdog support and the SoC- specific compatibles is for reset controls to standard wdt. "mediatek,mt6589-wdt" is compatible with mt8186, mt8195 and mt7986 and just not support the reset controls. Based on the discussion of email thread, please drop my series. Thanks to everyone for your comments. Best regards, Allen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel