linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ley.foon.tan@intel.com (Ley Foon Tan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 2/3] PCI: altera: Rename altera_pcie_link_is_up() to altera_pcie_link_up()
Date: Wed, 15 Nov 2017 00:58:40 +0800	[thread overview]
Message-ID: <1510678720.2460.2.camel@intel.com> (raw)
In-Reply-To: <20171113224051.29024.76516.stgit@bhelgaas-glaptop.roam.corp.google.com>

On Mon, 2017-11-13 at 16:40 -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Rename altera_pcie_link_is_up() to altera_pcie_link_up() to follow
> the
> convention of other drivers.??No functional change intended.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> ?drivers/pci/host/pcie-altera.c |????8 ++++----
> ?1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-
> altera.c
> index b468b8cccf8d..5cc4f594d79a 100644
> --- a/drivers/pci/host/pcie-altera.c
> +++ b/drivers/pci/host/pcie-altera.c
> @@ -105,7 +105,7 @@ static inline u32 cra_readl(struct altera_pcie
> *pcie, const u32 reg)
> ????????return readl_relaxed(pcie->cra_base + reg);
> ?}
> 
> -static bool altera_pcie_link_is_up(struct altera_pcie *pcie)
> +static bool altera_pcie_link_up(struct altera_pcie *pcie)
> ?{
> ????????return !!((cra_readl(pcie, RP_LTSSM) & RP_LTSSM_MASK) ==
> LTSSM_L0);
> ?}
> @@ -142,7 +142,7 @@ static bool altera_pcie_valid_device(struct
> altera_pcie *pcie,
> ?{
> ????????/* If there is no link, then there is no device */
> ????????if (bus->number != pcie->root_bus_nr) {
> -???????????????if (!altera_pcie_link_is_up(pcie))
> +???????????????if (!altera_pcie_link_up(pcie))
> ????????????????????????return false;
> ????????}
> 
> @@ -412,7 +412,7 @@ static void altera_wait_link_retrain(struct
> altera_pcie *pcie)
> ????????/* Wait for link is up */
> ????????start_jiffies = jiffies;
> ????????for (;;) {
> -???????????????if (altera_pcie_link_is_up(pcie))
> +???????????????if (altera_pcie_link_up(pcie))
> ????????????????????????break;
> 
> ????????????????if (time_after(jiffies, start_jiffies +
> LINK_UP_TIMEOUT)) {
> @@ -427,7 +427,7 @@ static void altera_pcie_retrain(struct
> altera_pcie *pcie)
> ?{
> ????????u16 linkcap, linkstat, linkctl;
> 
> -???????if (!altera_pcie_link_is_up(pcie))
> +???????if (!altera_pcie_link_up(pcie))
> ????????????????return;
> 
> ????????/*
> 
Acked-by: Ley Foon Tan <ley.foon.tan@intel.com>

  reply	other threads:[~2017-11-14 16:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 22:40 [PATCH v1 0/3] PCI: Rename host functions for consistency Bjorn Helgaas
2017-11-13 22:40 ` [PATCH v1 1/3] PCI: xgene: Rename xgene_pcie_probe_bridge() to xgene_pcie_probe() Bjorn Helgaas
2017-11-13 22:40 ` [PATCH v1 2/3] PCI: altera: Rename altera_pcie_link_is_up() to altera_pcie_link_up() Bjorn Helgaas
2017-11-14 16:58   ` Ley Foon Tan [this message]
2017-11-13 22:40 ` [PATCH v1 3/3] PCI: xilinx: Rename xilinx_pcie_link_is_up() to xilinx_pcie_link_up() Bjorn Helgaas
2017-11-14  7:17   ` Michal Simek
2017-11-14 17:21 ` [PATCH v1 0/3] PCI: Rename host functions for consistency Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1510678720.2460.2.camel@intel.com \
    --to=ley.foon.tan@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).