From: Florian Fainelli <f.fainelli@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Stefan Wahren <stefan.wahren@i2se.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Arnd Bergmann <arnd@arndb.de>, Phil Elwell <phil@raspberrypi.com>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH RFC 0/2] gpiolib: of: Introduce hook for missing gpio-ranges
Date: Wed, 16 Mar 2022 19:02:59 -0700 [thread overview]
Message-ID: <15171d7e-f065-88b8-b3b3-dbeed75c5e6e@gmail.com> (raw)
In-Reply-To: <CACRpkdYuxsYw99CZZK_GXp3V-mPiuL50CxgsE-=oRMApZf_bxA@mail.gmail.com>
On 3/16/2022 6:15 PM, Linus Walleij wrote:
> On Wed, Mar 9, 2022 at 8:44 PM Stefan Wahren <stefan.wahren@i2se.com> wrote:
>
>> This patch series tries to provide backward compatibility for DTB which
>> lacks the gpio-ranges property.
>>
>> The commit ("pinctrl: msm: fix gpio-hog related boot issues") by Christian
>> Lamparter already contains a fallback in case the gpio-ranges property
>> is missing. But this approach doesn't work on BCM2835 with a gpio-hog
>> defined for the SoC GPIOs.
>>
>> Based Christian's on explanation i conclude that the fallback must happen
>> during the gpiochip_add() call and not afterwards. So the approach is to
>> call an optional hook, which can be implemented in the platform driver.
>>
>> This series has been tested on Raspberry Pi 3 B Plus.
>>
>> Stefan Wahren (2):
>> gpiolib: of: Introduce hook for missing gpio-ranges
>> pinctrl: bcm2835: implement hook for missing gpio-ranges
>
> Looks good to me, is this something I should apply to the pinctrl
> tree or should I wait for a non-RFC version?
I would be inclined to slap a couple of different Fixes tag to each
commit because breaking older DTBs should IMHO be considered a
regression. So for the first patch I would add:
Fixes: 2ab73c6d8323 ("gpio: Support GPIO controllers without pin-ranges")
and for the second patch:
Fixes: 266423e60ea1 ("pinctrl: bcm2835: Change init order for gpio hogs")
WDYT?
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-17 2:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 19:43 [PATCH RFC 0/2] gpiolib: of: Introduce hook for missing gpio-ranges Stefan Wahren
2022-03-09 19:43 ` [PATCH RFC 1/2] " Stefan Wahren
2022-03-15 15:17 ` Bartosz Golaszewski
2022-03-09 19:43 ` [PATCH RFC 2/2] pinctrl: bcm2835: implement " Stefan Wahren
2022-03-10 3:24 ` [PATCH RFC 0/2] gpiolib: of: Introduce " Florian Fainelli
2022-03-17 1:15 ` Linus Walleij
2022-03-17 2:02 ` Florian Fainelli [this message]
2022-03-17 11:48 ` Stefan Wahren
2022-03-17 17:17 ` Florian Fainelli
2022-03-17 19:23 ` Stefan Wahren
2022-03-21 18:21 ` Florian Fainelli
2022-03-24 19:00 ` Linus Walleij
2022-03-24 19:23 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15171d7e-f065-88b8-b3b3-dbeed75c5e6e@gmail.com \
--to=f.fainelli@gmail.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=nsaenz@kernel.org \
--cc=phil@raspberrypi.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).