From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78986C433F5 for ; Thu, 17 Mar 2022 02:04:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qELfwwTCdPWnzWCjw/px6FJjfuYImhjuTwxUdJXBoRI=; b=S0HfTfCqZP7k+4 6FD9gkKj19KSJH1pDDEi+xS5ruD2mETwOCqcLeMLBkpikZ8pnFueOhNchVfFMFQoDS3Iz9y044Vhf 5Cdj4PbgODneTd3nq1WV8N2T/ZtXwa8uD2/YyWqmcgXhTy1VM0Hj5NLBpm0N5FFyzJFLFODDwkT/G 0JNsor/qqAW24jrvKvld2/Gmb3G65SMFj6w5CKn6aGfC1G9vPf2PSpknSve1UCoxrXeXAA10iG14g W+w8qFC02DwBCI8f5nO0+rt7F+nQ0BX4dFr60TIWxzHZj/euDU20fIAvfR6UFBn9xFlRi4HP2W+Ur ibD0wlh/zg73/zSRRIAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUfTn-00EhQK-JE; Thu, 17 Mar 2022 02:03:07 +0000 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUfTj-00EhPN-Nq for linux-arm-kernel@lists.infradead.org; Thu, 17 Mar 2022 02:03:05 +0000 Received: by mail-pf1-x42b.google.com with SMTP id s8so5582603pfk.12 for ; Wed, 16 Mar 2022 19:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Yn17ArgJ45+q/zN05im3qM5HHITBQzbTOtWfatGsFgQ=; b=Pfmrcfx7Z2QcclhynqzZBeA1v5cttdeZ65uHsVVBnBVOSDu0nJxikncKoGBjLWMDFL AzRQ/pGttsipE6sgRfUskzUJfJq855l61yjmf77MB4yBXYWCvoGCJ8Ak9RneaanjVfon DsrNpeWiisM7eDRLX4dqoV1slwLGIK+DI8sVjW4I+CI2c7kKVIq2xbX3xsV8AFjBzRHo ZUnANkkps5KBFZREhhqKDw5WyBhdzhyMUVO82SX0LmQIWYmIaNBtOSzWYZzr8Dyccs1s +u9M9AwGvy4MQUyZFRAGZPfAgcP/bkSD8bg29plJ28w5HSddBUY2emqoCN+tl4h1hKHs 5hBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Yn17ArgJ45+q/zN05im3qM5HHITBQzbTOtWfatGsFgQ=; b=SU5HOsTz4GcVxXWhf1ezRCKD94yh9S1ItqAfLTap2AFFmJvVrm2mN2wPO5uQy1nVaQ WtMIb/KIIRiLoDPtEz8/UD6iOORRzHgWW2E2nunajsVzKbKeuujEzSGqIjPbBlXfszSt tNYw+alCz6FCha7jp20gMXtjjOUgM5wnOyLFhCUxNUza37lLWB1VOCtF+rTkNro57eJS ifIDVgdPvl3qxu9TRH/fE/uCJCWV/B0vN/2kj7+fPE0dBH8GyVPFwcoRUjOHAQSYZgqH 7dfUwd+cr5Og2/Fx/yklppwnseWZuJfxSH+0RL3AUcrL65Znk8G/GNFDOjAR1aUzh9Cg yDCw== X-Gm-Message-State: AOAM533eThtdGZKB26gEtD5+7KPfdZ8hCwqdqDlnwAqqzE+IK0WfxePc 4CPS0A+7KvYFHxFgJVu0QzU= X-Google-Smtp-Source: ABdhPJwvbwY4NQjwBTAAoo0U5aLNpS7MwRcJ527sddRBDL23IrJFHQdDwV9+xjTwhLt0Oh8cDSdzsQ== X-Received: by 2002:a63:384e:0:b0:374:ae28:71fc with SMTP id h14-20020a63384e000000b00374ae2871fcmr1857720pgn.159.1647482582073; Wed, 16 Mar 2022 19:03:02 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id j11-20020a63230b000000b00372a08b584asm3650905pgj.47.2022.03.16.19.03.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Mar 2022 19:03:01 -0700 (PDT) Message-ID: <15171d7e-f065-88b8-b3b3-dbeed75c5e6e@gmail.com> Date: Wed, 16 Mar 2022 19:02:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH RFC 0/2] gpiolib: of: Introduce hook for missing gpio-ranges Content-Language: en-US To: Linus Walleij , Stefan Wahren Cc: Bartosz Golaszewski , Nicolas Saenz Julienne , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Arnd Bergmann , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org References: <1646855026-9132-1-git-send-email-stefan.wahren@i2se.com> From: Florian Fainelli In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220316_190303_828775_569DECC3 X-CRM114-Status: GOOD ( 15.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/16/2022 6:15 PM, Linus Walleij wrote: > On Wed, Mar 9, 2022 at 8:44 PM Stefan Wahren wrote: > >> This patch series tries to provide backward compatibility for DTB which >> lacks the gpio-ranges property. >> >> The commit ("pinctrl: msm: fix gpio-hog related boot issues") by Christian >> Lamparter already contains a fallback in case the gpio-ranges property >> is missing. But this approach doesn't work on BCM2835 with a gpio-hog >> defined for the SoC GPIOs. >> >> Based Christian's on explanation i conclude that the fallback must happen >> during the gpiochip_add() call and not afterwards. So the approach is to >> call an optional hook, which can be implemented in the platform driver. >> >> This series has been tested on Raspberry Pi 3 B Plus. >> >> Stefan Wahren (2): >> gpiolib: of: Introduce hook for missing gpio-ranges >> pinctrl: bcm2835: implement hook for missing gpio-ranges > > Looks good to me, is this something I should apply to the pinctrl > tree or should I wait for a non-RFC version? I would be inclined to slap a couple of different Fixes tag to each commit because breaking older DTBs should IMHO be considered a regression. So for the first patch I would add: Fixes: 2ab73c6d8323 ("gpio: Support GPIO controllers without pin-ranges") and for the second patch: Fixes: 266423e60ea1 ("pinctrl: bcm2835: Change init order for gpio hogs") WDYT? -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel