From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EFDEC169C4 for ; Tue, 29 Jan 2019 18:48:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 323C92087F for ; Tue, 29 Jan 2019 18:48:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ReFMaOWT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 323C92087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XJh/axGwl0KvSOwWHogGxSlLwV4ig+6Gn31b2JBH7Tc=; b=ReFMaOWTpJF5rU RLV47JeyCbnmYbZO50V2QitvEVHhv79ugjuZh+1Ct9cNqjCn8hfUpy0E68PRiSQwoF45Io1eD9Aqj 6Le0J8qRwsMap8PMa6Mr2zZn6PNs3baeZC1TdFgjEX7r0JlWJS7aoAy5FqT3jqfjvG8CDgSKVbGZf oiF5j+cUc5/Akr55xexqNp7JoW1Iw59dWBxpBSMt5RsuqgtOuk7HIqEBDiWS9lX1JfAAVYoDhi0lY nGB5zX6ki2k5m9sPkTs6MURUUzl3fqltDx5VJvg6kICzQAl/ZHj/iumXJS4T4b8hosjl08npLsV9M yRygUl7wPuorBODmv1Vw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1goYRO-00058Q-Bo; Tue, 29 Jan 2019 18:48:58 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1goYRK-00057i-Py for linux-arm-kernel@lists.infradead.org; Tue, 29 Jan 2019 18:48:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C97D9A78; Tue, 29 Jan 2019 10:48:52 -0800 (PST) Received: from [10.1.196.105] (eglon.cambridge.arm.com [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 120C33F557; Tue, 29 Jan 2019 10:48:49 -0800 (PST) Subject: Re: [PATCH v7 10/25] ACPI / APEI: Tell firmware the estatus queue consumed the records To: Tyler Baicar References: <20181203180613.228133-1-james.morse@arm.com> <20181203180613.228133-11-james.morse@arm.com> <20181211183634.GO27375@zn.tnic> <56cfa16b-ece4-76e0-3799-58201f8a4ff1@arm.com> <20190111120322.GD4729@zn.tnic> <0939c14d-de58-f21d-57a6-89bdce3bcb44@arm.com> From: James Morse Message-ID: <1530de77-3f9d-f214-216e-42eec7d757b7@arm.com> Date: Tue, 29 Jan 2019 18:48:40 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190129_104854_867118_A47DA37C X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rafael Wysocki , Tony Luck , Fan Wu , linux-mm@kvack.org, Marc Zyngier , Catalin Marinas , Xie XiuQi , Will Deacon , Christoffer Dall , Dongjiu Geng , Linux ACPI , Borislav Petkov , Naoya Horiguchi , kvmarm@lists.cs.columbia.edu, arm-mail-list , Len Brown Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tyler, On 11/01/2019 20:53, Tyler Baicar wrote: > On Fri, Jan 11, 2019 at 1:09 PM James Morse wrote: >> We can return on ENOENT out earlier, as nothing needs doing in that case. Its >> what the GHES_TO_CLEAR spaghetti is for, we can probably move the ack thing into >> ghes_clear_estatus(), that way that thing means 'I'm done with this memory'. >> >> Something like: >> ------------------------- >> rc = ghes_read_estatus(); >> if (rc == -ENOENT) >> return 0; > > We still should be returning at least the -ENOENT from ghes_read_estatus(). > That is being used by the SEA handling to determine if an SEA was properly > reported/handled by the host kernel in the KVM SEA case. Sorry, my terrible example code. You'll be glad to know I would have caught this when testing it! Thanks, James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel