From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86298C43387 for ; Mon, 17 Dec 2018 06:41:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5247120675 for ; Mon, 17 Dec 2018 06:41:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d75DXMWJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Q7XHocSn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5247120675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uZieVgaA2iBPckvBMfWkfEqORtEPnT6lZP+ZmD8I4r8=; b=d75DXMWJSTj+Fi j2kr/9Iq+z6Bq+dPhnFHDZ51RaaYuwXOjHdUx1T5j3CO5ZUj4lKxa/YnTbbZlkP/ZRGAAe0zzsJkW lsn5QvwEHUJpNAC+7w9YHRElJfO6aS73zpwed8Bi5vRfFv2GZSCOZBx3lLHH9ilPsgNe3aPP5W37L +9Efe4fqOtMLB+VR5bhrZ5EylrApwgmkl2a9IwEYeg4cl40dQHa/h+uw6uTHS1qcmgkmSLF+PNN0h FwLpcN4Go4y3DLjrINPVSg3T25Q9XjrI5/B40ByoOsGFLgbXiuB5sVUd2udYVBem6jLz7qHD+Km59 tE4MZTs9o7Jw5iJ56fNQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gYmbB-0002XO-UC; Mon, 17 Dec 2018 06:41:53 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gYmb6-0002UI-Kb for linux-arm-kernel@lists.infradead.org; Mon, 17 Dec 2018 06:41:52 +0000 Received: from localhost.localdomain (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4591820675; Mon, 17 Dec 2018 06:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545028898; bh=0xtxfZtFdIUmaXPj2hBVcHLm0ZupOdVKMg42UdHhv0E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q7XHocSnVx+0Xra04NV3H5XEkQO0w0dGwg7DW9YnHqDAH4+2kQHIXXJA7bu6l906K b1UDTnU8XZA1ooJNxsoSwFFGgdJ7cHSOTEQyh1fr1UdIN+MeZoUJroxWFFwpVwzGRq 8eRdPK6OVNR90BgNON2fBzS5NoU59EpJxQo2NEr4= From: Masami Hiramatsu To: Catalin Marinas , Will Deacon Subject: [PATCH 2/3] arm64: kprobes: Remove unneeded RODATA check Date: Mon, 17 Dec 2018 15:41:15 +0900 Message-Id: <154502887509.30629.17754148993239954461.stgit@devbox> X-Mailer: git-send-email 2.13.6 In-Reply-To: <154502881646.30629.9938335052821665530.stgit@devbox> References: <154502881646.30629.9938335052821665530.stgit@devbox> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181216_224148_685877_22E500B1 X-CRM114-Status: GOOD ( 10.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pratyush Anand , linux-kernel , Masami Hiramatsu , linux-arm-kernel@lists.infradead.org, "David A . Long" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Remove unneeded RODATA check from arch_prepare_kprobe(). Since check_kprobe_address_safe() already ensured that the probe address is in kernel text, we don't need to check whether the address in RODATA or not. That must be always false. Signed-off-by: Masami Hiramatsu --- arch/arm64/kernel/probes/kprobes.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c index b2d4b7428ebc..1dae500d0a81 100644 --- a/arch/arm64/kernel/probes/kprobes.c +++ b/arch/arm64/kernel/probes/kprobes.c @@ -91,8 +91,6 @@ static void __kprobes arch_simulate_insn(struct kprobe *p, struct pt_regs *regs) int __kprobes arch_prepare_kprobe(struct kprobe *p) { unsigned long probe_addr = (unsigned long)p->addr; - extern char __start_rodata[]; - extern char __end_rodata[]; if (probe_addr & 0x3) return -EINVAL; @@ -106,10 +104,6 @@ int __kprobes arch_prepare_kprobe(struct kprobe *p) if (search_exception_tables(probe_addr)) return -EINVAL; - if (probe_addr >= (unsigned long) __start_rodata && - probe_addr <= (unsigned long) __end_rodata) - return -EINVAL; - /* decode instruction */ switch (arm_kprobe_decode_insn(p->addr, &p->ainsn)) { case INSN_REJECTED: /* insn not supported */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel