From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A00AC43387 for ; Thu, 20 Dec 2018 01:23:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4166320866 for ; Thu, 20 Dec 2018 01:23:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ec67SdGj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=impinj.com header.i=@impinj.com header.b="HFipYgHB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4166320866 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=impinj.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+oJ5AARWtDWw+g4XdN9yz/f49ETltI0Cg2KYOUBLURY=; b=ec67SdGj95/xu6 mKunXtBZafsuM3aI/Eafj9aCNAtu1th6A8lQQ2n8+BxrZEz0QNxo0eviVIINRCslq/B11kI3ewtqX Rle55qKQV8iAvSmJWl+UPiS37knf5ac3cyKNlQAfhuRDKVKIrT9kyx53kmsm5IaXJNByWHDB+iKJG 23SH0tQLJ457m86kG2LmqwmiBkM12ZL2JuBqSzTdbh6I8LMBJCpabeF2BatEpVqJSywo7vzOiYw82 Do54tSUJ1MBRGxwKAVE+9bnrt/MLbSyiZW/YZZthhFsSut/Dr+RzisnsgeCeoE9GcWLha9RFkuLH6 f3SHyaHpFAH8zCn6zfPg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZn3O-0003E3-8v; Thu, 20 Dec 2018 01:23:10 +0000 Received: from mail-eopbgr690137.outbound.protection.outlook.com ([40.107.69.137] helo=NAM04-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gZn3K-0003CF-0b for linux-arm-kernel@lists.infradead.org; Thu, 20 Dec 2018 01:23:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=impinj.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oHJSiqcMQxG/aqO+mzGu/H2GdnflQqdrCw9YYUtmhFw=; b=HFipYgHBluDrDRp0aDk2trS0bQSz6lhgcqz9kqyiMj5bwfTPkm1Oq/NSsVpFVzlai/AovvA+56Maah5te+YUGriQnXS9DAJrk789AiW6s19ooarDO3LxNCp0MhLCED6c6CAITb1iQhawGlCg0Ax1w+uvL/9IgvNwbtCsFRgE3r8= Received: from MWHPR0601MB3708.namprd06.prod.outlook.com (10.167.236.38) by MWHPR0601MB3721.namprd06.prod.outlook.com (10.167.236.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1446.19; Thu, 20 Dec 2018 01:22:52 +0000 Received: from MWHPR0601MB3708.namprd06.prod.outlook.com ([fe80::24d2:3a2c:20ed:7cfd]) by MWHPR0601MB3708.namprd06.prod.outlook.com ([fe80::24d2:3a2c:20ed:7cfd%6]) with mapi id 15.20.1446.020; Thu, 20 Dec 2018 01:22:51 +0000 From: Trent Piepho To: "l.stach@pengutronix.de" , "andrew.smirnov@gmail.com" Subject: Re: [PATCH v3 3/3] PCI: imx6: Add support for i.MX8MQ Thread-Topic: [PATCH v3 3/3] PCI: imx6: Add support for i.MX8MQ Thread-Index: AQHUloc4EyB/jPStRUyDq4OW+MrDYaWE/zeAgAHO4ICAAAnkgA== Date: Thu, 20 Dec 2018 01:22:51 +0000 Message-ID: <1545268969.22930.77.camel@impinj.com> References: <20181218040702.29231-1-andrew.smirnov@gmail.com> <20181218040702.29231-4-andrew.smirnov@gmail.com> <20181218151533.GA2922@bogus> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=tpiepho@impinj.com; x-originating-ip: [216.207.205.253] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; MWHPR0601MB3721; 6:IYShTawWmHrB0u6/5093DDHFrYHjNeuvJV1KQ6hSrZShUSfBw2AfnjXcy+7INdkW+LvSn/U7a548lZZt/lz+fsgpn+1hpEF7J3OvW12wzUfdX9nTb4H2A3b0dffCB6YjBgk23/7Z827U+CZlmOODuXkzA6gLpBhjI2uNsBL9wJeWpOlTdJIvdzhBIoSs4f33jn2NeBPuW1POA3wfM6zzO8F5ejTKgrWqbaXiPIW+FFxRqe7t6IY5h64/x7EoBf2f7Sjv12Mo7n+ul8WBp/QWeNdUvHqvtkGZdM8vvikWBtGiHB9x0WsUF3eTM8wV6C23ayv/xIgWpvGEM7xhiAliYEDf/6UxWdPlkomdpkhl4dYmSideFAD94WRoVWnuEj6nLd4nXAPkkaiBXf9A2SbeLC0IgzrN+MwwAemWhL5JZa5zg+U4jsl9h4IDhclSwgVceabxyzEfnsDLJ8xL0zDnHA==; 5:te1VzsV52awN4VjZPU+NV84ebSmzOfCJ69ECoBCJXnoqUtbwvtb8CmJzgDaRfOXqw1wclIwMhTUXCNqNu5kPE1p7OlL34FswrNveGtx9YgypUqSf6ftJXTLi5Hh/5ing3rc2PWHXzxf9BV3o2zGIpo0uuoB4fHxYYknJywRo1RQ=; 7:4LPfKnnFIXiazYHdkZKb7bMaj7P36T0MChIc3xcaY1QBdDJTLe2ufQApENyNGD/DlHLJkGwaIB0VHHY1Z0FQhd8mWRnAddHLR0BdepZ0UUSUPCJD4aBsWmeF+rtXtty6/bWXQxPYlA7jvkeLUbq4rw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: cde7f651-5ee1-42f2-8b04-08d66619a8ef x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:MWHPR0601MB3721; x-ms-traffictypediagnostic: MWHPR0601MB3721: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(999002)(5005026)(6040522)(2401047)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231475)(944501520)(52105112)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:MWHPR0601MB3721; BCL:0; PCL:0; RULEID:; SRVR:MWHPR0601MB3721; x-forefront-prvs: 0892FA9A88 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(136003)(39840400004)(376002)(366004)(396003)(189003)(199004)(26005)(53936002)(6116002)(25786009)(3846002)(68736007)(5660300001)(102836004)(81166006)(86362001)(186003)(478600001)(2906002)(229853002)(8676002)(6506007)(6512007)(7736002)(305945005)(71200400001)(71190400001)(486006)(6486002)(99286004)(39060400002)(14454004)(106356001)(4001150100001)(76176011)(7416002)(4326008)(2501003)(256004)(93886005)(14444005)(36756003)(103116003)(97736004)(476003)(2616005)(11346002)(6436002)(110136005)(54906003)(105586002)(8936002)(81156014)(66066001)(6246003)(316002)(446003); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR0601MB3721; H:MWHPR0601MB3708.namprd06.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: impinj.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: e8r0V9OZWI4h9NMo1OWJauPX+WIfQecOnIegA9bTCsuLLIdm3w1KSDUvBQMA4o9wRjspaB4i18j9K6jlS708+FsZwG+G9KDpZyWQTvdoqeGoQJaeTCV5+RO3g4y76Nw8Yxz7Hzx1aia2t1giYRRwFWmG5gb0Iik7yIhMXhjQ1BXjjEs+fTEM621ey6SvlI474E5KBgsISyTBKu0S9aaIh4WapCQjmgNb0bPwVddwGcX22bdGlZIgUVGK/DYthHgzYyii/Sb794/jfqOIXS4k+fGxCxrKPfggfyCojiXWu9Kldu5HzfavmRCzGNqgU+iS spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: MIME-Version: 1.0 X-OriginatorOrg: impinj.com X-MS-Exchange-CrossTenant-Network-Message-Id: cde7f651-5ee1-42f2-8b04-08d66619a8ef X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2018 01:22:51.2949 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 6de70f0f-7357-4529-a415-d8cbb7e93e5e X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0601MB3721 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181219_172306_058267_55959491 X-CRM114-Status: GOOD ( 18.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "aisheng.dong@nxp.com" , "devicetree@vger.kernel.org" , "lorenzo.pieralisi@arm.com" , "hongxing.zhu@nxp.com" , "robh@kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , "linux-imx@nxp.com" , "fabio.estevam@nxp.com" , "leonard.crestez@nxp.com" , "cphealy@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2018-12-19 at 16:47 -0800, Andrey Smirnov wrote: > > > > This series initially added explicit offsets but I suggested a single > > > "controller-id" because: > > > * There are multiple bit and byte offsets > > > * Other imx8 SOCs also have 2x pcie with other bit/byte offsets > > > > > > Hiding this behind a compatible string and single "controller-id" seem > > > preferable to elaborating register maps in dt bindings. It also makes > > > upgrades simpler: if features are added which use other bits there is no > > > need to describe them in DT and deal with compatibility headaches. > > > > You already have an id for the controllers: the address. Use that if > > you don't want to put the register offsets in DT. > > > > Lucas, are you on board with this? Does address here mean the address from the controller's reg property? How do you map that address to the controller's index? A giant table of every soc so the soc type plus controller register address pair than can be looked up in the driver? I.e., on iMX8MQ the controller at 0x33800000 is controller 0 and so on for every possible SoC address combination? Not really a fan of that. The situation here is that some registers for these controllers are interleaved, right? I.e., there's one register somewhere where bit 0 means enable controller 0 and bit 1 means enable controller 1 and so on. Isn't cell-index already the standard device tree property for this kind of setup? I know cell-index was historically also (ab)used in an attempt to provide a fixed kernel device enumeration order, something now handled better by chosen node aliases. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel