From: Lucas Stach <l.stach@pengutronix.de>
To: Jun Li <jun.li@nxp.com>, Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
"patchwork-lst@pengutronix.de" <patchwork-lst@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH 1/2] arm64: dts: fsl: imx8mq: add USB nodes
Date: Wed, 16 Jan 2019 10:22:19 +0100 [thread overview]
Message-ID: <1547630539.4339.22.camel@pengutronix.de> (raw)
In-Reply-To: <VI1PR04MB455880021886BD03D29126DA89820@VI1PR04MB4558.eurprd04.prod.outlook.com>
Hi Jun,
Am Mittwoch, den 16.01.2019, 04:30 +0000 schrieb Jun Li:
> Hi Lucas,
> > -----Original Message-----
> > > > From: Lucas Stach <l.stach@pengutronix.de>
> > Sent: 2019年1月15日 19:03
> > > > To: Shawn Guo <shawnguo@kernel.org>
> > > > Cc: Fabio Estevam <fabio.estevam@nxp.com>; dl-linux-imx <linux-imx@nxp.com>;
> > > > linux-arm-kernel@lists.infradead.org; kernel@pengutronix.de;
> > patchwork-lst@pengutronix.de
> > Subject: [PATCH 1/2] arm64: dts: fsl: imx8mq: add USB nodes
> >
> > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 66 +++++++++++++++++++++++
> > 1 file changed, 66 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 5bd1f106ed84..d25ab50d6b88 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -470,6 +470,72 @@
> > > > };
> > > > };
> >
> > > > > > + usb_dwc3_0: usb@38100000 {
> > > > + compatible = "fsl,imx8mq-dwc3", "snps,dwc3";
> > > > + reg = <0x38100000 0x10000>;
> > > > + clocks = <&clk IMX8MQ_CLK_USB_BUS>,
> > > > + <&clk IMX8MQ_CLK_USB_CORE_REF>,
> > > > + <&clk IMX8MQ_CLK_USB1_CTRL_ROOT>;
> > > > + clock-names = "bus_early", "ref", "suspend";
> > > > + assigned-clocks = <&clk IMX8MQ_CLK_USB_BUS>,
> > > > + <&clk IMX8MQ_CLK_USB_CORE_REF>;
> > > > + assigned-clock-parents = <&clk IMX8MQ_SYS2_PLL_500M>,
> > > > + <&clk IMX8MQ_SYS1_PLL_100M>;
> > > > + assigned-clock-rates = <500000000>, <100000000>;
> > > > + interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> > > > + phys = <&usb3_phy0>, <&usb3_phy0>;
> > > > + phy-names = "usb2-phy", "usb3-phy";
> > > > + power-domains = <&pgc_otg1>;
> > + snps,power-down-scale = <2>;
>
> This property does not exist on upstream, need firstly introduce it for dwc3 driver
> before add it in dts, I can do that if you are not going to take care of it.
I'm going to remove this from this patch in the next revision. I'm not
sure when I'm going to get around to look more at USB, so please CC me
if/when you are introducing this to the DWC3 driver.
Regards,
Lucas
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-16 9:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 11:03 [PATCH 1/2] arm64: dts: fsl: imx8mq: add USB nodes Lucas Stach
2019-01-15 11:03 ` [PATCH 2/2] arm64: dts: fsl: imx8mq-evk: enable USB nodes for USB3 host Lucas Stach
2019-01-16 10:18 ` Shawn Guo
2019-01-16 4:30 ` [PATCH 1/2] arm64: dts: fsl: imx8mq: add USB nodes Jun Li
2019-01-16 9:22 ` Lucas Stach [this message]
2019-01-16 10:16 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547630539.4339.22.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=fabio.estevam@nxp.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=patchwork-lst@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).