From: Min Guo <min.guo@mediatek.com>
To: Bin Liu <b-liu@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Yonglong Wu <yonglong.wu@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
chunfeng.yun@mediatek.com, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/4] usb: musb: Add support for MediaTek musb controller
Date: Thu, 17 Jan 2019 11:34:16 +0800 [thread overview]
Message-ID: <1547696056.4433.233.camel@mhfsdcap03> (raw)
In-Reply-To: <20190116135914.GF18026@uda0271908>
On Wed, 2019-01-16 at 07:59 -0600, Bin Liu wrote:
> On Wed, Jan 16, 2019 at 05:39:02PM +0800, Min Guo wrote:
> > Hi Bin,
> >
> > On Tue, 2019-01-15 at 14:38 -0600, Bin Liu wrote:
> > > Hi Min,
> > >
> > > very close, thanks.
> > > Below I tried to explain a further cleanup in musb_clearb/w() and
> > > musb_get/set_toggle() implementation. Please let me know if it is not
> > > clear.
> > >
> > > Basically, we don't need musb_default_clearb/w(), just assign the
> > > musb_io function pointers to musb_readb/w().
> > >
> > > Then the mtk platform musb_clearb/w() calls musb_readb/w() and
> > > musb_writeb/w() to handle W1C.
> >
> > Sorry to bother you again, I encounter a problem when prepare the patch.
>
> no problem at all.
Thanks.
> > The define of musb_clearb/w and musb_readb/w are difference as follow,
> > and cannot be directly assigned:
> > u8/u16 (*readb/w)(const void __iomem *addr, unsigned offset)
> > void (*clearb/w)(void __iomem *addr, unsigned int offset))
> >
> > if modify clearb/w as:
> > u8/u16 (*clearb/w)(const void __iomem *addr, unsigned int offset))
> > then musb_clear needs writeb/w the const addr.
> > Can I delete const in (*readb/w)?
>
> yes, please create a separate patch for it, and for readl() as well,
> and stating it is for implementing clearing W1C registers.
Okay.
> Regards,
> -Bin.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-17 3:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 1:43 [PATCH v2 0/4] Add MediaTek MUSB Controller Driver min.guo
2019-01-15 1:43 ` [PATCH v2 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller min.guo
2019-01-15 1:43 ` [PATCH v2 2/4] arm: dts: mt2701: Add usb2 device nodes min.guo
2019-01-15 1:43 ` [PATCH v2 3/4] usb: musb: Extract set toggle as a separate interface min.guo
2019-01-15 15:19 ` Matthias Brugger
2019-01-15 20:40 ` Bin Liu
2019-01-16 2:43 ` Min Guo
2019-01-16 2:44 ` Min Guo
2019-01-15 1:43 ` [PATCH v2 4/4] usb: musb: Add support for MediaTek musb controller min.guo
2019-01-15 20:38 ` Bin Liu
2019-01-16 2:43 ` Min Guo
2019-01-16 9:39 ` Min Guo
2019-01-16 13:59 ` Bin Liu
2019-01-17 3:34 ` Min Guo [this message]
2019-01-15 5:18 ` [SPAM][PATCH v2 0/4] Add MediaTek MUSB Controller Driver Ryder Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547696056.4433.233.camel@mhfsdcap03 \
--to=min.guo@mediatek.com \
--cc=b-liu@ti.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=yonglong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).