From: Lucas Stach <l.stach@pengutronix.de> To: Trent Piepho <tpiepho@impinj.com>, "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>, Rob Herring <robh+dt@kernel.org> Cc: Richard Zhu <hongxing.zhu@nxp.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Shawn Guo <shawnguo@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/3] dt-bindings: imx6q-pcie: Add description of imx7d pcie phy Date: Tue, 05 Feb 2019 10:43:56 +0100 Message-ID: <1549359836.2544.33.camel@pengutronix.de> (raw) In-Reply-To: <20190205001721.18639-2-tpiepho@impinj.com> Am Dienstag, den 05.02.2019, 00:17 +0000 schrieb Trent Piepho: > There is a separate PHY device with its own registers on imx7d. It's > currently unused, but a PCIe erratum on imx7d will require it for the > workaround. > > Signed-off-by: Trent Piepho <tpiepho@impinj.com> I'm generally fine with this, but really want to see an Ack from the DT folks (CC'ed) on this. Acked-by: Lucas Stach <l.stach@pengutronix.de> Regards, Lucas > --- > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > index d514c1f2365f..f4933c8951bc 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > @@ -53,6 +53,7 @@ Additional required properties for imx7d-pcie: > > - "pciephy" > > - "apps" > > - "turnoff" > +- fsl,imx7d-pcie-phy: A phandle to an fsl,imx7d-pcie-phy node. > > Example: > > @@ -79,3 +80,13 @@ Example: > > clocks = <&clks 144>, <&clks 206>, <&clks 189>; > > clock-names = "pcie", "pcie_bus", "pcie_phy"; > > }; > + > +* Freescale i.MX7d PCIe PHY > + > +This is the PHY associated with the IMX7d PCIe controller. It's used by the > +PCI-e controller via the fsl,imx7d-pcie-phy phandle. > + > +Required properties: > +- compatible: > > + - "fsl,imx7d-pcie-phy" > +- reg: base address and length of the PCIe PHY controller _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply index Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-05 0:17 [PATCH v2 0/3] Workaround for IMX7d PCI-e PLL lock failure Trent Piepho 2019-02-05 0:17 ` [PATCH v2 1/3] dt-bindings: imx6q-pcie: Add description of imx7d pcie phy Trent Piepho 2019-02-05 9:43 ` Lucas Stach [this message] 2019-02-05 0:17 ` [PATCH v2 2/3] ARM: dts: imx7d: Add node for PCIe PHY Trent Piepho 2019-02-05 9:47 ` Lucas Stach 2019-02-05 0:17 ` [PATCH v2 3/3] PCI: imx: Add workaround for e10728, IMX7d PCIe PLL failure Trent Piepho 2019-02-05 9:48 ` Lucas Stach 2019-02-07 12:31 ` Lorenzo Pieralisi 2019-02-07 18:15 ` Trent Piepho 2019-02-08 10:18 ` Lorenzo Pieralisi 2019-02-08 18:19 ` Trent Piepho 2019-02-11 12:18 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1549359836.2544.33.camel@pengutronix.de \ --to=l.stach@pengutronix.de \ --cc=devicetree@vger.kernel.org \ --cc=hongxing.zhu@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=robh+dt@kernel.org \ --cc=shawnguo@kernel.org \ --cc=tpiepho@impinj.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-Kernel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \ linux-arm-kernel@lists.infradead.org public-inbox-index linux-arm-kernel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git