From: Philipp Zabel <p.zabel@pengutronix.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
xuwei5@hisilicon.com, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, guodong.xu@linaro.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: reset: Add HI3670 reset controller binding
Date: Thu, 07 Feb 2019 11:41:34 +0100 [thread overview]
Message-ID: <1549536094.4557.8.camel@pengutronix.de> (raw)
In-Reply-To: <20190201153841.21903-2-manivannan.sadhasivam@linaro.org>
Hi Manivannan,
On Fri, 2019-02-01 at 21:08 +0530, Manivannan Sadhasivam wrote:
> HI3670 SoC is architecturally same as the HI3660 SoC. Hence, the same
> driver is reused for HI3670 SoC and the binding is documented here.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> .../devicetree/bindings/reset/hisilicon,hi3660-reset.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt
> index 2bf3344b2a02..5d60ec541331 100644
> --- a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt
> @@ -5,11 +5,12 @@ Please also refer to reset.txt in this directory for common reset
> controller binding usage.
>
> The reset controller registers are part of the system-ctl block on
> -hi3660 SoC.
> +hi3660 and hi3670 SoCs.
>
> Required properties:
> -- compatible: should be
> +- compatible: should be one of the following:
> "hisilicon,hi3660-reset"
> + "hisilicon,hi3670-reset"
If the HI3670 reset controller is compatible to the HI3660 reset
controller, this could be:
- compatible: should be one of the following:
"hisilicon,hi3660-reset" for HI3660
"hisilicon,hi3670-reset", "hisilicon,hi3660-reset" for HI3670
That way there would be no need to change the driver and it would be
documented that the two reset controllers are compatible.
regards
Philipp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-07 10:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 15:38 [PATCH 0/3] Add Reset controller support for HI3670 SoC Manivannan Sadhasivam
2019-02-01 15:38 ` [PATCH 1/3] dt-bindings: reset: Add HI3670 reset controller binding Manivannan Sadhasivam
2019-02-07 10:41 ` Philipp Zabel [this message]
2019-02-07 11:17 ` Manivannan Sadhasivam
2019-02-01 15:38 ` [PATCH 2/3] arm64: dts: hisilicon: hi3670: Add reset controller support Manivannan Sadhasivam
2019-02-07 10:41 ` Philipp Zabel
2019-02-01 15:38 ` [PATCH 3/3] reset: hisilicon: Add HiSilicon HI3670 reset support Manivannan Sadhasivam
2019-02-07 10:41 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549536094.4557.8.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=guodong.xu@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).