From: Lucas Stach <l.stach@pengutronix.de>
To: Carlo Caione <ccaione@baylibre.com>,
robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] arm64: dts: imx8mq: Add on-chip OTP controller node
Date: Mon, 11 Feb 2019 13:03:17 +0100 [thread overview]
Message-ID: <1549886597.2546.5.camel@pengutronix.de> (raw)
In-Reply-To: <20190202150638.13672-2-ccaione@baylibre.com>
Am Samstag, den 02.02.2019, 15:06 +0000 schrieb Carlo Caione:
> Add the node for the OTP controller. The IP is the same as on the imx7d.
This is not true. According to the reference manual, the OCOTP
controller on i.MX8MQ uses the non-banked write mode, same as i.MX6.
Thus it is incompatible to the i.MX7 OCOTP.
Also the number of fuses is different, so we really need some driver
support for the imx8mq compatible and can't declare the controller
compatible to some older instance.
Regards,
Lucas
> Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index c34cabe9b356..f37f17b71151 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -241,6 +241,14 @@
> reg = <0x30340000 0x10000>;
> };
>
> + ocotp: ocotp-ctrl@30350000 {
> + compatible = "fsl,imx8mq-ocotp", "fsl,imx7d-ocotp", "syscon";
> + reg = <0x30350000 0x10000>;
> + clocks = <&clk IMX8MQ_CLK_OCOTP_ROOT>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + };
> +
> anatop: syscon@30360000 {
> compatible = "fsl,imx8mq-anatop", "syscon";
> reg = <0x30360000 0x10000>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-11 12:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 15:06 [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller Carlo Caione
2019-02-02 15:06 ` [PATCH v2 1/2] arm64: dts: imx8mq: Add on-chip OTP controller node Carlo Caione
2019-02-04 10:26 ` Lucas Stach
2019-02-11 12:03 ` Lucas Stach [this message]
2019-02-11 13:01 ` Lucas Stach
2019-02-02 15:06 ` [PATCH v2 2/2] dt-bindings: imx-ocotp: Add i.MX8MQ compatible Carlo Caione
2019-02-25 15:11 ` [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller Abel Vesa
2019-02-26 8:57 ` Carlo Caione
2019-02-26 9:01 ` Abel Vesa
2019-02-26 9:03 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549886597.2546.5.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=ccaione@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).