linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Carlo Caione <ccaione@baylibre.com>,
	robh+dt@kernel.org,  mark.rutland@arm.com, shawnguo@kernel.org,
	s.hauer@pengutronix.de,  kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com,
	 devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] arm64: dts: imx8mq: Add on-chip OTP controller node
Date: Mon, 11 Feb 2019 14:01:10 +0100	[thread overview]
Message-ID: <1549890070.2546.7.camel@pengutronix.de> (raw)
In-Reply-To: <1549886597.2546.5.camel@pengutronix.de>

Am Montag, den 11.02.2019, 13:03 +0100 schrieb Lucas Stach:
> Am Samstag, den 02.02.2019, 15:06 +0000 schrieb Carlo Caione:
> > Add the node for the OTP controller. The IP is the same as on the
> > imx7d.
> 
> This is not true. According to the reference manual, the OCOTP
> controller on i.MX8MQ uses the non-banked write mode, same as i.MX6.
> Thus it is incompatible to the i.MX7 OCOTP.

Actually I need to correct myself here. While the programming sequence
description is the same as on i.MX6, the register layout looks like the
i.MX7 one, so likely someone copy and pasted the wrong documentation
snippet. This means the controller is in fact compatible to the i.MX7
write sequence.

> Also the number of fuses is different, so we really need some driver
> support for the imx8mq compatible and can't declare the controller
> compatible to some older instance.

But then I think this is still true. The changed number of fuses means
we need some driver support and should not claim backward compatibility
with the i.MX7 controller.

regards,
Lucas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-02-11 13:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-02 15:06 [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller Carlo Caione
2019-02-02 15:06 ` [PATCH v2 1/2] arm64: dts: imx8mq: Add on-chip OTP controller node Carlo Caione
2019-02-04 10:26   ` Lucas Stach
2019-02-11 12:03   ` Lucas Stach
2019-02-11 13:01     ` Lucas Stach [this message]
2019-02-02 15:06 ` [PATCH v2 2/2] dt-bindings: imx-ocotp: Add i.MX8MQ compatible Carlo Caione
2019-02-25 15:11 ` [PATCH v2 0/2] Add and document the i.MX8MQ OTP controller Abel Vesa
2019-02-26  8:57   ` Carlo Caione
2019-02-26  9:01     ` Abel Vesa
2019-02-26  9:03     ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1549890070.2546.7.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=ccaione@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).