From: Seiya Wang <seiya.wang@mediatek.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
srv_heupstream <srv_heupstream@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Erin Lo <erin.lo@mediatek.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org, linux-serial@vger.kernel.org,
mars.cheng@mediatek.com,
Matthias Brugger <matthias.bgg@gmail.com>,
yingjoe.chen@mediatek.com, Thomas Gleixner <tglx@linutronix.de>,
eddie.huang@mediatek.com, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/6] irqchip/mtk-sysirq: support 4 interrupt parameters for sysirq
Date: Mon, 11 Feb 2019 21:01:20 +0800 [thread overview]
Message-ID: <1549890080.22817.24.camel@mtksdccf07> (raw)
In-Reply-To: <868symu2ss.wl-marc.zyngier@arm.com>
On Mon, 2019-02-11 at 08:50 +0000, Marc Zyngier wrote:
> On Mon, 11 Feb 2019 06:35:29 +0000,
> Seiya Wang <seiya.wang@mediatek.com> wrote:
> >
> > On Thu, 2019-02-07 at 15:52 +0000, Marc Zyngier wrote:
> > > On 07/02/2019 15:47, Marc Zyngier wrote:
> > > > On 07/02/2019 15:20, Matthias Brugger wrote:
> > > >>
> > > >>
> > > >> On 24/01/2019 09:07, Erin Lo wrote:
> > > >>> From: Seiya Wang <seiya.wang@mediatek.com>
> > > >>>
> > > >>> To support partitioned PPIs, 4 interrupt parameters should be valid
> > > >>> for sysirq.
> > > >>>
> > > >>> Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
> > > >>> Signed-off-by: Erin Lo <erin.lo@mediatek.com>
> > > >>> ---
> > > >>> drivers/irqchip/irq-mtk-sysirq.c | 4 ++--
> > > >>> 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >>>
> > > >>> diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c
> > > >>> index 90aaf19..282736a 100644
> > > >>> --- a/drivers/irqchip/irq-mtk-sysirq.c
> > > >>> +++ b/drivers/irqchip/irq-mtk-sysirq.c
> > > >>> @@ -81,7 +81,7 @@ static int mtk_sysirq_domain_translate(struct irq_domain *d,
> > > >>> unsigned int *type)
> > > >>> {
> > > >>> if (is_of_node(fwspec->fwnode)) {
> > > >>> - if (fwspec->param_count != 3)
> > > >>> + if (fwspec->param_count != 3 && fwspec->param_count != 4)
> > > >>
> > > >> Where is this 4th parameter used?
> > > >
> > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt#n14
> > > Sorry, I fired Send way too early.
> > >
> > > What I wanted to add is that it is not clear to me why this change would
> > > be required here, as this driver only supports SPIs. It could be fixed
> > > by just relaxing the binding itself.
> > >
> > > Thanks,
> > >
> > > M.
> >
> > Do you mean that we should change #interrupt-cells back to 3 for sysirq
> > and remove the 4th parameters of every spi interrupts in mt8183.dtsi
> > (i.e. 3 parameters for spi, 4 for ppi) such that we can discard this
> > patch?
>
> It is more subtle than that:
>
> - PPIs must have the affinity parameter in their int-spec (since you
> need that for the PMU)
>
> - SPIs that are directly routed to the GIC must also have the affinity
> parameter (although set to zero).
>
> - SPIs that are routed via the sysirq block (or any other) can use the
> 3 parameter variant, as they are not resolved in the context of the
> GIC, but in that of the sysirq.
>
> But in short, yes. You should be able to drop this patch altogether.
>
> > If yes, we may need some time to verify the change before resending the
> > patch.
>
> That's absolutely fine.
>
> Thanks,
>
> M.
>
Thanks for the detailed descriptions.
We will remove this patch and resend again.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-11 13:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 8:07 [PATCH v6 0/6] Add basic and clock support for Mediatek MT8183 SoC Erin Lo
2019-01-24 8:07 ` [PATCH v6 1/6] irqchip/mtk-sysirq: support 4 interrupt parameters for sysirq Erin Lo
2019-02-07 15:20 ` Matthias Brugger
2019-02-07 15:47 ` Marc Zyngier
2019-02-07 15:52 ` Marc Zyngier
2019-02-11 6:35 ` Seiya Wang
2019-02-11 8:50 ` Marc Zyngier
2019-02-11 13:01 ` Seiya Wang [this message]
2019-01-24 8:07 ` [PATCH v6 2/6] dt-bindings: arm: Add bindings for Mediatek MT8183 SoC Platform Erin Lo
2019-02-07 15:15 ` Matthias Brugger
2019-01-24 8:07 ` [PATCH v6 3/6] dt-bindings: mtk-sysirq: Add compatible for Mediatek MT8183 Erin Lo
2019-01-24 8:07 ` [PATCH v6 4/6] dt-bindings: serial: " Erin Lo
2019-01-24 8:07 ` [PATCH v6 5/6] dt-bindings: pinctrl: mt8183: add binding document Erin Lo
2019-01-30 16:17 ` Rob Herring
2019-01-31 8:30 ` Zhiyong Tao
2019-02-07 15:28 ` Matthias Brugger
2019-02-14 3:29 ` Erin Lo
2019-01-24 8:07 ` [PATCH v6 6/6] arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile Erin Lo
2019-01-30 16:22 ` Rob Herring
2019-01-31 2:34 ` Erin Lo
2019-01-31 21:10 ` Rob Herring
[not found] ` <1548992018.11367.8.camel@mtksdaap41>
2019-02-01 5:11 ` Erin Lo
2019-02-07 15:08 ` Matthias Brugger
2019-02-09 7:37 ` Erin Lo
2019-02-07 15:30 ` Matthias Brugger
2019-02-13 9:03 ` Erin Lo
2019-02-13 14:54 ` Matthias Brugger
2019-02-14 5:27 ` Erin Lo
2019-02-14 9:01 ` Matthias Brugger
2019-02-14 10:14 ` Erin Lo
2019-02-14 10:15 ` Erin Lo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549890080.22817.24.camel@mtksdccf07 \
--to=seiya.wang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=erin.lo@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mars.cheng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srv_heupstream@mediatek.com \
--cc=tglx@linutronix.de \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).