From: Henry Chen <henryc.chen@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
James Liao <jamesjj.liao@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Kees Cook <keescook@chromium.org>,
Weiyi Lu <weiyi.lu@mediatek.com>,
linux-pm@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
Viresh Kumar <vireshk@kernel.org>,
linux-kernel@vger.kernel.org, Fan Chen <fan.chen@mediatek.com>,
devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC RESEND PATCH 1/7] dt-bindings: soc: Add DVFSRC driver bindings
Date: Mon, 18 Feb 2019 12:55:32 +0800 [thread overview]
Message-ID: <1550465732.32365.6.camel@mtksdaap41> (raw)
In-Reply-To: <20190111160918.GA20480@bogus>
Hi Rob,
Sorry for late reply. I missed this mail before.
On Fri, 2019-01-11 at 10:09 -0600, Rob Herring wrote:
> On Wed, Jan 02, 2019 at 10:09:52PM +0800, Henry Chen wrote:
> > Document the binding for enabling DVFSRC on MediaTek SoC.
> >
> > Signed-off-by: Henry Chen <henryc.chen@mediatek.com>
> > ---
> > .../devicetree/bindings/soc/mediatek/dvfsrc.txt | 26 ++++++++++++++++++++++
> > include/dt-bindings/soc/mtk,dvfsrc.h | 18 +++++++++++++++
> > 2 files changed, 44 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt
> > create mode 100644 include/dt-bindings/soc/mtk,dvfsrc.h
> >
> > diff --git a/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt b/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt
> > new file mode 100644
> > index 0000000..402c885
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/mediatek/dvfsrc.txt
> > @@ -0,0 +1,26 @@
> > +MediaTek DVFSRC Driver
>
> Bindings are for h/w blocks, not drivers.
ok.
>
> > +The Dynamic Voltage and Frequency Scaling Resource Collector (DVFSRC) is a
> > +HW module which is used to collect all the requests from both software and
> > +hardware and turn into the decision of minimum operating voltage and minimum
> > +DRAM frequency to fulfill those requests.
>
> Seems like the OPP table should be a child of this instead of where you
> currently have it?
Do you means the opp table that I put on scpsys likes below?
I think this opp table is used for mapping the performance state of
power domain, so I put it on scpsys device tree document.
dvfsrc_opp_table: opp-table {
compatible = "operating-points-v2-level";
dvfsrc_vol_min: opp1 {
opp,level = <MT8183_DVFSRC_LEVEL_1>;
};
dvfsrc_freq_medium: opp2 {
opp,level = <MT8183_DVFSRC_LEVEL_2>;
};
dvfsrc_freq_max: opp3 {
opp,level = <MT8183_DVFSRC_LEVEL_3>;
};
dvfsrc_vol_max: opp4 {
opp,level = <MT8183_DVFSRC_LEVEL_4>;
};
};
>
> > +
> > +Required Properties:
> > +- compatible: Should be one of the following
> > + - "mediatek,mt8183-dvfsrc": For MT8183 SoC
> > +- reg: Address range of the DVFSRC unit
> > +- dram_type: Refer to <include/dt-bindings/soc/mtk,dvfsrc.h> for the
> > + different dram type support.
>
> This information should come from the DDR controller or memory nodes
> probably. And we already have some properties related to DDR type.
Sorry, I don't know that before, could you give some hint or example for
that?
>
> > +- clock-names: Must include the following entries:
> > + "dvfsrc": DVFSRC module clock
> > +- clocks: Must contain an entry for each entry in clock-names.
> > +
> > +Example:
> > +
> > + dvfsrc_top@10012000 {
>
> Drop the '_top'. (Don't use '_' in node and property names)..
ok
>
> > + compatible = "mediatek,mt8183-dvfsrc";
> > + reg = <0 0x10012000 0 0x1000>;
> > + clocks = <&infracfg CLK_INFRA_DVFSRC>;
> > + clock-names = "dvfsrc";
> > + dram_type = <MT8183_DVFSRC_OPP_LP4>;
> > + };
> > diff --git a/include/dt-bindings/soc/mtk,dvfsrc.h b/include/dt-bindings/soc/mtk,dvfsrc.h
> > new file mode 100644
> > index 0000000..60b3497
> > --- /dev/null
> > +++ b/include/dt-bindings/soc/mtk,dvfsrc.h
> > @@ -0,0 +1,18 @@
> > +/* SPDX-License-Identifier: GPL-2.0
> > + *
> > + * Copyright (c) 2018 MediaTek Inc.
> > + */
> > +
> > +#ifndef _DT_BINDINGS_POWER_MTK_DVFSRC_H
> > +#define _DT_BINDINGS_POWER_MTK_DVFSRC_H
> > +
> > +#define MT8183_DVFSRC_OPP_LP4 0
> > +#define MT8183_DVFSRC_OPP_LP4X 1
> > +#define MT8183_DVFSRC_OPP_LP3 2
> > +
> > +#define MT8183_DVFSRC_LEVEL_1 1
> > +#define MT8183_DVFSRC_LEVEL_2 2
> > +#define MT8183_DVFSRC_LEVEL_3 3
> > +#define MT8183_DVFSRC_LEVEL_4 4
> > +
> > +#endif /* _DT_BINDINGS_POWER_MTK_DVFSRC_H */
> > --
> > 1.9.1
> >
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-18 4:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 14:09 [RFC RESEND PATCH 0/7] Add driver for dvfsrc and add support for active state of scpsys on mt8183 Henry Chen
2019-01-02 14:09 ` [RFC RESEND PATCH 1/7] dt-bindings: soc: Add DVFSRC driver bindings Henry Chen
2019-01-11 16:09 ` Rob Herring
2019-02-18 4:55 ` Henry Chen [this message]
2019-03-20 8:52 ` Nicolas Boichat
2019-01-02 14:09 ` [RFC RESEND PATCH 2/7] dt-bindings: soc: Add opp table on scpsys bindings Henry Chen
2019-01-03 18:45 ` Rob Herring
2019-01-07 11:04 ` Henry Chen
2019-01-02 14:09 ` [RFC RESEND PATCH 3/7] soc: mediatek: add support for the performance state Henry Chen
2019-01-03 22:57 ` Stephen Boyd
2019-01-07 11:06 ` Henry Chen
2019-01-02 14:09 ` [RFC RESEND PATCH 4/7] arm64: dts: mt8183: add performance state support of scpsys Henry Chen
2019-01-03 4:47 ` Viresh Kumar
2019-01-03 14:16 ` Henry Chen
2019-01-02 14:09 ` [RFC RESEND PATCH 5/7] soc: mediatek: add header for mediatek SIP interface Henry Chen
2019-01-02 14:09 ` [RFC RESEND PATCH 6/7] soc: mediatek: add MT8183 dvfsrc support Henry Chen
2019-01-03 23:08 ` Stephen Boyd
2019-01-07 11:09 ` Henry Chen
2019-01-10 0:38 ` Stephen Boyd
2019-01-02 14:09 ` [RFC RESEND PATCH 7/7] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2019-01-03 4:48 ` [RFC RESEND PATCH 0/7] Add driver for dvfsrc and add support for active state of scpsys on mt8183 Viresh Kumar
2019-01-03 14:31 ` Henry Chen
2019-01-03 22:53 ` Stephen Boyd
2019-01-07 11:04 ` Henry Chen
2019-01-07 16:34 ` Georgi Djakov
2019-01-09 3:08 ` Henry Chen
2019-01-10 9:39 ` Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550465732.32365.6.camel@mtksdaap41 \
--to=henryc.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=fan.chen@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vireshk@kernel.org \
--cc=weiyi.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).