From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5199C43381 for ; Thu, 28 Feb 2019 21:24:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FEEE20854 for ; Thu, 28 Feb 2019 21:24:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XrfsK2Fd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=impinj.com header.i=@impinj.com header.b="dJs2j+iw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FEEE20854 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=impinj.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dFx6x9frvJ5wMivxyBOxFa0+Myy5Fhhv2MlcEJ/+n9Q=; b=XrfsK2FdjE0oUG ZJ9nXUWG4ysh05xDwhsYrF9E0gEz59jg0zr76WqFJBnGd51+EtYxf+UrCRoTIpwzzZsbyQ2a2xvpL LUh8wV+HHhpQercbbkMUjKC6UzeoxtTeVjRbvYKctReV37ghiAwP087pUrf2308admVG7bpdDiKMY 73tQR9fhv1VzWwvXyrQpCz6sPUBs9b+2YU6oVNNCa4TaO2UFjqlNLZRHJHJy469Ofw64CL6VSfzao KBVgZFbVxUkG6fNakFvCBPCx4CE4L2NfhRgbZCUiZyUq22zF4Qcrp6ZcRjKBSJ3tA/PkpFDqIclqy iUNESvkA/GblId1AnAgg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzT9z-0006WN-Dh; Thu, 28 Feb 2019 21:24:07 +0000 Received: from mail-eopbgr780123.outbound.protection.outlook.com ([40.107.78.123] helo=NAM03-BY2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzT9v-0006Vm-Ch for linux-arm-kernel@lists.infradead.org; Thu, 28 Feb 2019 21:24:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=impinj.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=atD21Yvso/DT9MIkHVV51VF+49Mqr6vKMvGE/q0f/bQ=; b=dJs2j+iwrwIans/t9N34SWxIb5dqOxlazJnt3q35J/pfoGlF9WZH3roj/T02/xb1lXS3P4bjm9OZfKfiWa1VaxeI4rUcvDIBEIrj9VTmPAjwFC7/3rQ7QHSmhjT8Eabc3PEFrGBfyqB3AMjeZpUPT8bliQGI56YSb+nwtj8Wuk8= Received: from MWHPR0601MB3708.namprd06.prod.outlook.com (10.167.236.38) by MWHPR0601MB3643.namprd06.prod.outlook.com (10.167.236.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1665.16; Thu, 28 Feb 2019 21:23:58 +0000 Received: from MWHPR0601MB3708.namprd06.prod.outlook.com ([fe80::91d4:ba4b:1424:9452]) by MWHPR0601MB3708.namprd06.prod.outlook.com ([fe80::91d4:ba4b:1424:9452%2]) with mapi id 15.20.1665.015; Thu, 28 Feb 2019 21:23:58 +0000 From: Trent Piepho To: "l.stach@pengutronix.de" , "andrew.smirnov@gmail.com" , "lorenzo.pieralisi@arm.com" Subject: Re: [PATCH 2/2] PCI: imx6: Add code to request/control "pcie_aux" clock for i.MX8MQ Thread-Topic: [PATCH 2/2] PCI: imx6: Add code to request/control "pcie_aux" clock for i.MX8MQ Thread-Index: AQHUwnV/PjSm2eLZQ0exQOr536QHtaXb59YAgBnrEoA= Date: Thu, 28 Feb 2019 21:23:58 +0000 Message-ID: <1551389037.6059.3.camel@impinj.com> References: <20190212015108.16952-1-andrew.smirnov@gmail.com> <20190212015108.16952-3-andrew.smirnov@gmail.com> <1549964166.2546.21.camel@pengutronix.de> In-Reply-To: <1549964166.2546.21.camel@pengutronix.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=tpiepho@impinj.com; x-originating-ip: [216.207.205.253] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dea86cf2-c3cb-41b7-859e-08d69dc30d2b x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020); SRVR:MWHPR0601MB3643; x-ms-traffictypediagnostic: MWHPR0601MB3643: x-microsoft-exchange-diagnostics: 1; MWHPR0601MB3643; 20:0UUOa2p5TGQiSGknWseMCwuDANNl/TGY3VG01QcVpkVEdb6JE1BWRZnKW73k4KJtpTJwGY9gsJD3+CMUTMDR5ceK9lbwS9m6sR5uiqrySxekeCJd1DfYoGZa3Qk3AI5JIGh9PUM1PRcp5ajh5qJe/lkTyLTrn8ibboF2n5nu2X8= x-microsoft-antispam-prvs: x-forefront-prvs: 0962D394D2 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(346002)(366004)(376002)(39850400004)(136003)(189003)(199004)(446003)(11346002)(2616005)(110136005)(476003)(8936002)(2501003)(486006)(106356001)(186003)(68736007)(105586002)(316002)(54906003)(103116003)(5660300002)(97736004)(2906002)(305945005)(478600001)(71200400001)(53936002)(2201001)(99286004)(6436002)(66066001)(6512007)(6486002)(71190400001)(256004)(6246003)(229853002)(81156014)(81166006)(102836004)(25786009)(4326008)(6506007)(7416002)(26005)(76176011)(7736002)(3846002)(8676002)(86362001)(14454004)(36756003)(6116002); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR0601MB3643; H:MWHPR0601MB3708.namprd06.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: impinj.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: irE5sLP9fR6+c8x1kXUal/ppDPzwDLdhgnIahUlcmnTdrXD9fGOmoY/0zQ8F/Nl8wtDfrdAtD87lp6vjTqAJMcC8JG2B95otNQF2tiQB9emxLC8V4EOh7Fr7gUtkZXzCzzxI5vV4Y7HM1UeI+XjmvlSu9OqhKWN1tud8r2Shn9+n8F8GCKxXC/7Oa/rfIbeY4S5Ye3mKOPJPDLPkYLamiLY05v2F89rjiaN7Yt7ueVaCrIwhclqrazHsaIm1azqv/0m3XkdOLypUK1Vr/pv4ERXKzhQPOlxSS17VQMPOIdqsav5sAVYksfTGxUfV1uAD+o3ow01yNG3SJJUbj8n8+vMJF8xxRzL7UhtOLDVlNLyG0e68cCi51VdS8bu7CZ9pdaW5KfmJWaDDWQqq5KeBl1skPAMdRrj5H+uH2MdNtxo= Content-ID: MIME-Version: 1.0 X-OriginatorOrg: impinj.com X-MS-Exchange-CrossTenant-Network-Message-Id: dea86cf2-c3cb-41b7-859e-08d69dc30d2b X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2019 21:23:58.3392 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 6de70f0f-7357-4529-a415-d8cbb7e93e5e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR0601MB3643 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190228_132403_494111_6946D241 X-CRM114-Status: GOOD ( 13.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "aisheng.dong@nxp.com" , "devicetree@vger.kernel.org" , "hongxing.zhu@nxp.com" , "robh@kernel.org" , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , "linux-imx@nxp.com" , "fabio.estevam@nxp.com" , "leonard.crestez@nxp.com" , "cphealy@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2019-02-12 at 10:36 +0100, Lucas Stach wrote: > Am Montag, den 11.02.2019, 17:51 -0800 schrieb Andrey Smirnov: > > PCIe IP block has additional clock, "pcie_aux", that needs to be > > controlled by the driver. Add code to support that. This breaks iMX7d. > > > > @@ -1049,6 +1059,12 @@ static int imx6_pcie_probe(struct platform_device *pdev) > > dev_err(dev, "Failed to get PCIE APPS reset control\n"); > > return PTR_ERR(imx6_pcie->apps_reset); > > } > > + > > + imx6_pcie->pcie_aux = devm_clk_get(dev, "pcie_aux"); > > + if (IS_ERR(imx6_pcie->pcie_aux)) { > > + dev_err(dev, "pcie_aux clock source missing or invalid\n"); > > + return PTR_ERR(imx6_pcie->pcie_aux); > > + } > > break; > > default: > > break; One can't see enough context in the patch above, but in linux-next this section is under case IMX7D: case IMX8MQ: It's being applied to imx7d and not just imx8mq and so breaks because imx7d dts files don't have this clock. Not sure if this is a bug in this commit or some kind of merge/rebase mistake. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel