From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81F7DC43381 for ; Wed, 13 Mar 2019 10:33:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51092214AE for ; Wed, 13 Mar 2019 10:33:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="X+sNkfT8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ZIqjgjMO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51092214AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u+bGr9bAjm5+bvk5E7zfmPwwBuwwFchjkosjkHCV5Cg=; b=X+sNkfT8sC7BV1 7p1ghqFGV+a9u8bfsnXGPsUmzZCjGDmIb1bIDIm2eq2bQmc3h0uGwQ2nPk/PKIxyI0JXPVJvIOluq RkS6EMYP1XlgHExxukY6XWoHuPss2fXiEevGXV1yibAeUaFNIWu7jiV8oEbA0Zc+fSmHX6bkx3r3O czmekriEsQsXr8mhpPns6JsnYVE7SSMC0QyP0uZXfFnTj+Yx/10qYBQK6Pv2RYJ+EmC/7FBDiL5N1 bhDumKM4C1ROTIyqNkIVuCsiRDtMuDPeVXlP9uLiDsAny4zS0WlVTH9OcQ3ozMin/77wq2ajS9ltp jkDm0UexFq3DmnN+fBRg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h41C4-0003ii-Ac; Wed, 13 Mar 2019 10:33:04 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h41AE-0001eR-8H; Wed, 13 Mar 2019 10:31:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=02SVWyFDCy/IbVpoEQ3r5qNNuLbp8VBQ+0D0ioAb/Kg=; b=ZIqjgjMOl+ZBMF9v0F8VupWemQ DvovwciL97zT9zuttCP4UGNAmd2I0jNcEJVoW6p2vna9EIix+GkNfiauKW8ZUMs/PxdeEmqUyYNAi i3npMiPc3BHYlmZnV4O3qcV5HqWPMeH3RRhJxuGMS+HEUoXuOhSvYHJbdRyuSQZKO59QQpA8JlOgd fTLdF1Yv6vMXRX3YKiMCU3GBnzoLwRyN4rkvnm+CG/H8rphA+a7jGLglPtzeCdcuYN9YZtb3V5F// OfJRsWXLqUgIKaBGgq4Bq3ZES+5rJVurKLF38l37VlezceHZaGE3YHmXBKLzbHduiHFFZAeuMTjNj JkvmmQyw==; Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3zwH-0007Wf-Fb; Wed, 13 Mar 2019 09:12:43 +0000 X-UUID: e71e2d1d0f13423f8f6c51fef7127b7e-20190313 X-UUID: e71e2d1d0f13423f8f6c51fef7127b7e-20190313 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 683972254; Wed, 13 Mar 2019 01:11:58 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 13 Mar 2019 02:11:56 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 13 Mar 2019 17:11:53 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 13 Mar 2019 17:11:53 +0800 Message-ID: <1552468313.7433.14.camel@mhfsdcap03> Subject: Re: [PATCH 04/13] iommu/mediatek: Add device_link between the consumer and the larb devices From: Yong Wu To: Robin Murphy Date: Wed, 13 Mar 2019 17:11:53 +0800 In-Reply-To: <709d7d66-9610-eeb3-128e-e2156bcfb616@arm.com> References: <1546318276-18993-1-git-send-email-yong.wu@mediatek.com> <1546318276-18993-5-git-send-email-yong.wu@mediatek.com> <709d7d66-9610-eeb3-128e-e2156bcfb616@arm.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190313_051241_751174_3AA832A6 X-CRM114-Status: GOOD ( 26.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, Nicolas Boichat , srv_heupstream@mediatek.com, arnd@arndb.de, Greg Kroah-Hartman , Joerg Roedel , Will Deacon , linux-kernel@vger.kernel.org, Tomasz Figa , iommu@lists.linux-foundation.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , yingjoe.chen@mediatek.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Robin, sorry for reply so late. On Wed, 2019-02-27 at 19:30 +0000, Robin Murphy wrote: > On 01/01/2019 04:51, Yong Wu wrote: > > MediaTek IOMMU don't have its power-domain. all the consumer connect > > with smi-larb, then connect with smi-common. > > > > M4U > > | > > smi-common > > | > > ------------- > > | | ... > > | | > > larb1 larb2 > > | | > > vdec venc > > > > When the consumer works, it should enable the smi-larb's power which > > also need enable the smi-common's power firstly. > > > > Thus, First of all, use the device link connect the consumer and the > > smi-larbs. then add device link between the smi-larb and smi-common. > > > > This patch adds device_link between the consumer and the larbs. > > > > Suggested-by: Tomasz Figa > > Signed-off-by: Yong Wu > > --- > > drivers/iommu/mtk_iommu.c | 15 +++++++++++++-- > > drivers/iommu/mtk_iommu_v1.c | 14 ++++++++++++-- > > 2 files changed, 25 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > > index 202e41b..735ae8d 100644 > > --- a/drivers/iommu/mtk_iommu.c > > +++ b/drivers/iommu/mtk_iommu.c > > @@ -247,6 +247,7 @@ static void mtk_iommu_config(struct mtk_iommu_data *data, > > struct mtk_smi_larb_iommu *larb_mmu; > > unsigned int larbid, portid; > > struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev); > > + struct device_link *link; > > int i; > > > > for (i = 0; i < fwspec->num_ids; ++i) { > > @@ -257,10 +258,20 @@ static void mtk_iommu_config(struct mtk_iommu_data *data, > > dev_dbg(dev, "%s iommu port: %d\n", > > enable ? "enable" : "disable", portid); > > > > - if (enable) > > + if (enable) { > > larb_mmu->mmu |= MTK_SMI_MMU_EN(portid); > > - else > > + /* Link the consumer with the larb device(supplier) */ > > + link = device_link_add(dev, larb_mmu->dev, > > + DL_FLAG_PM_RUNTIME | > > + DL_FLAG_AUTOREMOVE_CONSUMER); > > This looks technically wrong, since we get here from > mtk_iommu_attach_device(), and in theory a device could get attached to > any number of domains over its lifetime, so adding a link at this point > when there's no corresponding cleanup on detach is definitely > unbalanced. If you want this layer to manage the link on behalf of the > consumer, it would probably be better to do it at the point of > mtk_iommu_add_device(), and either track it for manual cleanup in > mtk_iommu_remove_device() or rely on AUTOREMOVE_SUPPLIER. Thanks. I will try to move the "device_link_add" in add_device in next version. > > Robin. > > > + if (!link) { > > + dev_err(dev, "Unable to link %s\n", > > + dev_name(larb_mmu->dev)); > > + return; > > + } > > + } else { > > larb_mmu->mmu &= ~MTK_SMI_MMU_EN(portid); > > + } > > } > > } > > > > diff --git a/drivers/iommu/mtk_iommu_v1.c b/drivers/iommu/mtk_iommu_v1.c > > index 9386aee..022bad9 100644 > > --- a/drivers/iommu/mtk_iommu_v1.c > > +++ b/drivers/iommu/mtk_iommu_v1.c > > @@ -201,6 +201,7 @@ static void mtk_iommu_config(struct mtk_iommu_data *data, > > struct mtk_smi_larb_iommu *larb_mmu; > > unsigned int larbid, portid; > > struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev); > > + struct device_link *link; > > int i; > > > > for (i = 0; i < fwspec->num_ids; ++i) { > > @@ -211,10 +212,19 @@ static void mtk_iommu_config(struct mtk_iommu_data *data, > > dev_dbg(dev, "%s iommu port: %d\n", > > enable ? "enable" : "disable", portid); > > > > - if (enable) > > + if (enable) { > > larb_mmu->mmu |= MTK_SMI_MMU_EN(portid); > > - else > > + link = device_link_add(dev, larb_mmu->dev, > > + DL_FLAG_PM_RUNTIME | > > + DL_FLAG_AUTOREMOVE_CONSUMER); > > + if (!link) { > > + dev_err(dev, "Unable to link %s\n", > > + dev_name(larb_mmu->dev)); > > + return; > > + } > > + } else { > > larb_mmu->mmu &= ~MTK_SMI_MMU_EN(portid); > > + } > > } > > } > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel