From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 945A3C004C9 for ; Tue, 7 May 2019 14:22:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 510CD206BF for ; Tue, 7 May 2019 14:22:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Byq0HhyA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 510CD206BF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5XbFUmGfjUPh06lzrzE3rkAoD0eeO0FyCqyxDoOtVFA=; b=Byq0HhyA6O3r87 g8U7IayHocbwmgbzXWXw75YxL2qK5Ie6KQXM2qaF2X5gTpVNa1lYfB5SOVfhd4HaQEn7XG/xFYvCp SDY0A4dgApC6toWzVmch4+uwGEGnIc3aRL1tdD4wL8Cz2xcBuLDxcu46DmTjEzXsJYmFMZfxnC9ue XxOUJgFl9mawWi4QbQ2dA0JK3+bYpPMjk6SWSb/LtbGZzpZ5YbLh46mnF3r8gNQ50W0816WpHGai+ /k73qnKnqF4UdVY4kUR7Nx7mUvXUxTb9Q7b1Xy5hDnjKTqKsezIwrSeDPjI/ei9y/FU4438fJTtvX M7IXGCOb661cDZ1oVD1Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hO0yy-00074H-WC; Tue, 07 May 2019 14:22:13 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hO0yw-00073i-Rr; Tue, 07 May 2019 14:22:12 +0000 X-UUID: de5276395ecc436c9f85859125c12cf9-20190507 X-UUID: de5276395ecc436c9f85859125c12cf9-20190507 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 267588003; Tue, 07 May 2019 06:22:08 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 7 May 2019 07:22:06 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 7 May 2019 22:22:05 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 7 May 2019 22:22:05 +0800 Message-ID: <1557238925.11663.21.camel@mtksdccf07> Subject: Re: [RFC PATCH V1 1/6] dt-bindings: mt8183: Add binding for DIP shared memory From: Frederic Chen To: Rob Herring Date: Tue, 7 May 2019 22:22:05 +0800 In-Reply-To: <20190430011506.GA8514@bogus> References: <20190417104511.21514-1-frederic.chen@mediatek.com> <20190417104511.21514-2-frederic.chen@mediatek.com> <20190430011506.GA8514@bogus> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190507_072210_901408_D0A39E9E X-CRM114-Status: GOOD ( 23.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shik@chromium.org, devicetree@vger.kernel.org, Sean.Cheng@mediatek.com, laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com, christie.yu@mediatek.com, srv_heupstream@mediatek.com, holmes.chiou@mediatek.com, suleiman@chromium.org, Jerry-ch.Chen@mediatek.com, tfiga@chromium.org, jungo.lin@mediatek.com, sj.huang@mediatek.com, yuzhao@chromium.org, hans.verkuil@cisco.com, zwisler@chromium.org, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dear Rob, I appreciate your comments. On Mon, 2019-04-29 at 20:15 -0500, Rob Herring wrote: > On Wed, Apr 17, 2019 at 06:45:06PM +0800, Frederic Chen wrote: > > This patch adds the binding for describing the shared memory > > used to exchange configuration and tuning data between the > > co-processor and Digital Image Processing (DIP) unit of the > > camera ISP system on Mediatek SoCs. > > > > Signed-off-by: Frederic Chen > > --- > > .../mediatek,reserve-memory-dip_smem.txt | 45 +++++++++++++++++++ > > 1 file changed, 45 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > > > > diff --git a/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt b/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > > new file mode 100644 > > index 000000000000..64c001b476b9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > > @@ -0,0 +1,45 @@ > > +Mediatek DIP Shared Memory binding > > + > > +This binding describes the shared memory, which serves the purpose of > > +describing the shared memory region used to exchange data between Digital > > +Image Processing (DIP) and co-processor in Mediatek SoCs. > > + > > +The co-processor doesn't have the iommu so we need to use the physical > > +address to access the shared buffer in the firmware. > > + > > +The Digital Image Processing (DIP) can access memory through mt8183 IOMMU so > > +it can use dma address to access the memory region. > > +(See iommu/mediatek,iommu.txt for the detailed description of Mediatek IOMMU) > > + > > + > > +Required properties: > > + > > +- compatible: must be "mediatek,reserve-memory-dip_smem" > > Don't use '_'. I got it. I will use "mediatek,reserve-memory-dip-smem" instead in next version of the patch > > > + > > +- reg: required for static allocation (see reserved-memory.txt for > > + the detailed usage) > > + > > +- alloc-range: required for dynamic allocation. The range must > > + between 0x00000400 and 0x100000000 due to the co-processer's > > + addressing limitation > > Generally, you should pick either static or dynamic allocation for a > given binding. Static if there's some address restriction or sharing, > dynamic if not. > > Sounds like static in this case. > DIP reserved memory has address restriction so it is the static case. I would like to remove the dynamic allocation part and modify the description as following: - reg: required for DIP. The range must be between 0x00000400 and 0x100000000 due to the co-processor's addressing limitation. The size must be 26MB. Please see reserved-memory.txt for the detailed usage. > > + > > +- size: required for dynamic allocation. The unit is bytes. > > + If you want to enable the full feature of Digital Processing Unit, > > + you need 20 MB at least. > > + > > + > > +Example: > > + > > +The following example shows the DIP shared memory setup for MT8183. > > + > > + reserved-memory { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > + reserve-memory-dip_smem { > > + compatible = "mediatek,reserve-memory-dip_smem"; > > + size = <0 0x1400000>; > > + alignment = <0 0x1000>; > > + alloc-ranges = <0 0x40000000 0 0x50000000>; > > + }; > > + }; > > -- > > 2.18.0 > > Sincerely, Frederic Chen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel