From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1212DC04AAC for ; Mon, 20 May 2019 14:05:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB83B216B7 for ; Mon, 20 May 2019 14:05:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RDWgP4NJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB83B216B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TI/J5Js55HHYpgQ24i8/Di2+sSP0aoK4RCYW0gvWHwA=; b=RDWgP4NJae2AEd yLxDS3BRYF0KcGbuCV6dvThaDoU7nZsFTvZmnerqTfh1E6XNGgyJyQFQeVdStkZFzl3WW6S4EcLj/ kBpazDEQCLdBOnsTRUaTU59ehMqzOD8qZxEMKYdSFxmxfeV7sCutLRwzoo9q1kKPGpNsLeIR718F0 Av3+MrqdEEfboWtriHBqxpH1lHKaVY3KoM+6Z8eAWbshP09DRaPuC7bg4b0tsaYkC/j6XS7UVtFNH WnDcTwl+YkPK2bHleIutCNT7GsTwQyi/CDPkgzknwLGGj6u6HfdWzkVQdd6GqrhzXxqdVW7abM7GH boM73qIWVlJrRLQO/cpQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSivC-0004qX-0z; Mon, 20 May 2019 14:05:46 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hSiv7-0004pZ-Ie; Mon, 20 May 2019 14:05:42 +0000 X-UUID: 3c9ec5f8585644329577aa91e7d57e5f-20190520 X-UUID: 3c9ec5f8585644329577aa91e7d57e5f-20190520 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 662098336; Mon, 20 May 2019 06:05:32 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 20 May 2019 07:05:30 -0700 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 20 May 2019 22:05:29 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 20 May 2019 22:05:29 +0800 Message-ID: <1558361129.660.8.camel@mtkswgap22> Subject: RE: [PATCH v3 2/3] scsi: ufs: Add error-handling of Auto-Hibernate From: Stanley Chu To: Avri Altman Date: Mon, 20 May 2019 22:05:29 +0800 In-Reply-To: References: <1558341138-18043-1-git-send-email-stanley.chu@mediatek.com> <1558341138-18043-3-git-send-email-stanley.chu@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190520_070541_614552_0306B4AB X-CRM114-Status: GOOD ( 11.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-scsi@vger.kernel.org" , "martin.petersen@oracle.com" , "marc.w.gonzalez@free.fr" , "andy.teng@mediatek.com" , "chun-hung.wu@mediatek.com" , "kuohong.wang@mediatek.com" , "evgreen@chromium.org" , "linux-mediatek@lists.infradead.org" , "peter.wang@mediatek.com" , "alim.akhtar@samsung.com" , "matthias.bgg@gmail.com" , "pedrom.sousa@synopsys.com" , "linux-arm-kernel@lists.infradead.org" , "beanhuo@micron.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Avri, On Mon, 2019-05-20 at 09:51 +0000, Avri Altman wrote: > Aside from some nits - see below, looks fine. > > Thanks, > Avri > > > diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h > > index ecfa898b9ccc..994d73d03207 100644 > > --- a/drivers/scsi/ufs/ufshcd.h > > +++ b/drivers/scsi/ufs/ufshcd.h > > @@ -740,6 +740,11 @@ return true; > > #endif > > } > > > > +static inline bool ufshcd_is_auto_hibern8_supported(struct ufs_hba *hba) > > +{ > > + return (hba->capabilities & MASK_AUTO_HIBERN8_SUPPORT); > > +} > Maybe use it elsewhere in the driver, preferable in a preparatory patch, > Instead of patch #3. > OK. I will modify original patch #3 to a preparation patch which just re-factors ufshcd_is_auto_hibern8_supported(), and change its order to #2. > > > > diff --git a/drivers/scsi/ufs/ufshci.h b/drivers/scsi/ufs/ufshci.h > > index 6fa889de5ee5..4bcb205f2077 100644 > > --- a/drivers/scsi/ufs/ufshci.h > > +++ b/drivers/scsi/ufs/ufshci.h > > @@ -148,6 +148,9 @@ enum { > > UIC_HIBERNATE_EXIT |\ > > UIC_POWER_MODE) > > > > +#define UFSHCD_UIC_AH8_ERROR_MASK (UIC_HIBERNATE_ENTER |\ > > + UIC_HIBERNATE_EXIT) > So maybe update UFSHCD_UIC_PWR_MASK above OK. WIll make these definitions more elegant. > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek Thanks, Stanley _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel