From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3C50C282DD for ; Thu, 23 May 2019 10:16:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 732F02133D for ; Thu, 23 May 2019 10:16:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J6AJQ9Bu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 732F02133D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Type:References:In-Reply-To:Date:To:From:Subject:Message-ID:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WL4sU6VuNmeFif0luI4ESIjjYUggXj7OA7dxa+h/d0k=; b=J6AJQ9BuQy6Xuus1LyhgO+SZQ pQIwrYoJvtySz9ks3E5qPplK83Oy7IEefAve2aaoir4b59L31lZX3S0LO35/uwNtiYmcwbz4o1H5q oy27Q39MPcupyhzlv3y8wUlmWs6hI9gxO7o+6V3OD0+RPD9WkQwW6xfqq/VYeNSPTbb0ee509tsFG 5G/9v4aGBRFuA8lSHcnYW9smc9YPunoIrYLdyn+3KNQaUv0EQxvRlPjIdxhkGCx8+ss3LnsFjxsmj 95vmU7DFCXpXed7REciXdx75Ks5uSUjk76hLiJSg2inFvfMiKXlNGza1tOltrFbB4J7iLKPWfig+L i7oUN269w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTklv-0007nT-Jc; Thu, 23 May 2019 10:16:27 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTklr-0007ln-Ga; Thu, 23 May 2019 10:16:25 +0000 X-UUID: 67f8e6b9f60a431392073921676c889d-20190523 X-UUID: 67f8e6b9f60a431392073921676c889d-20190523 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 254020128; Thu, 23 May 2019 02:16:15 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 23 May 2019 03:16:13 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 23 May 2019 18:16:11 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 23 May 2019 18:16:10 +0800 Message-ID: <1558606570.10179.403.camel@mhfsdcap03> Subject: Re: [PATCH v5 4/6] usb: roles: add API to get usb_role_switch by node From: Chunfeng Yun To: Heikki Krogerus Date: Thu, 23 May 2019 18:16:10 +0800 In-Reply-To: <20190522142640.GN1887@kuha.fi.intel.com> References: <20190517130511.GA1887@kuha.fi.intel.com> <1558319951.10179.352.camel@mhfsdcap03> <20190520080359.GC1887@kuha.fi.intel.com> <20190520083601.GE1887@kuha.fi.intel.com> <20190521095839.GI1887@kuha.fi.intel.com> <1558517436.10179.388.camel@mhfsdcap03> <20190522142640.GN1887@kuha.fi.intel.com> Content-Type: multipart/mixed; boundary="=-1DBptkwq7PrdOe2/R7LH" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190523_031623_561780_DF42D112 X-CRM114-Status: GOOD ( 41.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , Hans de Goede , Greg Kroah-Hartman , Linus Walleij , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Biju Das , Badhri Jagan Sridharan , Andy Shevchenko , Rob Herring , "linux-mediatek@lists.infradead.org" , Min Guo , Matthias Brugger , Adam Thomson , "linux-arm-kernel@lists.infradead.org" , Li Jun Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --=-1DBptkwq7PrdOe2/R7LH Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Hi Heikki, On Wed, 2019-05-22 at 17:26 +0300, Heikki Krogerus wrote: > On Wed, May 22, 2019 at 10:55:17AM +0000, Biju Das wrote: > > Hi Chunfeng Yun, > > > > Thanks for the feedback. > > > > > Subject: RE: [PATCH v5 4/6] usb: roles: add API to get usb_role_switch by > > > node > > > > > > Hi Biju, > > > On Wed, 2019-05-22 at 08:05 +0000, Biju Das wrote: > > > > Hi Heikki, > > > > > > > > Thanks for the feedback. > > > > > > > > > Subject: Re: [PATCH v5 4/6] usb: roles: add API to get > > > > > usb_role_switch by node > > > > > > > > > > On Mon, May 20, 2019 at 09:45:46AM +0000, Biju Das wrote: > > > > > > > > > > > > > > > > > > Hi Heikki, > > > > > > > > > > > > Thanks for the feedback. > > > > > > > > > > > > > Subject: Re: [PATCH v5 4/6] usb: roles: add API to get > > > > > > > usb_role_switch by node > > > > > > > > > > > > > > On Mon, May 20, 2019 at 08:06:41AM +0000, Biju Das wrote: > > > > > > > > Hi Heikki, > > > > > > > > > > > > > > > > > Subject: Re: [PATCH v5 4/6] usb: roles: add API to get > > > > > > > > > usb_role_switch by node > > > > > > > > > > > > > > > > > > On Mon, May 20, 2019 at 10:39:11AM +0800, Chunfeng Yun wrote: > > > > > > > > > > Hi, > > > > > > > > > > On Fri, 2019-05-17 at 16:05 +0300, Heikki Krogerus wrote: > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > > > > > On Fri, May 17, 2019 at 01:37:36PM +0300, Heikki Krogerus > > > wrote: > > > > > > > > > > > > On Tue, May 14, 2019 at 04:47:21PM +0800, Chunfeng Yun > > > > > wrote: > > > > > > > > > > > > > Add fwnode_usb_role_switch_get() to make easier to > > > > > > > > > > > > > get usb_role_switch by fwnode which register it. > > > > > > > > > > > > > It's useful when there is not device_connection > > > > > > > > > > > > > registered between two drivers and only knows the > > > > > > > > > > > > > fwnode which register usb_role_switch. > > > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Chunfeng Yun > > > > > > > > > > > > > > > > > > > > > > > > > > Tested-by: Biju Das > > > > > > > > > > > > > > > > > > > > > > > > Acked-by: Heikki Krogerus > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hold on. I just noticed Rob's comment on patch 2/6, > > > > > > > > > > > where he points out that you don't need to use device > > > > > > > > > > > graph since the controller is the parent of the > > > > > > > > > > > connector. Doesn't that mean you don't really need this API? > > > > > > > > > > No, I still need it. > > > > > > > > > > The change is about the way how to get fwnode; when use > > > > > > > > > > device graph, get fwnode by of_graph_get_remote_node(); > > > > > > > > > > but now will get fwnode by of_get_parent(); > > > > > > > > > > > > > > > > > > OK, I get that, but I'm still not convinced about if > > > > > > > > > something like this function is needed at all. I also have > > > > > > > > > concerns regarding how you are using the function. I'll > > > > > > > > > explain in comment to the patch 5/6 in this > > > > > > > series... > > > > > > > > > > > > > > > > FYI, Currently I am also using this api in my patch series. > > > > > > > > https://patchwork.kernel.org/patch/10944637/ > > > > > > > > > > > > > > Yes, and I have the same question for you I jusb asked in > > > > > > > comment I added to the patch 5/6 of this series. Why isn't > > > > > > > usb_role_switch_get() > > > > > enough? > > > > > > > > > > > > Currently no issue. It will work with this api as well, since the > > > > > > port node is > > > > > part of controller node. > > > > > > For eg:- > > > > > > https://patchwork.kernel.org/patch/10944627/ > > > > > > > > > > > > However if any one adds port node inside the connector node, then > > > > > > this > > > > > api may won't work as expected. > > > > > > Currently I get below error > > > > > > > > > > > > [ 2.299703] OF: graph: no port node found in > > > > > /soc/i2c@e6500000/hd3ss3220@47 > > > > > > > > > > We need to understand why is that happening? > > > > > > > > > > > > > Form the stack trace the parent node is "parent_node=hd3ss3220@47" , > > > instead of the "connector" node. > > > > That is the reason for the above error. > > > > > > > > [ 2.442429] of_graph_get_next_endpoint.part.0+0x28/0x168 > > > > [ 2.447889] of_fwnode_graph_get_next_endpoint+0x5c/0xb0 > > > > [ 2.453267] fwnode_graph_get_next_endpoint+0x20/0x30 > > > > [ 2.458374] device_connection_find_match+0x74/0x1a0 > > > > [ 2.463399] usb_role_switch_get+0x20/0x28 > > > > [ 2.467542] hd3ss3220_probe+0xc4/0x218 > > > > > > > > The use case is > > > > > > > > &i2c0 { > > > > hd3ss3220@47 { > > > > compatible = "ti,hd3ss3220"; > > > > > > > > usb_con: connector { > > > > compatible = "usb-c-connector"; > > > > port { > > > > hd3ss3220_ep: endpoint { > > > > remote-endpoint = > > > <&usb3_role_switch>; > > > > }; > > > > }; > > > > }; > > > > }; > > > > }; > > > > > > > > &usb3_peri0 { > > > > companion = <&xhci0>; > > > > usb-role-switch; > > > > > > > > port { > > > > usb3_role_switch: endpoint { > > > > remote-endpoint = <&hd3ss3220_ep>; > > > > }; > > > > }; > > > > }; > > > > > > > > Q1) How do we modify the usb_role_switch_get() function to search > > > > Child(connector) and child's endpoint? > > > How about firstly finding connector node in fwnode_graph_devcon_match(), > > > then search each endpoint? > > > > I have done a quick prototyping with the changes you suggested and it works. > > > > - struct fwnode_handle *ep; > > + struct fwnode_handle *ep,*child,*tmp = fwnode; > > > > - fwnode_graph_for_each_endpoint(fwnode, ep) { > > + child = fwnode_get_named_child_node(fwnode, "connector"); > > + if (child) > > + tmp = child; > > + > > + fwnode_graph_for_each_endpoint(tmp, ep) { > > > > Form the stack trace the parent node is "parent_node= connector" . > > > > [ 2.440922] of_graph_get_next_endpoint.part.0+0x28/0x168 > > [ 2.446381] of_fwnode_graph_get_next_endpoint+0x5c/0xb0 > > [ 2.451758] fwnode_graph_get_next_endpoint+0x20/0x30 > > [ 2.456866] device_connection_find_match+0x84/0x1c0 > > [ 2.461888] usb_role_switch_get+0x20/0x28 > > > > Heikki, > > Are you ok with the above changes? > > Doesn't that mean that if we made fwnode_usb_role_switch_get() the way > I proposed, there is no problem? You just find the "connector" child > node in your driver, and pass that to fwnode_usb_role_switch_get(): > > struct fwnode_handle *connector; > ... > connector = device_get_named_child_node(&client->dev, "connector"); > if (IS_ERR(connector)) > > > hd3ss3220->role_sw = fwnode_usb_role_switch_get(connector); > ... > > The difference is that instead of just converting a device node of an > usb role switch to the usb role switch, it works just like > usb_role_switch_get(), just taking fwnode instead of device entry as > parameter. > > I prepared the patches implementing fwnode_usb_role_switch_get() the > way I though it needs to work for my own tests. Please find the > patches attached. I tested these patches, it didn't work for case as following: case 2: &mtu3 { usb-role-switch; connector { compatible = "linux,typeb-conn-gpio", "usb-b-connector"; label = "micro-USB"; type = "micro"; id-gpios = <&pio 12 GPIO_ACTIVE_HIGH>; vbus-supply = <&usb_p0_vbus>; }; }; so I consider this case in the function fwnode_graph_devcon_match() (based on your patches) diff --git a/drivers/base/devcon.c b/drivers/base/devcon.c index 8311b70..1dae8b7 100644 --- a/drivers/base/devcon.c +++ b/drivers/base/devcon.c @@ -18,9 +18,11 @@ { struct device_connection con = { .id = con_id }; struct fwnode_handle *ep; + int ep_count = 0; void *ret; fwnode_graph_for_each_endpoint(fwnode, ep) { + ep_count++; con.fwnode = fwnode_graph_get_remote_port_parent(ep); if (!fwnode_device_is_available(con.fwnode)) continue; @@ -32,6 +34,19 @@ return ret; } } + + /* if the connector has no remote endpoint, check its parent */ + if (!ep_count) { + con.fwnode = fwnode_get_parent(fwnode); + if (!con.fwnode) + return NULL; + + ret = match(&con, -1, data); + fwnode_handle_put(con.fwnode); + if (ret) + return ret; + } + return NULL; } see attached patch. then both usb_role_switch_get(dev) or fwnode_usb_role_switch_get(fwnode) work well; but I don't know which way is better when consider this specific case, put into class.c as you suggested before or put into devcon.c like above. Thanks a lot > > thanks, > --=-1DBptkwq7PrdOe2/R7LH Content-Disposition: attachment; filename="0001-device-connection-test-only.patch" Content-Type: text/x-patch; name="0001-device-connection-test-only.patch"; charset="UTF-8" Content-Transfer-Encoding: 7bit >From bd291df4d0247fce5c11da746ae0761420054cf7 Mon Sep 17 00:00:00 2001 From: Chunfeng Yun Date: Thu, 23 May 2019 18:04:28 +0800 Subject: [PATCH] device connection: test only Change-Id: Ie1b4b6304dfd7a89516fa3578aa5a5b1be924212 Signed-off-by: Chunfeng Yun --- drivers/base/devcon.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/base/devcon.c b/drivers/base/devcon.c index 8311b70bbca2..1dae8b77562d 100644 --- a/drivers/base/devcon.c +++ b/drivers/base/devcon.c @@ -18,9 +18,11 @@ fwnode_graph_devcon_match(struct fwnode_handle *fwnode, const char *con_id, { struct device_connection con = { .id = con_id }; struct fwnode_handle *ep; + int ep_count = 0; void *ret; fwnode_graph_for_each_endpoint(fwnode, ep) { + ep_count++; con.fwnode = fwnode_graph_get_remote_port_parent(ep); if (!fwnode_device_is_available(con.fwnode)) continue; @@ -32,6 +34,19 @@ fwnode_graph_devcon_match(struct fwnode_handle *fwnode, const char *con_id, return ret; } } + + /* if the connector has no remote endpoint, check its parent */ + if (!ep_count) { + con.fwnode = fwnode_get_parent(fwnode); + if (!con.fwnode) + return NULL; + + ret = match(&con, -1, data); + fwnode_handle_put(con.fwnode); + if (ret) + return ret; + } + return NULL; } -- 2.21.0 --=-1DBptkwq7PrdOe2/R7LH Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --=-1DBptkwq7PrdOe2/R7LH--