From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFFE2C072B1 for ; Tue, 28 May 2019 08:24:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97659208C3 for ; Tue, 28 May 2019 08:24:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WVJzKp1A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 97659208C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5EyLC0lviEeSgMlzPDJgcSYVV1o0A7bbOwQ4E+lhjkw=; b=WVJzKp1AwmuyQr xVX1a6uyw6okjkSpvpeb24b7yyn+70ng5ELbENgRL7zWS6faRPeOGwLlUdEbF7pLkzN/lAT7Sdsff 94uoefN5pvlYImIlI39jlLxux2PgJWmOoQ91QXaWIMFD9HMCbioS9IOak3TLEaWbu2K92rCunIvPR 7YUfCMwzMfXmh3o7csEpb7XKZKSqqa+hmB3Z10+HZfPZbCQRxv/tQH9rlOg4Bwm9grqDtSQl4wzX+ 0QKSjWqVBsLcQt6hVc1+3sdmmEHzWwxYYUIvVCsfF2GVqvd1ZeCAdywcrEmlEeIUiMSqc4thzOGRS UArawAqPjKYUhdA0co0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVXPV-0003bp-W5; Tue, 28 May 2019 08:24:41 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVXPT-0003b4-NW; Tue, 28 May 2019 08:24:41 +0000 X-UUID: 69e20f0dd27b40eabd0352fbbfdef19a-20190528 X-UUID: 69e20f0dd27b40eabd0352fbbfdef19a-20190528 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1705875596; Tue, 28 May 2019 00:24:18 -0800 Received: from MTKMBS32DR.mediatek.inc (172.27.6.104) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 28 May 2019 01:24:17 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS32DR.mediatek.inc (172.27.6.104) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 28 May 2019 16:24:14 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 28 May 2019 16:24:13 +0800 Message-ID: <1559031853.10179.441.camel@mhfsdcap03> Subject: Re: [v3 PATCH] usb: create usb_debug_root for gadget only From: Chunfeng Yun To: Greg Kroah-Hartman , Felipe Balbi Date: Tue, 28 May 2019 16:24:13 +0800 In-Reply-To: References: X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: C96933C95D958AC6AE24513B8160BC0AC75F44EAA61D38CE6C91777A0D4E505A2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_012439_767895_E859FB48 X-CRM114-Status: GOOD ( 19.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-usb@vger.kernel.org, Randy Dunlap , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org add Felipe, sorry On Tue, 2019-05-28 at 15:54 +0800, Chunfeng Yun wrote: > When CONFIG_USB is not set, and CONFIG_USB_GADGET is set, > there is an issue, e.g.: > > drivers/usb/mtu3/mtu3_debugfs.o: in function 'ssusb_debugfs_create_root': > mtu3_debugfs.c:(.text+0xba3): undefined reference to 'usb_debug_root' > > usb_debug_root is currently only built when host is supported > (CONFIG_USB is set), for convenience, we also want it created when > gadget only is enabled, this patch try to support it. > > Reported-by: Randy Dunlap > Signed-off-by: Chunfeng Yun > --- > v3: > 1. still create usb_debug_root for gadget only > 2. abandon mtu3's change > 3. drop acked-by Randy > > v2(resend): add acked-by Randy > > v1: fix mtu3's build error, replace usb_debug_root by NULL; > --- > drivers/usb/core/usb.c | 2 +- > drivers/usb/gadget/udc/core.c | 27 +++++++++++++++++++++++++++ > include/linux/usb.h | 1 + > 3 files changed, 29 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c > index 7fcb9f782931..88b3ee03a12d 100644 > --- a/drivers/usb/core/usb.c > +++ b/drivers/usb/core/usb.c > @@ -1190,7 +1190,7 @@ EXPORT_SYMBOL_GPL(usb_debug_root); > > static void usb_debugfs_init(void) > { > - usb_debug_root = debugfs_create_dir("usb", NULL); > + usb_debug_root = debugfs_create_dir(USB_DEBUG_ROOT_NAME, NULL); > debugfs_create_file("devices", 0444, usb_debug_root, NULL, > &usbfs_devices_fops); > } > diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c > index 7cf34beb50df..ed45f9429e58 100644 > --- a/drivers/usb/gadget/udc/core.c > +++ b/drivers/usb/gadget/udc/core.c > @@ -8,6 +8,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -1587,12 +1588,37 @@ static int usb_udc_uevent(struct device *dev, struct kobj_uevent_env *env) > return 0; > } > > +/* if CONFIG_USB is set, leave USB core to create usb_debug_root */ > +#ifndef CONFIG_USB > +struct dentry *usb_debug_root; > +EXPORT_SYMBOL_GPL(usb_debug_root); > + > +static void usb_debugfs_init(void) > +{ > + usb_debug_root = debugfs_create_dir(USB_DEBUG_ROOT_NAME, NULL); > +} > + > +static void usb_debugfs_cleanup(void) > +{ > + debugfs_remove_recursive(usb_debug_root); > +} > +#else > +static void usb_debugfs_init(void) > +{} > + > +static void usb_debugfs_cleanup(void) > +{} > +#endif > + > static int __init usb_udc_init(void) > { > + usb_debugfs_init(); > + > udc_class = class_create(THIS_MODULE, "udc"); > if (IS_ERR(udc_class)) { > pr_err("failed to create udc class --> %ld\n", > PTR_ERR(udc_class)); > + usb_debugfs_cleanup(); > return PTR_ERR(udc_class); > } > > @@ -1604,6 +1630,7 @@ subsys_initcall(usb_udc_init); > static void __exit usb_udc_exit(void) > { > class_destroy(udc_class); > + usb_debugfs_cleanup(); > } > module_exit(usb_udc_exit); > > diff --git a/include/linux/usb.h b/include/linux/usb.h > index ae82d9d1112b..9c6e7b3265af 100644 > --- a/include/linux/usb.h > +++ b/include/linux/usb.h > @@ -1994,6 +1994,7 @@ extern void usb_register_notify(struct notifier_block *nb); > extern void usb_unregister_notify(struct notifier_block *nb); > > /* debugfs stuff */ > +#define USB_DEBUG_ROOT_NAME "usb" > extern struct dentry *usb_debug_root; > > /* LED triggers */ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel