From: Guenter Roeck <linux@roeck-us.net>
To: Randy Dunlap <rdunlap@infradead.org>,
Romain Perier <romain.perier@gmail.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Daniel Palmer <daniel@0x0f.com>,
Mohammed Billoo <mohammed.billoo@gmail.com>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] watchdog: Add Mstar MSC313e WDT driver
Date: Tue, 25 May 2021 12:53:06 -0700 [thread overview]
Message-ID: <155f6b43-3f18-1c19-2dd2-4c9dc38ccfac@roeck-us.net> (raw)
In-Reply-To: <dfb1173d-7564-9386-10bf-5151ef284635@infradead.org>
On 5/25/21 11:49 AM, Randy Dunlap wrote:
> Hi,
>
> On 5/25/21 11:44 AM, Romain Perier wrote:
>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
>> index 355100dad60a..f53634ea0de6 100644
>> --- a/drivers/watchdog/Kconfig
>> +++ b/drivers/watchdog/Kconfig
>> @@ -980,6 +980,19 @@ config VISCONTI_WATCHDOG
>> Say Y here to include support for the watchdog timer in Toshiba
>> Visconti SoCs.
>>
>> +config MSC313E_WATCHDOG
>> + tristate "MStar MSC313e watchdog"
>> + depends on ARCH_MSTARV7 || COMPILE_TEST
>> + depends on OF
>> + select WATCHDOG_CORE
>> + help
>> + Say Y here to include support for the Watchdog timer embedded
>> + into MStar MSC313e chips. This will reboot your system when the
>> + timeout is reached.
>> +
>> + To compile this driver as a module, choose M here: the
>> + module will be called msc313e_wdt.
>
> AFAIK, you don't need the "depends on OF" line since
> the of*.h headers provide stubs for the cases of CONFIG_OF
> and/or CONFIG_OF_ADDRESS not set/enabled.
>
I don't actually see any devicetree API calls in the driver.
Guenter
> Not having that line would also make COMPILE_TEST more effective.
>
> Can Rob or anyone else comment on this?
>
> thanks.
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-25 19:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 18:44 [PATCH 0/3] Add watchdog for Mstar SoCs Romain Perier
2021-05-25 18:44 ` [PATCH 1/3] Documentation: watchdog: Add Mstar MSC313e WDT devicetree bindings documentation Romain Perier
2021-05-25 18:44 ` [PATCH 2/3] watchdog: Add Mstar MSC313e WDT driver Romain Perier
2021-05-25 18:49 ` Randy Dunlap
2021-05-25 19:53 ` Guenter Roeck [this message]
2021-05-25 19:52 ` Guenter Roeck
2021-05-26 19:24 ` Romain Perier
2021-05-25 18:44 ` [PATCH 3/3] ARM: dts: mstar: Add watchdog device_node definition Romain Perier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155f6b43-3f18-1c19-2dd2-4c9dc38ccfac@roeck-us.net \
--to=linux@roeck-us.net \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mohammed.billoo@gmail.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=romain.perier@gmail.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).