From: Frederic Chen <frederic.chen@mediatek.com>
To: Tomasz Figa <tfiga@chromium.org>
Cc: shik@chromium.org, devicetree@vger.kernel.org,
Sean.Cheng@mediatek.com,
laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com,
srv_heupstream@mediatek.com, holmes.chiou@mediatek.com,
suleiman@chromium.org, Jerry-ch.Chen@mediatek.com,
jungo.lin@mediatek.com, sj.huang@mediatek.com,
yuzhao@chromium.org, linux-mediatek@lists.infradead.org,
zwisler@chromium.org, matthias.bgg@gmail.com,
christie.yu@mediatek.com, mchehab@kernel.org,
hans.verkuil@cisco.com, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [RFC PATCH V1 6/6] platform: mtk-isp: Add Mediatek DIP driver
Date: Tue, 11 Jun 2019 16:48:06 +0800 [thread overview]
Message-ID: <1560242886.23799.13.camel@mtksdccf07> (raw)
In-Reply-To: <1558466055.15388.342.camel@mtksdccf07>
Dear Tomasz,
I'd like to elaborate more about the tuning_data.va.
Would you like to give us some advice about our improvement proposal inline?
Thank you very much.
On Wed, 2019-05-22 at 03:14 +0800, Frederic Chen wrote:
> Dear Tomasz,
>
> I appreciate your comment. It is very helpful for us.
>
>
> > > diff --git a/drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c b/drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c
> > > new file mode 100644
> > > index 000000000000..54d2b5f5b802
> > > --- /dev/null
> > > +++ b/drivers/media/platform/mtk-isp/isp_50/dip/mtk_dip-sys.c
> > > @@ -0,0 +1,1384 @@
[snip]
> > > +static void dip_submit_worker(struct work_struct *work)
> > > +{
> > > + struct mtk_dip_hw_submit_work *dip_submit_work =
> > > + container_of(work, struct mtk_dip_hw_submit_work, frame_work);
> > > + struct mtk_dip_hw *dip_hw = dip_submit_work->dip_hw;
> > > + struct mtk_dip_dev *dip_dev = mtk_dip_hw_to_dev(dip_hw);
> > > + struct mtk_dip_hw_work *dip_work;
> > > + struct mtk_dip_hw_subframe *buf;
> > > + u32 len, num;
> > > + int ret;
> > > +
> > > + num = atomic_read(&dip_hw->num_composing);
> > > +
> > > + mutex_lock(&dip_hw->dip_worklist.queuelock);
> > > + dip_work = list_first_entry(&dip_hw->dip_worklist.queue,
[snip]
> > > +
> > > + if (dip_work->frameparams.tuning_data.pa == 0) {
> > > + dev_dbg(&dip_dev->pdev->dev,
> > > + "%s: frame_no(%d) has no tuning_data\n",
> > > + __func__, dip_work->frameparams.frame_no);
> > > +
> > > + memcpy(&dip_work->frameparams.tuning_data,
> > > + &buf->tuning_buf, sizeof(buf->tuning_buf));
> >
> > Ditto.
> >
>
> I got it.
>
> > > + memset((char *)buf->tuning_buf.va, 0, DIP_TUNING_SZ);
> >
> > Ditto.
>
> I got it.
>
> >
> > > + /*
> > > + * When user enqueued without tuning buffer,
> > > + * it would use driver internal buffer.
> > > + * So, tuning_data.va should be 0
> > > + */
> > > + dip_work->frameparams.tuning_data.va = 0;
> >
> > I don't understand this. We just zeroed the buffer via this kernel VA few
> > lines above, so why would it have to be set to 0?
> >
>
> I will remove this unnecessary line.
>
> > > + }
After confirming the firmware part, I found that we use this field
(tuning_data.va) to notify firmware if there is no tuning data from
user.
- frameparams.tuning_data.va is 0: use the default tuning data in
SCP, but we still need to pass
frameparams.tuning_data.pa because
the buffer contains some working
buffer required.
- frameparams.tuning_data.va is not 0: the tuning data was passed from
the user
Since we should not pass cpu addres to SCP, could I rename tuning_data.va
as tuning_data.cookie, and write a constant value to indicate if SCP
should use its internal default setting or not here?
For example,
/* SCP uses tuning data passed from userspace*/
dip_work->frameparams.tuning_data.cookie = MTK_DIP_USER_TUNING_DATA;
/* SCP uses internal tuning data */
dip_work->frameparams.tuning_data.cookie = MTK_DIP_DEFAULT_TUNING_DATA;
> > > +
> > > + dip_work->frameparams.drv_data = (u64)dip_hw;
> >
> > Passing kernel pointers to firmware?
>
> I will remove this line.
>
> >
> > > + dip_work->frameparams.state = FRAME_STATE_COMPOSING;
> > > +
> > > + memcpy((void *)buf->frameparam.va, &dip_work->frameparams,
> > > + sizeof(dip_work->frameparams));
> >
> > There shouldn't be a need to type cast the pointer.
> >
>
> I will fix it.
>
> > > +
> > > + dip_send(dip_hw->vpu_pdev, SCP_IPI_DIP_FRAME,
> > > + (void *)&dip_work->frameparams,
> >
[snip]
Sincerely,
Frederic Chen
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-11 8:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 10:45 [RFC PATCH V1 0/6] media: platform: Add support for Digital Image Processing (DIP) on mt8183 SoC Frederic Chen
2019-04-17 10:45 ` [RFC PATCH V1 1/6] dt-bindings: mt8183: Add binding for DIP shared memory Frederic Chen
2019-04-30 1:15 ` Rob Herring
2019-05-07 14:22 ` Frederic Chen
2019-05-14 16:19 ` Rob Herring
2019-05-16 6:12 ` Tomasz Figa
2019-05-17 22:22 ` Rob Herring
2019-04-17 10:45 ` [RFC PATCH V1 2/6] dts: arm64: mt8183: Add DIP shared memory node Frederic Chen
2019-04-17 10:45 ` [RFC PATCH V1 3/6] dt-bindings: mt8183: Added DIP dt-bindings Frederic Chen
2019-04-30 1:16 ` Rob Herring
2019-05-07 14:16 ` Frederic Chen
2019-05-14 16:14 ` Rob Herring
2019-04-17 10:45 ` [RFC PATCH V1 4/6] dts: arm64: mt8183: Add DIP nodes Frederic Chen
2019-04-17 10:45 ` [RFC PATCH V1 5/6] media: platform: Add Mediatek DIP driver KConfig Frederic Chen
[not found] ` <20190417104511.21514-7-frederic.chen@mediatek.com>
2019-05-22 9:51 ` [RFC PATCH V1 6/6] platform: mtk-isp: Add Mediatek DIP driver Shik Chen
2019-05-23 14:24 ` Frederic Chen
[not found] ` <20190509094846.GA65444@google.com>
[not found] ` <1558466055.15388.342.camel@mtksdccf07>
2019-05-22 10:25 ` Tomasz Figa
2019-05-23 13:46 ` Frederic Chen
2019-05-29 3:38 ` Tomasz Figa
2019-06-11 8:48 ` Frederic Chen [this message]
2019-06-11 8:59 ` Tomasz Figa
2019-06-11 10:07 ` Frederic Chen
2019-06-11 10:13 ` Tomasz Figa
2019-06-25 11:35 ` Frederic Chen
2019-06-25 12:16 ` Frederic Chen
2019-06-26 4:24 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560242886.23799.13.camel@mtksdccf07 \
--to=frederic.chen@mediatek.com \
--cc=Jerry-ch.Chen@mediatek.com \
--cc=Rynn.Wu@mediatek.com \
--cc=Sean.Cheng@mediatek.com \
--cc=christie.yu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=holmes.chiou@mediatek.com \
--cc=jungo.lin@mediatek.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=shik@chromium.org \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=suleiman@chromium.org \
--cc=tfiga@chromium.org \
--cc=yuzhao@chromium.org \
--cc=zwisler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).