From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D5FEC5B578 for ; Tue, 2 Jul 2019 03:07:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04E43206A2 for ; Tue, 2 Jul 2019 03:07:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aknFJy3U"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Al5//5gO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04E43206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:MIME-Version:In-Reply-To: References:To:Subject:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z5PF/pUKsaM5T1W6xA+sCxWvQptmfJRDBheLU73XBWs=; b=aknFJy3Ujuo6Pq n/jQyoRg8uee2jfTWDfWKLrYxGEdRUAHUZp5ZwU0ScGRvgyb3te1fvLQqAbWHPE81s0G5oDJszcYE XZg7OI0zBFdvQ6jYf/lfilHCSn6V8TqeIvChA0SMHYSx+c95QTZrv3PVvVMQp9Qcgc5DYdMPXviFf wb3i6ahCUTURKlEtuDlq8HNVC8gSe9Byay1dVMuH8F24pa/f4rmqWd8v86Fuk26OJKBFiGPj+di2z oCml7jULj4w6GCvrj9z3pkHLl5uGBwNi57tRpKFs4qvyvQIEbVw3r9U2cMuzDc9o8mCSVgnQgu2Yq SjWYQM/W+pamtfFfyXzw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hi98p-0007rY-O9; Tue, 02 Jul 2019 03:07:35 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hi98n-0007rF-HE for linux-arm-kernel@lists.infradead.org; Tue, 02 Jul 2019 03:07:34 +0000 Received: by mail-pg1-x543.google.com with SMTP id m4so6953962pgk.0 for ; Mon, 01 Jul 2019 20:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :user-agent:message-id:content-transfer-encoding; bh=JEjj/PPo3yxC7A/OXv38wkR3+utyXU9OEcFxU+K+Oro=; b=Al5//5gOeoq+S2jUF4fWN70LRFW/gTgt2BAn2B0baRvM15+mvep+e5s4otLVXnFidS xBIE1sEHhvdBjGVQNKvZJxJgS3UdF4SDPQWO2bZ1qZ6vVx4wQIRlG/Q0PHTSe7GdH1CN 9cMVFo4aSiPy+/dKIODZEmbH7MLbzA/dmpvmep3x/AmEilTks2v/Y+pWLjIn9LQ0PH9R y3GTlAck0dxdUgSPhIuZPl2WokIMtkaDzckYgT3LAIei69JVQwqvYIY52W+nZxNG0pqj e8Okec5QN1hZ74rwLSruZokYUZf+wjNVH5HrnYrKVrKxKFTKrXBjDp1EUoQxYsO+hF7X 1bMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:user-agent:message-id:content-transfer-encoding; bh=JEjj/PPo3yxC7A/OXv38wkR3+utyXU9OEcFxU+K+Oro=; b=H5LgV6fz22d2tghN2jcQYuM/OrQUFLgm+jibDItjTVKTe641zwtYo9NNSaqRc4sN43 apJ7AsyGYm7VxUKdJzOvb4u2R/fWaseW++W7nqqvY3DlY6cxFiq2jVuTtZmZ3UVqsCqk fRGiIwQG6V2uqX4Am9EBAyhDmGp9J87i4jP7l5Ym8ISWAhmHYhtn2lQ2SeOAhd08/8Pn uFaFScJxpRsOLwDGa00jAM464GFyAfi6GR256o9E/1b0Qa6I5+mgYVNip3/lI4O3We6P 1qlrg3WBN20fl8mPLigEnm96dgCm6/iYIM6g4SKNmEICd/TSkKaNao492AUi5FfdDnWj JpKg== X-Gm-Message-State: APjAAAXSfHenNwR5ggOlkifluudnGStR+qCcTEqqmGAVjop82kSbkDEf nlBFq3l8DJ1aUhJw2Tqh0UU= X-Google-Smtp-Source: APXvYqxOVg0HFcmLKK0QMTMU/kWLAUMGqHvjW+x4ulftF7VETnHP5SSk6O+UdayEdNaJVHGmMdn0Lw== X-Received: by 2002:a65:6102:: with SMTP id z2mr27238296pgu.194.1562036851675; Mon, 01 Jul 2019 20:07:31 -0700 (PDT) Received: from localhost ([175.45.73.101]) by smtp.gmail.com with ESMTPSA id f11sm10274123pga.59.2019.07.01.20.07.30 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 01 Jul 2019 20:07:30 -0700 (PDT) Date: Tue, 02 Jul 2019 13:07:11 +1000 From: Nicholas Piggin Subject: Re: Re: [PATCH 1/3] arm64: mm: Add p?d_large() definitions To: Steven Price , Will Deacon References: <20190623094446.28722-1-npiggin@gmail.com> <20190623094446.28722-2-npiggin@gmail.com> <20190701092756.s4u5rdjr7gazvu66@willie-the-truck> <3d002af8-d8cd-f750-132e-12109e1e3039@arm.com> <20190701101510.qup3nd6vm6cbdgjv@willie-the-truck> In-Reply-To: <20190701101510.qup3nd6vm6cbdgjv@willie-the-truck> MIME-Version: 1.0 User-Agent: astroid/0.14.0 (https://github.com/astroidmail/astroid) Message-Id: <1562036522.cz5nnz6ri2.astroid@bobo.none> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190701_200733_599761_5BBE9930 X-CRM114-Status: UNSURE ( 9.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , Mark Rutland , Ard Biesheuvel , Catalin Marinas , Anshuman Khandual , Will Deacon , linux-mm@kvack.org, Andrew Morton , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Will Deacon's on July 1, 2019 8:15 pm: > On Mon, Jul 01, 2019 at 11:03:51AM +0100, Steven Price wrote: >> On 01/07/2019 10:27, Will Deacon wrote: >> > On Sun, Jun 23, 2019 at 07:44:44PM +1000, Nicholas Piggin wrote: >> >> walk_page_range() is going to be allowed to walk page tables other than >> >> those of user space. For this it needs to know when it has reached a >> >> 'leaf' entry in the page tables. This information will be provided by the >> >> p?d_large() functions/macros. >> > >> > I can't remember whether or not I asked this before, but why not call >> > this macro p?d_leaf() if that's what it's identifying? "Large" and "huge" >> > are usually synonymous, so I find this naming needlessly confusing based >> > on this patch in isolation. Those page table macro names are horrible. Large, huge, leaf, wtf? They could do with a sensible renaming. But this series just follows naming that's alreay there on x86. Thanks, Nick _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel