From: Stefan Wahren <wahrenst@gmx.net>
To: Eric Anholt <eric@anholt.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Mark Brown <broonie@kernel.org>
Cc: bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Stefan Wahren <wahrenst@gmx.net>
Subject: [PATCH RFC 14/18] HACK: pinctrl: bcm2835: Implement legacy pull for BCM7211
Date: Wed, 17 Jul 2019 23:16:00 +0200 [thread overview]
Message-ID: <1563398164-2679-1-git-send-email-wahrenst@gmx.net> (raw)
This temporay hack is necessary to make the BCM2838/7211 work with the legacy
pull configuration. The better approach is to convert all affected DTS files
to the generic bias control.
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
---
drivers/pinctrl/bcm/pinctrl-bcm2835.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/pinctrl/bcm/pinctrl-bcm2835.c b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
index 7f7cc5c..56161b6 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm2835.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm2835.c
@@ -1003,6 +1003,13 @@ static int bcm7211_pinconf_set(struct pinctrl_dev *pctldev,
/* convert to 7211 value */
switch (param) {
+ case BCM2835_PINCONF_PARAM_PULL:
+ /* convert legacy brcm,pull */
+ if (arg == BCM2835_PUD_UP)
+ arg = BCM7211_PINCONFIG_PULL_UP;
+ else if (arg == BCM2835_PUD_DOWN)
+ arg = BCM7211_PINCONFIG_PULL_DOWN;
+ break;
case PIN_CONFIG_BIAS_DISABLE:
arg = BCM7211_PINCONFIG_PULL_NONE;
break;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-07-17 21:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 21:16 Stefan Wahren [this message]
2019-07-17 21:16 ` [PATCH RFC 15/18] spi: bcm2835: enable shared interrupt support Stefan Wahren
2019-07-18 12:42 ` Mark Brown
2019-07-18 17:53 ` Stefan Wahren
2019-07-18 18:05 ` Florian Fainelli
2019-07-18 18:21 ` Stefan Wahren
2019-07-24 17:15 ` Mark Brown
2019-07-18 18:52 ` Mark Brown
2019-07-17 21:16 ` [PATCH RFC 16/18] dt-bindings: bcm: Add Raspberry Pi 4 B Stefan Wahren
2019-07-17 21:16 ` [PATCH RFC 17/18] ARM: bcm2835: Add bcm2838 compatible string Stefan Wahren
2019-07-17 21:16 ` [PATCH RFC 18/18] ARM: dts: Add minimal Raspberry Pi 4 support Stefan Wahren
2019-07-17 21:22 ` Florian Fainelli
2019-07-17 21:32 ` Stefan Wahren
2019-07-23 18:13 ` Marc Zyngier
2019-07-24 9:51 ` Vladimir Murzin
2019-07-24 10:41 ` Marc Zyngier
2019-07-24 12:36 ` Vladimir Murzin
2019-07-24 19:04 ` Stefan Wahren
2019-07-28 10:58 ` Stefan Wahren
2019-07-28 11:38 ` Marc Zyngier
2019-07-30 18:33 ` Stefan Wahren
2019-07-31 10:55 ` Marc Zyngier
2019-08-02 22:12 ` [PATCH RFC 14/18] HACK: pinctrl: bcm2835: Implement legacy pull for BCM7211 Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1563398164-2679-1-git-send-email-wahrenst@gmx.net \
--to=wahrenst@gmx.net \
--cc=adrian.hunter@intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sbranden@broadcom.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).