From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1DB0C7618F for ; Thu, 18 Jul 2019 16:48:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C19B21849 for ; Thu, 18 Jul 2019 16:48:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gNBQewsR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C19B21849 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Subject:Message-ID:References: In-Reply-To:From:To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D9SURA1azYwB531lzD0SMfzTjI16lBmc8D+QnAt98RY=; b=gNBQewsRZCwYOB aC+B6JZPriTSrYiu4YLze1/TmxcSDBU86sbxawZXPE5Ya+ul7YvabQjwdX1/HspduxaS8Cj1447ZN Lwmisz9hgVreWzc53+eS1zfFft+A9now1EAuVP2jliJs80Kyi07bHqIDloe4mIWazsX/MhpmFFeBA 5yY11lx2NSAYhdx+gBqthd/FFevUWAj0K1TtBHHVYN11PhJOA0nGeWMcxTGK/I5awyv3m7RbpnqB4 XiuxpngvouflsyG12qTluHGSxZHkVqR81mDAinftcHNqpNPeBHxur2qAE8wanNMKg+F6rllLk08De Q4pqZ1hlDWuQdqmpdOcw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1ho9Zw-0000oD-5R; Thu, 18 Jul 2019 16:48:24 +0000 Received: from mail.fireflyinternet.com ([109.228.58.192] helo=fireflyinternet.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1ho9Zq-0000lT-T7; Thu, 18 Jul 2019 16:48:21 +0000 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 17404642-1500050 for multiple; Thu, 18 Jul 2019 17:46:43 +0100 MIME-Version: 1.0 To: Intel Graphics Development , Sam Ravnborg , dri-devel@lists.freedesktop.org From: Chris Wilson In-Reply-To: <20190718161507.2047-3-sam@ravnborg.org> References: <20190718161507.2047-1-sam@ravnborg.org> <20190718161507.2047-3-sam@ravnborg.org> Message-ID: <156346840026.24728.936589728458336617@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h Date: Thu, 18 Jul 2019 17:46:40 +0100 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190718_094819_213271_4C7045AC X-CRM114-Status: GOOD ( 11.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Daniel Vetter , Liviu Dudau , Lionel Landwerlin , Eric Anholt , Sam Ravnborg , Rob Herring , Maxime Ripard , CK Hu , Thierry Reding , Daniel Vetter , Chunming Zhou , Jani Nikula , Maarten Lankhorst , linux-mediatek@lists.infradead.org, Stefan Agner , Matthias Brugger , Sean Paul , linux-arm-kernel@lists.infradead.org, Boris Brezillon , Thomas Zimmermann , Rob Clark , =?utf-8?q?Noralf_Tr=C3=B8nnes?= , Philipp Zabel , Sean Paul , =?utf-8?q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Sam Ravnborg (2019-07-18 17:14:58) > drm_print.h used DRM_NAME - thus adding a dependency from > include/drm/drm_print.h => uapi/drm/drm.h > > Hardcode the name "drm" to break this dependency. > The idea is that there shall be a minimal dependency > between include/drm/* and uapi/* > > Signed-off-by: Sam Ravnborg > Suggested-by: Daniel Vetter > Reviewed-by: Daniel Vetter > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Rob Clark > Cc: Sean Paul > Cc: Chris Wilson > Cc: Daniel Vetter > --- > include/drm/drm_print.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h > index a5d6f2f3e430..760d1bd0eaf1 100644 > --- a/include/drm/drm_print.h > +++ b/include/drm/drm_print.h > @@ -32,8 +32,6 @@ > #include > #include > > -#include > - > /** > * DOC: print > * > @@ -287,7 +285,7 @@ void drm_err(const char *format, ...); > /* Macros to make printk easier */ > > #define _DRM_PRINTK(once, level, fmt, ...) \ > - printk##once(KERN_##level "[" DRM_NAME "] " fmt, ##__VA_ARGS__) > + printk##once(KERN_##level "[drm] " fmt, ##__VA_ARGS__) I guess I'm th only one who #undef DRM_NAME #define DRM_NAME i915 just so that I didn't have inane logs? One might suggest that instead of hardcoding it, follow the pr_fmt() pattern and only add "[drm]" for the drm core. Even then it so useless (which drm driver is this message for???) that I want to remove them all :( -Chris _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel