From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66055C76186 for ; Thu, 25 Jul 2019 03:20:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37C302075C for ; Thu, 25 Jul 2019 03:20:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="S7EYvZKR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37C302075C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DCQRBLcqnu3pI88mFuTmTMl/pGJq+luYovpE7pIhP1E=; b=S7EYvZKRh3cD8N bCvZkio+xrGg4US8JwkJi45ug+vx0wQQLkRuQgfCIL0MOYUP/5sOCbfsVnGFLcIxpI3/r2DQsS5Aw oenj/LdQZq8iVWDBHT10O7x29bFwFg51lZ8mZxF4AWQnOVvwwhSYesk6DSTBdYp1Hk7IIq4syhNDn +zLuY7jfOB5PHF4MpfJs7H/pB+C8a6XKcWae00Nz01uZkQ7Gty7ShcvXPwaYOOethRUcr4MaRPDv0 UTK4GOeq8s5LvIK+VA799evd001wRuw0gr2IL/SgzpGsWR4SPvdS5Dyr/dzxhrF3L5IAgNLbPZxRy V/IKwGmPjrz1FsZKpeKQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqUJA-0003qN-8r; Thu, 25 Jul 2019 03:20:44 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqUJ6-0003oC-3d; Thu, 25 Jul 2019 03:20:41 +0000 X-UUID: de8e2c0d068a42c18292777dd1df6c09-20190724 X-UUID: de8e2c0d068a42c18292777dd1df6c09-20190724 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1002913618; Wed, 24 Jul 2019 19:20:24 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 24 Jul 2019 20:20:22 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 25 Jul 2019 11:20:19 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 25 Jul 2019 11:20:19 +0800 Message-ID: <1564024819.2621.4.camel@mtksdaap41> Subject: Re: [PATCH v4, 05/33] dt-bindings: mediatek: add RDMA1 description for mt8183 display From: CK Hu To: Rob Herring Date: Thu, 25 Jul 2019 11:20:19 +0800 In-Reply-To: <20190724201635.GA18345@bogus> References: <1562625253-29254-1-git-send-email-yongqiang.niu@mediatek.com> <1562625253-29254-6-git-send-email-yongqiang.niu@mediatek.com> <20190724201635.GA18345@bogus> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 7D8A1CCF38AD247D3F162A72E891F36A49E6C52CAB3DEA3F413B16EB119711E62000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190724_202040_159237_0182EAE4 X-CRM114-Status: GOOD ( 15.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Philipp Zabel , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, yongqiang.niu@mediatek.com, linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Rob: On Wed, 2019-07-24 at 14:16 -0600, Rob Herring wrote: > On Tue, Jul 09, 2019 at 06:33:45AM +0800, yongqiang.niu@mediatek.com wrote: > > From: Yongqiang Niu > > > > This patch add RDMA1 description for mt8183 display > > > > Signed-off-by: Yongqiang Niu > > --- > > Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > > index afd3c90..bb9274a 100644 > > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt > > @@ -30,6 +30,7 @@ Required properties (all function blocks): > > "mediatek,-disp-ovl" - overlay (4 layers, blending, csc) > > "mediatek,-disp-ovl-2l" - overlay (2 layers, blending, csc) > > "mediatek,-disp-rdma" - read DMA / line buffer > > + "mediatek,-disp-rdma1" - function is same with RDMA, fifo size is different > > This can't be determined by which chip it is? IOW, a chip may have both > rdma and rdma1? In MT8183, there are two different rdma. The difference is the fifo size in each one. I've a question: is it better to have two compatible string for each one, or just one compatible string for both but with a property to set fifo size? Regards, CK > > > "mediatek,-disp-wdma" - write DMA > > "mediatek,-disp-ccorr" - color correction > > "mediatek,-disp-color" - color processor > > -- > > 1.8.1.1.dirty > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel