From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 718A5C7618B for ; Mon, 29 Jul 2019 11:58:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44E1D214AE for ; Mon, 29 Jul 2019 11:58:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qQ+fJC/6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44E1D214AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K4jdAPLWhbQT6jS5/2EZpgXhe5vX1fPYf/UukLK1hrU=; b=qQ+fJC/6OwZiB1 p2Ft7a94KN8nKR7DwNHUPvEs80fhAZ5OzfTtXHIN/+2Uh2P5tA1eRYDic66EOinnNSSIGhBmWf7ej w3bvwlpGwhuIiUIKqPFqm245sCQ62Vc0yQvTOEDRpnSP4YWIEo9DRZ4/wif0/9hpFL3lgufXJ69jn ApK7UMv7D14WKKVcQvb/VJPSw+6Hnwn86P3ChBIaDbpDklufAbnhU5D2V9wT/H3TFChulrW1SwFKJ UyBpHVyCgCWtN6YZTeR4YLYdct70j/jd7/740rMgKaUkyyDX4wsk/nhjaWmHnI3MQqmfnHgdVpzY5 lUcDdoSnS2OYytNu0dcA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hs4IO-0003S5-Q1; Mon, 29 Jul 2019 11:58:28 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hs4IK-0003Qq-NQ; Mon, 29 Jul 2019 11:58:26 +0000 X-UUID: 86e2f3de9e344b7c97b08e61b6848155-20190729 X-UUID: 86e2f3de9e344b7c97b08e61b6848155-20190729 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 802398199; Mon, 29 Jul 2019 03:58:20 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 29 Jul 2019 04:58:19 -0700 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 29 Jul 2019 19:58:11 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 29 Jul 2019 19:58:11 +0800 Message-ID: <1564401491.15267.405.camel@mtksdccf07> Subject: Re: [RFC PATCH V2 4/4] platform: mtk-isp: Add Mediatek FD driver From: Jerry-ch Chen To: Tomasz Figa Date: Mon, 29 Jul 2019 19:58:11 +0800 In-Reply-To: References: <1562661672-22439-1-git-send-email-Jerry-Ch.chen@mediatek.com> <1562661672-22439-5-git-send-email-Jerry-Ch.chen@mediatek.com> <1564380061.15267.383.camel@mtksdccf07> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190729_045824_771385_647F3A86 X-CRM114-Status: GOOD ( 38.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "laurent.pinchart+renesas@ideasonboard.com" , Rynn Wu =?UTF-8?Q?=28=E5=90=B3=E8=82=B2=E6=81=A9=29?= , Po-Yang Huang =?UTF-8?Q?=28=E9=BB=83=E6=9F=8F=E9=99=BD=29?= , "suleiman@chromium.org" , jerry-ch.chen@mediatek.com, Jungo Lin =?UTF-8?Q?=28=E6=9E=97=E6=98=8E=E4=BF=8A=29?= , "hans.verkuil@cisco.com" , Sakari Ailus , Frederic Chen =?UTF-8?Q?=28=E9=99=B3=E4=BF=8A=E5=85=83=29?= , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , Sj Huang =?UTF-8?Q?=28=E9=BB=83=E4=BF=A1=E7=92=8B=29?= , "yuzhao@chromium.org" , "linux-mediatek@lists.infradead.org" , "matthias.bgg@gmail.com" , "mchehab@kernel.org" , "linux-arm-kernel@lists.infradead.org" , Sean Cheng =?UTF-8?Q?=28=E9=84=AD=E6=98=87=E5=BC=98=29?= , srv_heupstream , "shik@chromium.org" , Christie Yu =?UTF-8?Q?=28=E6=B8=B8=E9=9B=85=E6=83=A0=29?= , "zwisler@chromium.org" , Hans Verkuil , "Enrico Weigelt, metux IT consult" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tomasz, On Mon, 2019-07-29 at 17:57 +0800, Tomasz Figa wrote: > On Mon, Jul 29, 2019 at 3:01 PM Jerry-ch Chen > wrote: > > > > Hi Enrico, > > > > On Tue, 2019-07-09 at 18:56 +0800, Enrico Weigelt, metux IT consult > > wrote: > > > On 09.07.19 10:41, Jerry-ch Chen wrote: > > > > > > Hi, > > > > > > > > > > diff --git a/drivers/media/platform/mtk-isp/fd/mtk_fd.h b/drivers/media/platform/mtk-isp/fd/mtk_fd.h > > > > new file mode 100644 > > > > index 0000000..289999b > > > > --- /dev/null > > > > +++ b/drivers/media/platform/mtk-isp/fd/mtk_fd.h > > > > @@ -0,0 +1,157 @@ > > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > > +// > > > > +// Copyright (c) 2018 MediaTek Inc. > > > > + > > > > +#ifndef __MTK_FD_HW_H__ > > > > +#define __MTK_FD_HW_H__ > > > > + > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > + > > > > +#define MTK_FD_OUTPUT_MIN_WIDTH 26U > > > > +#define MTK_FD_OUTPUT_MIN_HEIGHT 26U > > > > +#define MTK_FD_OUTPUT_MAX_WIDTH 640U > > > > +#define MTK_FD_OUTPUT_MAX_HEIGHT 480U > > > > + > > > > +/* Control the user defined image widths and heights > > > > + * to be scaled and performed face detection in FD HW. > > > > + * MTK FD support up to 14 user defined image sizes to perform face detection. > > > > + */ > > > > +#define V4L2_CID_MTK_FD_SCALE_IMG_WIDTH (V4L2_CID_USER_MTK_FD_BASE + 1) > > > > +#define V4L2_CID_MTK_FD_SCALE_IMG_HEIGHT (V4L2_CID_USER_MTK_FD_BASE + 2) > > > > > > I've got a *really* bad feeling about introducing chip specific > > > uapi stuff. (by the way: uapi stuff belongs into include/uapi/...) > > > > > Thanks for your comments, > > > > If we remain chip-specific control IDs, I will move the uapi stuff into > > inlcude/uapi/mtk_fd.h (filename TBD) > > > > > Maybe you could tell us what that's *really* about, so we can find some > > > standard / chip-independent api for these things. That's one of the > > > major point of the kernel: hardware abstraction. > > > > > I am not sure if it is possible for us to add some standard > > v4l2-controls for face detection, a further explanations of controls are > > listed below. > > > > In v4l2-controls, there exists V4L2_CID_DETECT_CLASS, but I haven't > > found the standards or api that can be used for face detection yet. > > https://elixir.bootlin.com/linux/latest/source/include/uapi/linux/v4l2-controls.h#L1092 > > > > For detecting certain face angle and head direction, we would need > > V4L2_CID_DETECT_ANGLE, V4L2_CID_DETECT_DIRECTION controls for user to > > specify the angle and direction to be detected. > > In MTK FD driver, we support the following angles and directions to be > > selected by user, and they are both multiple selected . > > FD_angle_table[] = {-90, -45, 0 , 45, 90} > > FD_direction_table[] = {0, 30, 60, 90, 120, 150, ..., 330} > > > > Assuming these v4l2-controls are array of V4L2_CTRL_TYPE_U16 with > > dimension 5 and 12. > > User can select the desired angle and directions to be detected into > > arrays and bring it to driver by these controls, however, the more they > > select, the longer execution time needed by HW. > > > > Sounds like we need some kind of a menu bitmask control here, but I > don't see V4L2 having anything like that. > > Hans, Sakari, any ideas? > > > For detecting different sizes of faces and increase the detection speed, > > FD driver might need to scales down the input image into different > > smaller sizes > > Do you mean the FD hardware would do the scaling or the driver code > itself? It would be undesirable to do such scaling in a kernel driver, > so if that's not something handled by the hardware, the downscaled > image might need to be provided from the userspace. > Thanks for your comments. Yes, FD hardware will do the scaling itself, so driver could set the sizes. > >, besides driver default values, user or proprietary > > algorithm library can manually set the desired image sizes, therefore, > > we would need the following controls: > > V4L2_CID_DETECT_SCALE_DOWN_IMG_WIDTH and > > V4L2_CID_DETECT_SCALE_DOWN_IMG_HEIGHT. > > In MTK FD driver, we implement these controls as array of > > V4L2_CTRL_TYPE_U16 with the dimension 15. > > Why 15? > It consists of one input image size and 14 down-scaled image sizes, the amount 15 (or say 14) is defined by the MTK FD algo library, therefore I remain the number of 15 here for communicate with the library. Maybe it should be defined as following? MTK_FD_MAX_SCALE_SIZE_NUM 14 and MTK_FD_SCALE_ARR_NUM 15 > > > > For controlling detection speed, we would need the > > V4L2_CID_DETECT_SPEED, the faster speedup implies the lower accuracy of > > detection, In MTK FD driver, the max level of speedup is 7, and default > > value is 0. > > > > For MTK FD algorithm user library, they would need select extra > > detection features(models) used in HW, we need > > V4L2_CID_MTK_FD_EXTRA_MODEL, this will be set to 1 for using extra > > model. However, we are considering make this control more > > chip-independent and can be added into standard. > > for example, V4L2_CID_DETECTION_FD_MODEL or ...FD_ALGO, > > drivers can define the detection algorithm or detection model to be used > > for users to select. How do you think? > > Sounds like something that could be a menu control, so it could vary > between drivers. > Ok, and maybe it should be created by v4l2_ctrl_new_int_menu(...)? > > > > In short, I summery the control IDs as following: > > V4L2_CID_DETECT_ANGLE: set the angle of face in degrees. 90 ~ -90 > > degrees. > > V4L2_CID_DETECT_DIRECTION: set the rotation of the head in degrees. > > 0~330 degrees. > > V4L2_CID_DETECT_SCALE_DOWN_IMG_WIDTH: set the image widths for an input > > image to be scaled down for face detection > > V4L2_CID_DETECT_SCALE_DOWN_IMG_HEIGHT: set the image heights for an > > input image to be scaled down for face detection > > V4L2_CID_DETECT_SPEED: set the detection speed, usually reducing > > accuracy. > > V4L2_CID_DETECTION_FD_MODEL: select the detection model or algorithm to > > be used by face detection driver. > > > > > > +#define ENABLE_FD 0x111 > > > > +#define FD_HW_ENABLE 0x4 > > > > +#define FD_INT_EN 0x15c > > > > +#define FD_INT 0x168 > > > > +#define FD_RESULT 0x178 > > > > +#define FD_IRQ_MASK 0x001 > > > > + > > > > +#define RS_MAX_BUF_SIZE 2288788 > > > > +#define FD_MAX_SPEEDUP 7 > > > > +#define FD_MAX_POSE_VAL 0xfffffffffffffff > > > > +#define FD_DEF_POSE_VAL 0x3ff > > > > +#define MAX_FD_SEL_NUM 1026 > > > > > > If that file is supposed to be included by anything beyond the driver > > > itself, we need proper prefixing. (same for anything else in here) > > > > > I will fix it as following: > > > > #define FD_ENABLE 0x111 > > > > #define FD_REG_OFFSET_HW_ENABLE 0x4 > > #define FD_REG_OFFSET_INT_EN 0x15c > > #define FD_REG_OFFSET_INT_VAL 0x168 > > #define FD_REG_OFFSET_RESULT 0x178 > > > > #define FD_IRQ_MASK 1 > > #define FD_MAX_RS_BUF_SIZE 2288788 > > #define FD_MAX_SPEEDUP 7 > > #define FD_MAX_RESULT_NUM 1026 > > > > I'd suggest the MTK_FD_ prefix. > Ok, I will use MTK_FD_ prefix. > > > > diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-controls.h > > > > index 3dcfc61..eae876e 100644 > > > > --- a/include/uapi/linux/v4l2-controls.h > > > > +++ b/include/uapi/linux/v4l2-controls.h > > > > @@ -192,6 +192,10 @@ enum v4l2_colorfx { > > > > * We reserve 16 controls for this driver. */ > > > > #define V4L2_CID_USER_IMX_BASE (V4L2_CID_USER_BASE + 0x10b0) > > > > > > > > +/* The base for the mediatek FD driver controls */ > > > > +/* We reserve 16 controls for this driver. */ > > > > +#define V4L2_CID_USER_MTK_FD_BASE (V4L2_CID_USER_BASE + 0x10d0) > > > > > > Why only the base, but not the actual IDs in uapi ? > > > > > I will put actual IDs in uapi/ for user to reference. > > > > > > > > --mtx > > > > > > > Best regards, > Tomasz Best regards, Jerry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel