From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E14A5C433FF for ; Tue, 6 Aug 2019 11:41:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6B2320717 for ; Tue, 6 Aug 2019 11:41:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JMZpLAYx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6B2320717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WqF8oCSFfvH1Td3WrsRaBG5i3SmtE9lCubPIJnS+RuU=; b=JMZpLAYx7AReyY g1OwZRAbh4Bre2ZmxH4Ib7i56iAQQ3/FKlK4GBhGSV2N3dl5GpmQ00gLuib5LwK+FVxC+1JEEuPYU uSOyw9P0lDmJ83C694ub7TNR61m7hSdMdLwkqaR4nJWJGZI3sG1ueNnsb+WcX0PLwHE2QRu69YGfG tUQuj9c/tBPsqGlZTC4ZAVvq0+qqFeYuj8sipIiuEkYmdT+QXc1HKP5z86dDt3FnACdgyibuFEb8Z cdtntBHu3xwMtAdskiQ5XaXVPF9pHwKK4omxgXsGwmRbd3dPzvjjsd5xGtuqyndrNan5Pz+BqGMh+ XfwBEbD3ls+HzWBPrahA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1huxql-0002hd-BP; Tue, 06 Aug 2019 11:41:55 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1huxqg-0002gG-UK; Tue, 06 Aug 2019 11:41:52 +0000 X-UUID: 9f2298722b5241ad995a982500137f52-20190806 X-UUID: 9f2298722b5241ad995a982500137f52-20190806 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 411563617; Tue, 06 Aug 2019 03:41:43 -0800 Received: from mtkmbs08n1.mediatek.inc (172.21.101.55) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 6 Aug 2019 04:41:42 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 6 Aug 2019 19:41:34 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Tue, 6 Aug 2019 19:41:32 +0800 Message-ID: <1565091692.24748.3.camel@mhfsdcap03> Subject: Re: [PATCH v4 10/10] rtc: Add support for the MediaTek MT6358 RTC From: Ran Bi To: Alexandre Belloni Date: Tue, 6 Aug 2019 19:41:32 +0800 In-Reply-To: <20190805072338.GB3600@piout.net> References: <1564982518-32163-1-git-send-email-hsin-hsiung.wang@mediatek.com> <1564982518-32163-11-git-send-email-hsin-hsiung.wang@mediatek.com> <20190805072338.GB3600@piout.net> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190806_044151_267788_8F27F844 X-CRM114-Status: GOOD ( 14.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Alessandro Zummo , srv_heupstream@mediatek.com, devicetree@vger.kernel.org, Kate Stewart , Sean Wang , Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Richard Fontana , Mark Brown , linux-mediatek@lists.infradead.org, Allison Randal , linux-rtc@vger.kernel.org, Matthias Brugger , Thomas Gleixner , Eddie Huang , Lee Jones , Hsin-Hsiung Wang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Belloni, On Mon, 2019-08-05 at 09:23 +0200, Alexandre Belloni wrote: > Hi, > > The subject should be: > > "rtc: mt6397: Add support for the MediaTek MT6358 RTC" Will be changed at next patch. > > +struct mtk_rtc_compatible { > > I would name that struct mtk_rtc_data > > > + u32 wrtgr_addr; > > and this member should be wrtgr_offset or simply wrtgr. > Will be changed at next patch. > > > > + of_id = of_match_device(mt6397_rtc_of_match, &pdev->dev); > > + if (!of_id) { > > + dev_err(&pdev->dev, "Failed to probe of_node\n"); > > + return -EINVAL; > > This will never happen because probe would not be called if there is no > match. You could also use of_device_get_match_data to avoid having to > move the of_device_id table. > Will use of_device_get_match_data() function instead of of_match_device() function. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel