From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF34C3A589 for ; Mon, 19 Aug 2019 01:30:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5594A206DF for ; Mon, 19 Aug 2019 01:30:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YxN2+s5n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5594A206DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JyYo/A1KNK3VuuigPVoh0WQKz+shwW7LDxPFcM3dXN4=; b=YxN2+s5nYFYcAS zxoS2CXUSudoiZM/TD9CAIbkKwXDk3v6CkxC9MHdoqtqOzc9tpX0Kh+WY9R6dEyLaUYBbevNYSfH2 F72ofxoi7gTq0VGD1pe3I1uona5Cub1F1xaEEYywhh9jI/99iltuJk6u4FZQGqm6IG5R6fOm1frlj Wwliio6yH+FkndZxK/rPOL8q0Lnn+46ZLzqhx3exUUf1mbxtBWkMIM7+j6TrjwoG0ynmDIGS1Lj+B r6J5GvykODccsco5zzYPABcSHtjG5Yi+w5vEBcBQ3HTnLJecD5J0zQC2nyi4TKOcnLkjJd3fUQYOp EgSp5TL6Qkz9Y/qBDc2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzWVb-0008NM-5r; Mon, 19 Aug 2019 01:30:55 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzWVW-0008Lu-Q8; Mon, 19 Aug 2019 01:30:52 +0000 X-UUID: 5be8980b20654e05bee74901865b4d13-20190818 X-UUID: 5be8980b20654e05bee74901865b4d13-20190818 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 229156875; Sun, 18 Aug 2019 17:30:33 -0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 18 Aug 2019 18:30:32 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkcas08.mediatek.inc (172.21.101.126) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 19 Aug 2019 09:30:31 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 19 Aug 2019 09:30:31 +0800 Message-ID: <1566178231.7536.1.camel@mtksdaap41> Subject: Re: [PATCH] gpu: drm: mediatek: mtk_drm_drv.c: Add of_node_put() before goto From: CK Hu To: Nishka Dasgupta Date: Mon, 19 Aug 2019 09:30:31 +0800 In-Reply-To: <20190706133021.3308-1-nishkadg.linux@gmail.com> References: <20190706133021.3308-1-nishkadg.linux@gmail.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190818_183050_852525_F50841DB X-CRM114-Status: GOOD ( 12.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: p.zabel@pengutronix.de, airlie@linux.ie, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, daniel@ffwll.ch, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Nishka: On Sat, 2019-07-06 at 19:00 +0530, Nishka Dasgupta wrote: > Each iteration of for_each_child_of_node puts the previous > node, but in the case of a goto from the middle of the loop, there is > no put, thus causing a memory leak. Hence add an of_node_put before the > goto in two places. > Issue found with Coccinelle. Applied to mediatek-drm-fixes-5.3 [1], thanks. [1] https://github.com/ckhu-mediatek/linux.git-tags/tree/mediatek-drm-fixes-5.3 Regards, CK > > Signed-off-by: Nishka Dasgupta > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 95fdbd0fbcac..2dffbc8c6d73 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -524,12 +524,15 @@ static int mtk_drm_probe(struct platform_device *pdev) > comp = devm_kzalloc(dev, sizeof(*comp), GFP_KERNEL); > if (!comp) { > ret = -ENOMEM; > + of_node_put(node); > goto err_node; > } > > ret = mtk_ddp_comp_init(dev, node, comp, comp_id, NULL); > - if (ret) > + if (ret) { > + of_node_put(node); > goto err_node; > + } > > private->ddp_comp[comp_id] = comp; > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel