From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A783C3A589 for ; Mon, 19 Aug 2019 01:40:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A1C521773 for ; Mon, 19 Aug 2019 01:40:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Elb6ni7Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A1C521773 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c9HRdGgsqNIzIRLj1uihPQkiqwRIi2+nI8MLYwHsHc4=; b=Elb6ni7Q+9o2+M 7Hg7coEK+I98t5FZ9ptpA2UgX3hZKAWuRlFphxRaeRUKEP8iLAHxwoYlGfw1FIpLCMavUd+nVRz6d kOth4SYpbzz9ZoCRGBArcfj9q4Fj1cLjf2IPsNqVQaDimr8tThK1qjZp62nDVCB4PQk+Hc89YBBNA 0KB5zAURR3OOSfIeA0GD02Mgz5HVpJGK/QQ1yR/o6qvqiKuUtpZvpb8BxcUMxQ3ayk/Q2q+CT7kh9 K5XhIIZc9k1EEhgU2hm2qt2S02C69wUs9ueldLQMIHk5Z3syfcEmuBRRv0PfvsIUyH/c6xzZywOC7 Ds7m88EK0jxjjnnc0qpQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzWei-00036W-Qf; Mon, 19 Aug 2019 01:40:20 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzWef-00035M-36; Mon, 19 Aug 2019 01:40:18 +0000 X-UUID: b687eb9887e34a09a5154b3776f13ace-20190818 X-UUID: b687eb9887e34a09a5154b3776f13ace-20190818 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1525305289; Sun, 18 Aug 2019 17:40:03 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 18 Aug 2019 18:40:01 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 19 Aug 2019 09:39:54 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 19 Aug 2019 09:39:54 +0800 Message-ID: <1566178794.6371.8.camel@mtksdaap41> Subject: Re: [RFC V2 08/11] dt-bindings: interconnect: add MT8183 interconnect dt-bindings From: Henry Chen To: Rob Herring Date: Mon, 19 Aug 2019 09:39:54 +0800 In-Reply-To: <20190501202753.GA2862@bogus> References: <1556614265-12745-1-git-send-email-henryc.chen@mediatek.com> <1556614265-12745-9-git-send-email-henryc.chen@mediatek.com> <20190501202753.GA2862@bogus> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190818_184017_143203_F24A7279 X-CRM114-Status: GOOD ( 16.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Boichat , Weiyi Lu , James Liao , Viresh Kumar , linux-kernel@vger.kernel.org, Stephen Boyd , Fan Chen , devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Georgi Djakov , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, Sorry for late reply. On Wed, 2019-05-01 at 15:27 -0500, Rob Herring wrote: > On Tue, Apr 30, 2019 at 04:51:02PM +0800, Henry Chen wrote: > > Add interconnect provider dt-bindings for MT8183. > > > > Signed-off-by: Henry Chen > > --- > > .../bindings/interconnect/mtk,mt8183.txt | 24 ++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/interconnect/mtk,mt8183.txt > > > > diff --git a/Documentation/devicetree/bindings/interconnect/mtk,mt8183.txt b/Documentation/devicetree/bindings/interconnect/mtk,mt8183.txt > > new file mode 100644 > > index 0000000..1cf1841 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/interconnect/mtk,mt8183.txt > > @@ -0,0 +1,24 @@ > > +Mediatek MT8183 interconnect binding > > This should be part of the dvfsrc binding. ok, will add these into dvfsrc binding. > > > + > > +MT8183 interconnect providers support dram bandwidth requirements. The provider > > +is able to communicate with the DVFSRC and send the dram bandwidth to it. > > +Provider nodes must reside within an DVFSRC device node. > > + > > +Required properties : > > +- compatible : shall contain only one of the following: > > + "mediatek,mt8183-emi-icc" > > +- #interconnect-cells : should contain 1 > > + > > +Examples: > > + > > +dvfsrc@10012000 { > > + compatible = "mediatek,mt8183-dvfsrc"; > > + reg = <0 0x10012000 0 0x1000>; > > + clocks = <&infracfg CLK_INFRA_DVFSRC>; > > + clock-names = "dvfsrc"; > > + ddr_emi: interconnect { > > + compatible = "mediatek,mt8183-emi-icc"; > > + #interconnect-cells = <1>; > > No need for a child node here. Just move #interconnect-cells to the > parent. Ihave tried and it cannot work if move "#interconnect-cells" to the parent. The provider nodes must reside within an DVFSRC device node. > > Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel