From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DCFBC3A59E for ; Sat, 24 Aug 2019 03:23:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BA5521874 for ; Sat, 24 Aug 2019 03:23:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Dekpl6bS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BA5521874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZuJIfJTHMbUDvCgZanvchOSIs7ArWr9OftI4ScHnBek=; b=Dekpl6bSjdF9Q3 Wk1Mgct4rXt42Kri1jJbOwsz1XSc/vmX+5o4czfSyGCg35KPiRaYr1Ll7Rnk5qojpVXgr2tYs4b0f HVF42CCu3ZXXlSPpk5hqdoMlK5FqV/Xc8Llu2/Fv2Zyi03PQtVJS1axR7fzC/tMD2CLmXMSLmfy7H IGwFAVdedGNNL3ODXhTdKN0VJaOveCPaPscD3b5H6Oy0qAwDQ+Ho41fMzWQxZGycfaShP0HzGF4Wn lTRQZU/3dfJwCm+0zCAywiJM9Cpad8mQur4f2GlHiB8t4NVl29wDCzIZTnWtwvup2iR25yYlM7GSS SnodrcoWCnT0HWEfxToA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i1MeJ-0002rL-1a; Sat, 24 Aug 2019 03:23:31 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i1MeG-0002kG-2I; Sat, 24 Aug 2019 03:23:29 +0000 X-UUID: 1de2e6c8436641e9bb2d4861f21c16f6-20190823 X-UUID: 1de2e6c8436641e9bb2d4861f21c16f6-20190823 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 725831303; Fri, 23 Aug 2019 19:23:18 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 23 Aug 2019 20:23:16 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 24 Aug 2019 11:23:15 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 24 Aug 2019 11:23:14 +0800 Message-ID: <1566617000.19935.7.camel@mhfsdcap03> Subject: Re: [PATCH v2] i2c: mediatek: disable zero-length transfers for mt8183 From: Qii Wang To: Hsin-Yi Wang Date: Sat, 24 Aug 2019 11:23:20 +0800 In-Reply-To: References: <20190822094516.55130-1-hsinyi@chromium.org> <1566547772.19935.2.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190823_202328_116064_D560CAB7 X-CRM114-Status: UNSURE ( 9.63 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Boichat , Alexandru M Stan , Wolfram Sang , Jun Gao , lkml , linux-mediatek@lists.infradead.org, linux-i2c@vger.kernel.org, Matthias Brugger , Yingjoe Chen , Thomas Gleixner , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2019-08-23 at 16:13 +0800, Hsin-Yi Wang wrote: > On Fri, Aug 23, 2019 at 4:09 PM Qii Wang wrote: > > > > > > > static u32 mtk_i2c_functionality(struct i2c_adapter *adap) > > > { > > > - return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > > > + if (adap->quirks->flags & I2C_AQ_NO_ZERO_LEN) > > > + return I2C_FUNC_I2C | > > > + (I2C_FUNC_SMBUS_EMUL & ~I2C_FUNC_SMBUS_QUICK); > > > + else > > > + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > > > > It can be removed? > See previous discussion: https://patchwork.kernel.org/patch/10814391/#22484435 > but not all SoC's quirks has I2C_AQ_NO_ZERO_LEN. ok, it looks good for me, thanks. Reviewed-by: Qii Wang _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel