From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 916A8C3A5A1 for ; Wed, 28 Aug 2019 07:48:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6526F20679 for ; Wed, 28 Aug 2019 07:48:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oA2ca9fw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6526F20679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t9kL5TxfG92REL4FD57RgmBD3KrFt4iBbh2Y67IpMpw=; b=oA2ca9fwIWke+r mSXJbqfCjJ8S0Ckvhy1RpH1VcwI2dn1bzp8i72mnq25Q1pk2MTFnrjtPb1RtRUMl2rNpvHL36IorY nxhLP/CiAXUFF144kRQc4xv7+dphNL4Syjeynr94UbTVhl3hf80zxCqDmgsGgM6Z1oJlSXEquS4uK e32GujPdyaeo7LPMIRDRlrtYMTmjDknojpYhmr2y3wlqjraDTN/pscgWqyD/7nY8pa9bEVlsuYMoe vDDJGdig3wmktqP7v5H2IazEr5iuxQ9i4cXbRqiFmVAyAeYJ+D+PHn28oqYh1w6xg0VwpxVXZatOL 6jeU6ouAFGWudO/h26pw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2sgP-0007XS-6y; Wed, 28 Aug 2019 07:47:57 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2sgL-0007X5-Dn; Wed, 28 Aug 2019 07:47:54 +0000 X-UUID: 8bc995f3fc394579abb1d74194ed534e-20190827 X-UUID: 8bc995f3fc394579abb1d74194ed534e-20190827 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 573187117; Tue, 27 Aug 2019 23:47:57 -0800 Received: from MTKMBS02N2.mediatek.inc (172.21.101.101) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 28 Aug 2019 00:47:56 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs02n2.mediatek.inc (172.21.101.101) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 28 Aug 2019 15:47:54 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 28 Aug 2019 15:47:51 +0800 Message-ID: <1566978464.7317.19.camel@mhfsdcap03> Subject: Re: [PATCH 2/2] clk: mediatek: add pericfg clocks for MT8183 From: Chunfeng Yun To: Weiyi Lu Date: Wed, 28 Aug 2019 15:47:44 +0800 In-Reply-To: <1566975333.24969.2.camel@mtksdaap41> References: <1566971755-21217-1-git-send-email-chunfeng.yun@mediatek.com> <1566971755-21217-2-git-send-email-chunfeng.yun@mediatek.com> <1566975333.24969.2.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 713EC96C0A4AABC7BF3F4C27B34FBB7BEDA8C68640AC4F87A0B57E3202F859B22000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190828_004753_472766_D1D4278E X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Ryder Lee , devicetree@vger.kernel.org, Stephen Boyd , Michael Turquette , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Rob Herring , linux-mediatek@lists.infradead.org, Matthias Brugger , Erin Lo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Weiyi, On Wed, 2019-08-28 at 14:55 +0800, Weiyi Lu wrote: > On Wed, 2019-08-28 at 13:55 +0800, Chunfeng Yun wrote: > > Add pericfg clocks for MT8183, it's used when support USB > > remote wakeup > > > > Cc: Weiyi Lu > > Signed-off-by: Chunfeng Yun > > --- > > drivers/clk/mediatek/clk-mt8183.c | 35 ++++++++++++++++++++++++++ > > include/dt-bindings/clock/mt8183-clk.h | 4 +++ > > 2 files changed, 39 insertions(+) > > > > diff --git a/drivers/clk/mediatek/clk-mt8183.c b/drivers/clk/mediatek/clk-mt8183.c > > index 1aa5f4059251..b19221bad0c9 100644 > > --- a/drivers/clk/mediatek/clk-mt8183.c > > +++ b/drivers/clk/mediatek/clk-mt8183.c > > @@ -999,6 +999,25 @@ static const struct mtk_gate infra_clks[] = { > > "msdc50_0_sel", 24), > > }; > > > > +static const struct mtk_gate_regs peri_cg_regs = { > > + .set_ofs = 0x20c, > > + .clr_ofs = 0x20c, > > + .sta_ofs = 0x20c, > > +}; > > + > > +#define GATE_PERI(_id, _name, _parent, _shift) { \ > > + .id = _id, \ > > + .name = _name, \ > > + .parent_name = _parent, \ > > + .regs = &peri_cg_regs, \ > > + .shift = _shift, \ > > + .ops = &mtk_clk_gate_ops_no_setclr_inv, \ > > +} > > Hi Chunfeng, > > I suggest > > #define GATE_PERI(_id, _name, _parent, _shift) \ > GATE_MTK(_id, _name, _parent, &peri_cg_regs, _shift, \ > &mtk_clk_gate_ops_no_setclr_inv) > Good point, thanks > > + > > +static const struct mtk_gate peri_clks[] = { > > + GATE_PERI(CLK_PERI_AXI, "periaxi", "axi_sel", 31), > > +}; > > + > > static const struct mtk_gate_regs apmixed_cg_regs = { > > .set_ofs = 0x20, > > .clr_ofs = 0x20, > > @@ -1194,6 +1213,19 @@ static int clk_mt8183_infra_probe(struct platform_device *pdev) > > return of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); > > } > > > > +static int clk_mt8183_peri_probe(struct platform_device *pdev) > > +{ > > + struct clk_onecell_data *clk_data; > > + struct device_node *node = pdev->dev.of_node; > > + > > + clk_data = mtk_alloc_clk_data(CLK_PERI_NR_CLK); > > + > > + mtk_clk_register_gates(node, peri_clks, ARRAY_SIZE(peri_clks), > > + clk_data); > > + > > + return of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); > > +} > > + > > static int clk_mt8183_mcu_probe(struct platform_device *pdev) > > { > > struct clk_onecell_data *clk_data; > > @@ -1223,6 +1255,9 @@ static const struct of_device_id of_match_clk_mt8183[] = { > > }, { > > .compatible = "mediatek,mt8183-infracfg", > > .data = clk_mt8183_infra_probe, > > + }, { > > + .compatible = "mediatek,mt8183-pericfg", > > + .data = clk_mt8183_peri_probe, > > }, { > > .compatible = "mediatek,mt8183-mcucfg", > > .data = clk_mt8183_mcu_probe, > > diff --git a/include/dt-bindings/clock/mt8183-clk.h b/include/dt-bindings/clock/mt8183-clk.h > > index 0046506eb24c..a7b470b0ec8a 100644 > > --- a/include/dt-bindings/clock/mt8183-clk.h > > +++ b/include/dt-bindings/clock/mt8183-clk.h > > @@ -284,6 +284,10 @@ > > #define CLK_INFRA_FBIST2FPC 100 > > #define CLK_INFRA_NR_CLK 101 > > > > +/* PERICFG */ > > +#define CLK_PERI_AXI 0 > > +#define CLK_PERI_NR_CLK 1 > > + > > /* MFGCFG */ > > #define CLK_MFG_BG3D 0 > > #define CLK_MFG_NR_CLK 1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel