From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC5DAC388C2 for ; Thu, 5 Sep 2019 14:20:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 038C921D81 for ; Thu, 5 Sep 2019 14:14:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CQGLnCju" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 038C921D81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+rqwWd7Ry+bTk8gQ2Kif6I9es1ZLmJrppHbEPjrGUEI=; b=CQGLnCjuoqqHwM unkCXhO1FJAo+11hiLlBlUyf1WAJV80g/O/Tu5GCtt655rFBB5huHYrjMS02f+hxe2GiwQ8EBcZlw ipFrGxugMPur7nlhEXUHTMoOGbsiVRaivTf5dRHxcHB7H1Pf3j78Jxx17J6EOD8xzJni92YdA3cNF r9CFBunGnhhtsdKjyuTK5BvVbqb/7huMuTN5/b0T0+Wbe+VM9ERVgXy0q3h32I9nAP5O0ibZ8SYlH zQZAUZeV7DdteacCk7k0EkY4+8bIAE5UbhLvtfRf218oiIOaV2OcjGi+Ucco2Y0uEbOuFf/36/T4C 5GuM/WceQ0J5EssLD2NA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5sWp-0001jy-LG; Thu, 05 Sep 2019 14:14:27 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i5sWm-0001jV-8a; Thu, 05 Sep 2019 14:14:25 +0000 X-UUID: 20f0eab654914ced890d55d069271c50-20190905 X-UUID: 20f0eab654914ced890d55d069271c50-20190905 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 495146118; Thu, 05 Sep 2019 06:14:20 -0800 Received: from MTKMBS01N1.mediatek.inc (172.21.101.68) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 5 Sep 2019 07:14:18 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 5 Sep 2019 22:14:10 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 5 Sep 2019 22:14:10 +0800 Message-ID: <1567692852.22453.55.camel@mtksdccf07> Subject: Re: [RFC PATCH V2 3/4] media: platform: Add Mediatek FD driver KConfig From: Jerry-ch Chen To: Laurent Pinchart Date: Thu, 5 Sep 2019 22:14:12 +0800 In-Reply-To: <20190905123054.GL5035@pendragon.ideasonboard.com> References: <1562661672-22439-1-git-send-email-Jerry-Ch.chen@mediatek.com> <1562661672-22439-4-git-send-email-Jerry-Ch.chen@mediatek.com> <20190905123054.GL5035@pendragon.ideasonboard.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190905_071424_304272_BBF22E57 X-CRM114-Status: GOOD ( 18.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Sean Cheng =?UTF-8?Q?=28=E9=84=AD=E6=98=87=E5=BC=98=29?= , "laurent.pinchart+renesas@ideasonboard.com" , Rynn Wu =?UTF-8?Q?=28=E5=90=B3=E8=82=B2=E6=81=A9=29?= , Christie Yu =?UTF-8?Q?=28=E6=B8=B8=E9=9B=85=E6=83=A0=29?= , srv_heupstream , Po-Yang Huang =?UTF-8?Q?=28=E9=BB=83=E6=9F=8F=E9=99=BD=29?= , "suleiman@chromium.org" , "shik@chromium.org" , "tfiga@chromium.org" , Jungo Lin =?UTF-8?Q?=28=E6=9E=97=E6=98=8E=E4=BF=8A=29?= , Sj Huang =?UTF-8?Q?=28=E9=BB=83=E4=BF=A1=E7=92=8B=29?= , "yuzhao@chromium.org" , "hans.verkuil@cisco.com" , "zwisler@chromium.org" , Frederic Chen =?UTF-8?Q?=28=E9=99=B3=E4=BF=8A=E5=85=83=29?= , "matthias.bgg@gmail.com" , "linux-mediatek@lists.infradead.org" , "mchehab@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, On Thu, 2019-09-05 at 20:30 +0800, Laurent Pinchart wrote: > Hi Jerry, > > Thank you for the patch. > > On Tue, Jul 09, 2019 at 04:41:11PM +0800, Jerry-ch Chen wrote: > > From: Jerry-ch Chen > > > > This patch adds KConfig for Mediatek Face Detection driver (FD). > > FD is embedded in Mediatek SoCs. It can provide hardware > > accelerated face detection function. > > > > Signed-off-by: Jerry-ch Chen > > You can squash this patch with 4/4, there's no need to keep it separate. > I appreciate your comments, Ok, I will squash it. > > --- > > drivers/media/platform/Kconfig | 2 ++ > > drivers/media/platform/mtk-isp/fd/Kconfig | 17 +++++++++++++++++ > > 2 files changed, 19 insertions(+) > > create mode 100644 drivers/media/platform/mtk-isp/fd/Kconfig > > > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > > index a505e9f..ae99258e 100644 > > --- a/drivers/media/platform/Kconfig > > +++ b/drivers/media/platform/Kconfig > > @@ -32,6 +32,8 @@ source "drivers/media/platform/davinci/Kconfig" > > > > source "drivers/media/platform/omap/Kconfig" > > > > +source "drivers/media/platform/mtk-isp/fd/Kconfig" > > + > > config VIDEO_ASPEED > > tristate "Aspeed AST2400 and AST2500 Video Engine driver" > > depends on VIDEO_V4L2 > > diff --git a/drivers/media/platform/mtk-isp/fd/Kconfig b/drivers/media/platform/mtk-isp/fd/Kconfig > > new file mode 100644 > > index 0000000..0c5eaf0 > > --- /dev/null > > +++ b/drivers/media/platform/mtk-isp/fd/Kconfig > > @@ -0,0 +1,17 @@ > > +config VIDEO_MEDIATEK_FD > > + bool "Mediatek face detection processing function" > > + select DMA_SHARED_BUFFER > > + select VIDEOBUF2_DMA_CONTIG > > + select VIDEOBUF2_CORE > > + select VIDEOBUF2_V4L2 > > + select VIDEOBUF2_MEMOPS > > + select VIDEOBUF2_VMALLOC > > Do you need both VIDEOBUF2_DMA_CONTIG and VIDEOBUF2_VMALLOC ? The driver > doesn't seem to make use of VIDEOBUF2_VMALLOC. > No, I should remove it. and also would like to update as following: depends on VIDEO_V4L2 depends on ARCH_MEDIATEK || COMPILE_TEST select VIDEOBUF2_DMA_CONTIG select VIDEOBUF2_CORE select VIDEOBUF2_V4L2 select VIDEOBUF2_MEMOPS select MEDIA_CONTROLLER select MTK_SCP > > + select MEDIA_CONTROLLER > > + > > + default n > > + help > > + Support the Face Detectioin (FD) feature. > > s/Detectioin/Detection/ > Typo fixed. > Maybe "... feature found in the Mediatek SoCs." ? I will refine as: Support the Face Detection (FD) feature in the Mediatek mt8183 Soc. Thanks and best regards, Jerry > > > + > > + FD driver is a V4L2 memory-to-memory device driver which > > + provides hardware accelerated face detection function, > > + it can detect different sizes of faces in a raw image. > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel