From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 950A3C433EF for ; Mon, 9 Sep 2019 03:56:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 679D42084D for ; Mon, 9 Sep 2019 03:56:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="inT6zhDw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 679D42084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v/VSr/Eft4jxR4y6epa34/PDqlg7/SYu/hdpr0si5dk=; b=inT6zhDwYbSneq NNjWGJDsuorUHBLE1Xz7MJBTBYAFMCgAQ2w+UvrVVtpIGd+3+3MDCrcXq5EzPA1Xfmshu9noAgFbc yjr9hdc4RbbR8dbRgSnkILUlnx7OJ3DBJCJLw/KMfwPfRNG5Ml8lwDYB8g4uRRrBaocKmtB5BQrx0 odygGvu/kdK+B5e7VAQ8cEA+UCNQN62kJWpXFHub2O8ezr4cYE2CEWZdqWm6Xh+HhFs/qTKJ0SJjC kwyDKNHpxQetNy4Do4cb6lATErqVVzhmme+WQo63b9KpXWVQ7bam0h2f56O7pWzeR9xvLsIeEjx2f xnEtOtnMPsGWeH1KvC4g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i7Ame-0002ma-AU; Mon, 09 Sep 2019 03:56:08 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i7AmY-0002lT-07; Mon, 09 Sep 2019 03:56:03 +0000 X-UUID: 464896fd223d475b938206c46b6ff8dc-20190908 X-UUID: 464896fd223d475b938206c46b6ff8dc-20190908 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1628789858; Sun, 08 Sep 2019 19:55:55 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 8 Sep 2019 20:55:53 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 9 Sep 2019 11:55:48 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 9 Sep 2019 11:55:48 +0800 Message-ID: <1568001348.21623.173.camel@mhfsdcap03> Subject: Re: [V1, 1/2] media: dt-bindings: media: i2c: Add bindings for ov8856 From: Dongchun Zhu To: Sakari Ailus Date: Mon, 9 Sep 2019 11:55:48 +0800 In-Reply-To: <20190808165416.GA1845@kekkonen.localdomain> References: <20190808092215.5608-1-dongchun.zhu@mediatek.com> <20190808092215.5608-2-dongchun.zhu@mediatek.com> <20190808165416.GA1845@kekkonen.localdomain> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 081F698E455D92653B89BAEE5D1532842DA0144527A369190CB26B39126B11652000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190908_205602_049014_85E39077 X-CRM114-Status: GOOD ( 18.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, drinkcat@chromium.org, srv_heupstream@mediatek.com, shengnan.wang@mediatek.com, Ben Kao , tfiga@chromium.org, louis.kuo@mediatek.com, sj.huang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sakari, On Thu, 2019-08-08 at 19:54 +0300, Sakari Ailus wrote: > Hi Dongchun, > > (Cc'ing Ben, too.) > > On Thu, Aug 08, 2019 at 05:22:14PM +0800, dongchun.zhu@mediatek.com wrote: > > From: Dongchun Zhu > > > > Add device tree binding documentation for the ov8856 camera sensor. > > > > Signed-off-by: Dongchun Zhu > > --- > > .../devicetree/bindings/media/i2c/ov8856.txt | 41 ++++++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 42 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8856.txt > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.txt b/Documentation/devicetree/bindings/media/i2c/ov8856.txt > > new file mode 100644 > > index 0000000..96b10e0 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.txt > > @@ -0,0 +1,41 @@ > > +* Omnivision OV8856 MIPI CSI-2 sensor > > + > > +Required Properties: > > +- compatible: shall be "ovti,ov8856" > > +- clocks: reference to the xvclk input clock > > +- clock-names: shall be "xvclk" > > Could you add "clock-frequency" property here, please, and specify the > upper and lower limits? > Sorry, this frequency of the external clock to the sensor and link-frequencies would be added in DT in next release. > > +- avdd-supply: Analog voltage supply, 2.8 volts > > +- dovdd-supply: Digital I/O voltage supply, 1.8 volts > > +- dvdd-supply: Digital core voltage supply, 1.2 volts > > +- reset-gpios: Low active reset gpio > > + > > +The device node shall contain one 'port' child node with an > > +'endpoint' subnode for its digital output video port, > > +in accordance with the video interface bindings defined in > > +Documentation/devicetree/bindings/media/video-interfaces.txt. > > +The endpoint optional property 'data-lanes' shall be "<0 1 3 4>". > > If you don't support lane reordering, then monotonically incrementing lane > numbers from 1 onwards are recommended. > > Please also make the property mandatory. > data-lanes would be required property on endpoint in next release. > > + > > +Example: > > +&i2c7 { > > + ov8856: camera-sensor@10 { > > + compatible = "ovti,ov8856"; > > + reg = <0x10>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&clk_24m_cam>; > > + > > + clocks = <&cru SCLK_TESTCLKOUT1>; > > + clock-names = "xvclk"; > > + > > + avdd-supply = <&mt6358_vcama2_reg>; > > + dvdd-supply = <&mt6358_vcamd_reg>; > > + dovdd-supply = <&mt6358_vcamio_reg>; > > + reset-gpios = <&gpio2 3 GPIO_ACTIVE_LOW>; > > + > > + port { > > + wcam_out: endpoint { > > + remote-endpoint = <&mipi_in_wcam>; > > + data-lanes = <0 1 3 4>; > > + }; > > + }; > > + }; > > +}; > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 783569e..7746c6b 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -11889,6 +11889,7 @@ L: linux-media@vger.kernel.org > > T: git git://linuxtv.org/media_tree.git > > S: Maintained > > F: drivers/media/i2c/ov8856.c > > +F: Documentation/devicetree/bindings/media/i2c/ov8856.txt > > > > OMNIVISION OV9650 SENSOR DRIVER > > M: Sakari Ailus > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel